Re: [Qemu-devel] [PATCHv3] async + suspend reworked
On 07/12/11 15:55, Alon Levy wrote: v2-v3: builds correctly with older and newer spice, and runs with older and newer qxl driver. fixed update_area_async to not use QXLRect on stack qxl-render updated to work with update_area_async correctly reverted change to update_area api - update_area still returns dirty rects array Hmm? No patch numbers in the subject? That makes the patch order unclear ... cheers, Gerd
Re: [Qemu-devel] [PATCHv3] async + suspend reworked
On 07/12/11 15:55, Alon Levy wrote: v2-v3: builds correctly with older and newer spice, and runs with older and newer qxl driver. fixed update_area_async to not use QXLRect on stack qxl-render updated to work with update_area_async correctly reverted change to update_area api - update_area still returns dirty rects array Please run scripts/checkpatch.pl on the patches (and fix the style stuff), it has a bunch of complains ... cheers, Gerd
Re: [Qemu-devel] [PATCHv3] async + suspend reworked
On Wed, Jul 13, 2011 at 08:43:57AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: v2-v3: builds correctly with older and newer spice, and runs with older and newer qxl driver. fixed update_area_async to not use QXLRect on stack qxl-render updated to work with update_area_async correctly reverted change to update_area api - update_area still returns dirty rects array Hmm? No patch numbers in the subject? That makes the patch order unclear ... Sorry, I don't understand what you mean? the comments are general, they don't apply to a specific patch out of the series. I basically do a diff against the last series (the tip) and document. cheers, Gerd
Re: [Qemu-devel] [PATCHv3] async + suspend reworked
On Wed, Jul 13, 2011 at 09:11:35AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: v2-v3: builds correctly with older and newer spice, and runs with older and newer qxl driver. fixed update_area_async to not use QXLRect on stack qxl-render updated to work with update_area_async correctly reverted change to update_area api - update_area still returns dirty rects array Please run scripts/checkpatch.pl on the patches (and fix the style stuff), it has a bunch of complains ... ok, my bad. cheers, Gerd
Re: [Qemu-devel] [PATCHv3] async + suspend reworked
On 07/13/11 10:51, Alon Levy wrote: On Wed, Jul 13, 2011 at 08:43:57AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: v2-v3: builds correctly with older and newer spice, and runs with older and newer qxl driver. fixed update_area_async to not use QXLRect on stack qxl-render updated to work with update_area_async correctly reverted change to update_area api - update_area still returns dirty rects array Hmm? No patch numbers in the subject? That makes the patch order unclear ... Sorry, I don't understand what you mean? The subject line of the patches says just [patch] not [patch index/total] which makes it hard to figure the patch ordering ... cheers, Gerd
Re: [Qemu-devel] [PATCHv3] async + suspend reworked
On Wed, Jul 13, 2011 at 12:45:24PM +0200, Gerd Hoffmann wrote: On 07/13/11 10:51, Alon Levy wrote: On Wed, Jul 13, 2011 at 08:43:57AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: v2-v3: builds correctly with older and newer spice, and runs with older and newer qxl driver. fixed update_area_async to not use QXLRect on stack qxl-render updated to work with update_area_async correctly reverted change to update_area api - update_area still returns dirty rects array Hmm? No patch numbers in the subject? That makes the patch order unclear ... Sorry, I don't understand what you mean? The subject line of the patches says just [patch] not [patch index/total] which makes it hard to figure the patch ordering ... oh, right, forgot -N. cheers, Gerd
[Qemu-devel] [PATCHv3] async + suspend reworked
v2-v3: builds correctly with older and newer spice, and runs with older and newer qxl driver. fixed update_area_async to not use QXLRect on stack qxl-render updated to work with update_area_async correctly reverted change to update_area api - update_area still returns dirty rects array Git trees: git://anongit.freedesktop.org/~alon/qemuasync_and_s3.v3 git://anongit.freedesktop.org/~alon/spice async_and_s3.v4 git://anongit.freedesktop.org/~alon/spice-protocol s3.v2 (unchanged) git://anongit.freedesktop.org/~alon/qxl s3.v3.async.v3 (unchanged) Alon Levy (12): qxl: add io_port_to_string qxl: make qxl_guest_bug take variable arguments qxl: use QXL_REVISION_* qxl: QXL_IO_UPDATE_AREA: pass ram-update_area directly to update_area qxl: async io support using new spice api qxl-render/qxl: split out qxl_save_ppm qxl-render: split out qxl_render_update_dirty_rectangles qxl-render: qxl_render_update: nop if \!ssd.running qxl-render: use update_area_async and update_area_complete qxl: qxl_send_events: ignore if stopped (instead of abort) qxl: only disallow specific io's in vga mode qxl: add QXL_IO_FLUSH_{SURFACES,RELEASE} for guest S3S4 support Gerd Hoffmann (7): spice: add worker wrapper functions. spice: add qemu_spice_display_init_common qxl: remove qxl_destroy_primary() spice/qxl: move worker wrappers qxl: fix surface tracking locking qxl: error handling fixes and cleanups. qxl: bump pci rev hw/qxl-render.c| 97 +-- hw/qxl.c | 490 hw/qxl.h | 38 - ui/spice-display.c | 94 +-- ui/spice-display.h | 33 5 files changed, 652 insertions(+), 100 deletions(-) -- 1.7.6