[Qemu-devel] [PATCHv3] qxl: only disallow specific io's in vga mode

[Alon Levy]

Since the driver is still in operation even after moving to UNDEFINED, i.e.
by destroying primary in any way.
---
 hw/qxl.c |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/hw/qxl.c b/hw/qxl.c
index 0585f02..1d6acce 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1175,8 +1175,9 @@ static void ioport_write(void *opaque, uint32_t addr, 
uint32_t val)
 case QXL_IO_LOG:
 break;
 default:
-if (d-mode == QXL_MODE_NATIVE || d-mode == QXL_MODE_COMPAT)
+if (d-mode != QXL_MODE_VGA) {
 break;
+}
 dprint(d, 1, %s: unexpected port 0x%x (%s) in vga mode\n,
 __FUNCTION__, io_port, io_port_to_string(io_port));
 /* be nice to buggy guest drivers */
-- 
1.7.6

[Qemu-devel] [PATCHv3] qxl: only disallow specific io's in vga mode

[Alon Levy]

Since the driver is still operation also after moving to UNDEFINED, i.e.
by destroying primary in any way.
---
 hw/qxl.c |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/hw/qxl.c b/hw/qxl.c
index b794b2c..99a4708 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1150,8 +1150,9 @@ static void ioport_write(void *opaque, uint32_t addr, 
uint32_t val)
 case QXL_IO_LOG:
 break;
 default:
-if (d-mode == QXL_MODE_NATIVE || d-mode == QXL_MODE_COMPAT)
+if (d-mode != QXL_MODE_VGA) {
 break;
+}
 dprint(d, 1, %s: unexpected port 0x%x (%s) in vga mode\n,
 __FUNCTION__, io_port, io_port_to_string(io_port));
 /* be nice to buggy guest drivers */
-- 
1.7.5.4