Re: [Qemu-devel] [PULL 0/2] Tracing patches

2018-12-13 Thread Peter Maydell 
On Wed, 12 Dec 2018 at 10:16, Stefan Hajnoczi  wrote:
>
> The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086:
>
>   Merge remote-tracking branch 
> 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 
> 19:18:58 +)
>
> are available in the Git repository at:
>
>   git://github.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to 7ff5920717d413d8b7c3ba13d9a0805291b9e6ec:
>
>   trace: simple style changes (2018-12-12 10:04:59 +)
>
> 
> Pull request
>
> Minor tracing improvements.
>
> 
>
> Fabiano Rosas (1):
>   tracetool: Include thread id information in log backend
>
> Larry Dewey (1):
>   trace: simple style changes
>
>  trace/simple.c   | 4 ++--
>  scripts/tracetool/backend/log.py | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes.

-- PMM

[Qemu-devel] [PULL 0/2] Tracing patches

2018-12-12 Thread Stefan Hajnoczi 
The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086:

  Merge remote-tracking branch 
'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 
19:18:58 +)

are available in the Git repository at:

  git://github.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to 7ff5920717d413d8b7c3ba13d9a0805291b9e6ec:

  trace: simple style changes (2018-12-12 10:04:59 +)


Pull request

Minor tracing improvements.



Fabiano Rosas (1):
  tracetool: Include thread id information in log backend

Larry Dewey (1):
  trace: simple style changes

 trace/simple.c   | 4 ++--
 scripts/tracetool/backend/log.py | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.19.2

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2017-08-15 Thread Peter Maydell 
On 15 August 2017 at 14:27, Stefan Hajnoczi  wrote:
> The following changes since commit 5681da292242550f37ba4c03f46a8a6f8ee9278a:
>
>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20170815' into 
> staging (2017-08-15 09:39:14 +0100)
>
> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to 840d8351774664d01c328d31ed33b0e2d85c866e:
>
>   simpletrace: fix flight recorder --no-header option (2017-08-15 12:50:29 
> +0100)
>
> 
>
> 
>
> Stefan Hajnoczi (2):
>   trace: use static event ID mapping in simpletrace.stp
>   simpletrace: fix flight recorder --no-header option
>
>  scripts/simpletrace.py   | 24 +++--
>  scripts/tracetool/format/simpletrace_stap.py | 31 
> ++--
>  2 files changed, 20 insertions(+), 35 deletions(-)

Applied, thanks.

-- PMM

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2017-08-15 Thread no-reply 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20170815132746.12540-1-stefa...@redhat.com
Subject: [Qemu-devel] [PULL 0/2] Tracing patches
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]patchew/20170814231552.24593-1-pbonz...@redhat.com 
-> patchew/20170814231552.24593-1-pbonz...@redhat.com
 t [tag update]patchew/20170815130502.8736-1-stefa...@redhat.com -> 
patchew/20170815130502.8736-1-stefa...@redhat.com
Switched to a new branch 'test'
c8a963888c simpletrace: fix flight recorder --no-header option
272f609607 trace: use static event ID mapping in simpletrace.stp

=== OUTPUT BEGIN ===
Checking PATCH 1/2: trace: use static event ID mapping in simpletrace.stp...
Checking PATCH 2/2: simpletrace: fix flight recorder --no-header option...
ERROR: line over 90 characters
#42: FILE: scripts/simpletrace.py:101:
+"""Deserialize trace records from a file, yielding record tuples 
(event_num, timestamp, pid, arg1, ..., arg6).

total: 1 errors, 0 warnings, 46 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org

[Qemu-devel] [PULL 0/2] Tracing patches

2017-08-15 Thread Stefan Hajnoczi 
The following changes since commit 5681da292242550f37ba4c03f46a8a6f8ee9278a:

  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20170815' into 
staging (2017-08-15 09:39:14 +0100)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to 840d8351774664d01c328d31ed33b0e2d85c866e:

  simpletrace: fix flight recorder --no-header option (2017-08-15 12:50:29 
+0100)





Stefan Hajnoczi (2):
  trace: use static event ID mapping in simpletrace.stp
  simpletrace: fix flight recorder --no-header option

 scripts/simpletrace.py   | 24 +++--
 scripts/tracetool/format/simpletrace_stap.py | 31 ++--
 2 files changed, 20 insertions(+), 35 deletions(-)

-- 
2.13.4

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2017-07-13 Thread Peter Maydell 
On 11 July 2017 at 09:35, Stefan Hajnoczi  wrote:
> The following changes since commit 6b06e3e49eb8c91cc286c16d6bf3181ac296f33d:
>
>   Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2017-07-10-v2' 
> into staging (2017-07-10 16:12:47 +0100)
>
> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to cbea0ac4fe4989ae70088e01ad8b5e99f7ce3846:
>
>   backends: remove empty trace-events file (2017-07-11 09:35:11 +0100)
>
> 
>
> 
>
> Daniel P. Berrange (1):
>   backends: remove empty trace-events file
>
> Lluís Vilanova (1):
>   trace: Fix early setting of events with the "vcpu" property
>

Applied, thanks.

-- PMM

[Qemu-devel] [PULL 0/2] Tracing patches

2017-07-11 Thread Stefan Hajnoczi 
The following changes since commit 6b06e3e49eb8c91cc286c16d6bf3181ac296f33d:

  Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2017-07-10-v2' into 
staging (2017-07-10 16:12:47 +0100)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to cbea0ac4fe4989ae70088e01ad8b5e99f7ce3846:

  backends: remove empty trace-events file (2017-07-11 09:35:11 +0100)





Daniel P. Berrange (1):
  backends: remove empty trace-events file

Lluís Vilanova (1):
  trace: Fix early setting of events with the "vcpu" property

 Makefile.objs  |  1 -
 trace/control-target.c | 10 +++---
 backends/trace-events  |  0
 3 files changed, 7 insertions(+), 4 deletions(-)
 delete mode 100644 backends/trace-events

-- 
2.9.4

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2017-06-13 Thread no-reply 
Hi,

This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.

Message-id: 20170613133531.24671-1-stefa...@redhat.com
Subject: [Qemu-devel] [PULL 0/2] Tracing patches
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
set -e
git submodule update --init dtc
# Let docker tests dump environment info
export SHOW_ENV=1
export J=8
time make docker-test-quick@centos6
time make docker-test-mingw@fedora
time make docker-test-build@min-glib
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
4471808 monitor: resurrect handle_qmp_command trace event
c348a5d monitor: add handle_hmp_command trace event

=== OUTPUT BEGIN ===
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into '/var/tmp/patchew-tester-tmp-hcj_xhra/src/dtc'...
Submodule path 'dtc': checked out '558cd81bdd432769b59bff01240c44f82cfb1a9d'
  BUILD   centos6
make[1]: Entering directory '/var/tmp/patchew-tester-tmp-hcj_xhra/src'
  ARCHIVE qemu.tgz
  ARCHIVE dtc.tgz
  COPYRUNNER
RUN test-quick in qemu:centos6 
Packages installed:
SDL-devel-1.2.14-7.el6_7.1.x86_64
ccache-3.1.6-2.el6.x86_64
epel-release-6-8.noarch
gcc-4.4.7-17.el6.x86_64
git-1.7.1-4.el6_7.1.x86_64
glib2-devel-2.28.8-5.el6.x86_64
libfdt-devel-1.4.0-1.el6.x86_64
make-3.81-23.el6.x86_64
package g++ is not installed
pixman-devel-0.32.8-1.el6.x86_64
tar-1.23-15.el6_8.x86_64
zlib-devel-1.2.3-29.el6.x86_64

Environment variables:
PACKAGES=libfdt-devel ccache tar git make gcc g++ zlib-devel 
glib2-devel SDL-devel pixman-devel epel-release
HOSTNAME=0dc5a5767166
TERM=xterm
MAKEFLAGS= -j8
HISTSIZE=1000
J=8
USER=root
CCACHE_DIR=/var/tmp/ccache
EXTRA_CONFIGURE_OPTS=
V=
SHOW_ENV=1
MAIL=/var/spool/mail/root
PATH=/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
PWD=/
LANG=en_US.UTF-8
TARGET_LIST=
HISTCONTROL=ignoredups
SHLVL=1
HOME=/root
TEST_DIR=/tmp/qemu-test
LOGNAME=root
LESSOPEN=||/usr/bin/lesspipe.sh %s
FEATURES= dtc
DEBUG=
G_BROKEN_FILENAMES=1
CCACHE_HASHDIR=
_=/usr/bin/env

Configure options:
--enable-werror --target-list=x86_64-softmmu,aarch64-softmmu 
--prefix=/var/tmp/qemu-build/install
/tmp/qemu-test/src/configure: line 4683: c++: command not found
No C++ compiler available; disabling C++ specific optional code
Install prefix/var/tmp/qemu-build/install
BIOS directory/var/tmp/qemu-build/install/share/qemu
binary directory  /var/tmp/qemu-build/install/bin
library directory /var/tmp/qemu-build/install/lib
module directory  /var/tmp/qemu-build/install/lib/qemu
libexec directory /var/tmp/qemu-build/install/libexec
include directory /var/tmp/qemu-build/install/include
config directory  /var/tmp/qemu-build/install/etc
local state directory   /var/tmp/qemu-build/install/var
Manual directory  /var/tmp/qemu-build/install/share/man
ELF interp prefix /usr/gnemul/qemu-%M
Source path   /tmp/qemu-test/src
C compilercc
Host C compiler   cc
C++ compiler  
Objective-C compiler cc
ARFLAGS   rv
CFLAGS-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g 
QEMU_CFLAGS   -I/usr/include/pixman-1   -I$(SRC_PATH)/dtc/libfdt -pthread 
-I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -fPIE -DPIE -m64 -mcx16 
-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes 
-Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes 
-fno-strict-aliasing -fno-common -fwrapv  -Wendif-labels 
-Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security 
-Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration 
-Wold-style-definition -Wtype-limits -fstack-protector-all
LDFLAGS   -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64 -g 
make  make
install   install
pythonpython -B
smbd  /usr/sbin/smbd
module supportno
host CPU  x86_64
host big endian   no
target list   x86_64-softmmu aarch64-softmmu
tcg debug enabled no
gprof enabled no
sparse enabledno
strip binariesyes
profiler  no
static build  no
pixmansystem
SDL support   yes (1.2.14)
GTK support   no 
GTK GL supportno
VTE support   no 
TLS priority  NORMAL
GNUTLS supportno
GNUTLS rndno
libgcrypt no
libgcrypt kdf no
nettleno 
nettle kdfno
libtasn1  no
curses supportno
virgl support no
curl support  no
mingw32 support   no
Audio drivers oss
Block whitelist (rw) 
Block whitelist (ro) 
VirtFS supportno
VNC support   yes
VNC SASL support  no
VNC JPEG support  no
VNC PNG support   no
xen support   no
brlapi supportno
bluez  supportno
Documentation no
PIE   yes
vde support   no
netmap supportno
Linux AIO support no
ATTR/XATTR support yes
Install blobs yes
KVM support   yes
HAX support

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2017-06-13 Thread Peter Maydell 
On 13 June 2017 at 14:35, Stefan Hajnoczi  wrote:
> The following changes since commit 9746211baa6ff1275e9c726c6f3a3bcfe4b1f8bd:
>
>   Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.10-20170609' 
> into staging (2017-06-13 11:56:00 +0100)
>
> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to b097efc0027e36fd15a4fc2e415e780611024757:
>
>   monitor: resurrect handle_qmp_command trace event (2017-06-13 14:35:11 
> +0100)
>
> 
>
> 
>
> Stefan Hajnoczi (2):
>   monitor: add handle_hmp_command trace event
>   monitor: resurrect handle_qmp_command trace event
>
>  monitor.c| 7 +++
>  trace-events | 2 ++
>  2 files changed, 9 insertions(+)


Applied, thanks.

-- PMM

[Qemu-devel] [PULL 0/2] Tracing patches

2017-06-13 Thread Stefan Hajnoczi 
The following changes since commit 9746211baa6ff1275e9c726c6f3a3bcfe4b1f8bd:

  Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.10-20170609' 
into staging (2017-06-13 11:56:00 +0100)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to b097efc0027e36fd15a4fc2e415e780611024757:

  monitor: resurrect handle_qmp_command trace event (2017-06-13 14:35:11 +0100)





Stefan Hajnoczi (2):
  monitor: add handle_hmp_command trace event
  monitor: resurrect handle_qmp_command trace event

 monitor.c| 7 +++
 trace-events | 2 ++
 2 files changed, 9 insertions(+)

-- 
2.9.4

[Qemu-devel] [PULL 0/2] Tracing patches

2017-02-13 Thread Stefan Hajnoczi 
The following changes since commit 6311b19b5c650388745aafe1269489bd5afe4f2d:

  Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170210' 
into staging (2017-02-10 18:54:30 +)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to 6eab3544f47207e976df37a85c5855bf55754713:

  Makefile: Make "install" depend on "trace-events-all" (2017-02-13 13:38:31 
+)





Fam Zheng (1):
  Makefile: Make "install" depend on "trace-events-all"

Philipp Gesang (1):
  docs: update manpage for stderr->log rename

 Makefile   | 2 +-
 qemu-option-trace.texi | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.9.3

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2016-03-14 Thread Peter Maydell 
On 14 March 2016 at 11:27, Stefan Hajnoczi  wrote:
> The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into 
> staging (2016-03-10 02:51:14 +)
>
> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to f2d089425d43735b5369f70f3a36b712440578e5:
>
>   trace: separate MMIO tracepoints from TB-access tracepoints (2016-03-14 
> 09:34:30 +)
>
> 

Applied, thanks.

-- PMM

[Qemu-devel] [PULL 0/2] Tracing patches

2016-03-14 Thread Stefan Hajnoczi 
The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e:

  Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into 
staging (2016-03-10 02:51:14 +)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to f2d089425d43735b5369f70f3a36b712440578e5:

  trace: separate MMIO tracepoints from TB-access tracepoints (2016-03-14 
09:34:30 +)





Hollis Blanchard (2):
  trace: include CPU index in trace_memory_region_*()
  trace: separate MMIO tracepoints from TB-access tracepoints

 memory.c | 62 
 trace-events | 10 ++
 2 files changed, 56 insertions(+), 16 deletions(-)

-- 
2.5.0

[Qemu-devel] [PULL 0/2] Tracing patches

2015-10-09 Thread Stefan Hajnoczi 
The following changes since commit 1d27b91723c252d9a97151dc1959cfd89c5816cb:

  Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20151007.0' 
into staging (2015-10-08 16:50:34 +0100)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to 98cf48f60aa4999f5b2808569a193a401a390e6a:

  trace: remove malloc tracing (2015-10-09 10:14:05 +0100)





Lin Ma (1):
  docs: update the usage example of "dtrace" backend in tracing.txt

Paolo Bonzini (1):
  trace: remove malloc tracing

 docs/tracing.txt | 10 +-
 trace-events |  3 ---
 vl.c | 27 ---
 3 files changed, 5 insertions(+), 35 deletions(-)

-- 
2.4.3

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2015-10-09 Thread Peter Maydell 
On 9 October 2015 at 10:15, Stefan Hajnoczi  wrote:
> The following changes since commit 1d27b91723c252d9a97151dc1959cfd89c5816cb:
>
>   Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20151007.0' 
> into staging (2015-10-08 16:50:34 +0100)
>
> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to 98cf48f60aa4999f5b2808569a193a401a390e6a:
>
>   trace: remove malloc tracing (2015-10-09 10:14:05 +0100)
>

Applied, thanks.

-- PMM

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2015-03-07 Thread Peter Maydell 
On 3 March 2015 at 06:45, Stefan Hajnoczi stefa...@redhat.com wrote:
 The following changes since commit b8a173b25c887a606681fc35a46702c164d5b2d0:

   Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into 
 staging (2015-03-02 14:25:48 +)

 are available in the git repository at:

   git://github.com/stefanha/qemu.git tags/tracing-pull-request

 for you to fetch changes up to 0b7e89b103b899c21b9ab37dbf9b832db8d18108:

   trace: add DTrace reserved words for .d files (2015-03-02 15:39:43 -0600)

 

 

Applied, thanks.

-- PMM

[Qemu-devel] [PULL 0/2] Tracing patches

2015-03-02 Thread Stefan Hajnoczi 
The following changes since commit b8a173b25c887a606681fc35a46702c164d5b2d0:

  Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into 
staging (2015-03-02 14:25:48 +)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to 0b7e89b103b899c21b9ab37dbf9b832db8d18108:

  trace: add DTrace reserved words for .d files (2015-03-02 15:39:43 -0600)





Dr. David Alan Gilbert (1):
  unbreak dtrace tracing due to double _ in rdma names

Stefan Hajnoczi (1):
  trace: add DTrace reserved words for .d files

 migration/rdma.c  | 24 +++-
 scripts/tracetool/format/d.py | 26 +++---
 trace-events  |  4 ++--
 3 files changed, 32 insertions(+), 22 deletions(-)

-- 
2.1.0

[Qemu-devel] [PULL 0/2] Tracing patches

2014-11-18 Thread Stefan Hajnoczi 
The following changes since commit 1aba4be97eb01b650d146c7f01dc961d55da62ab:

  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging 
(2014-11-17 17:22:03 +)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to 776ec96f790e2c943c13313d8ecab4713b47ab65:

  Tracing: Fix simpletrace.py error on tcg enabled binary traces (2014-11-18 
14:05:58 +)





Christoph Seifert (1):
  Tracing: Fix simpletrace.py error on tcg enabled binary traces

Dr. David Alan Gilbert (1):
  Tracing docs fix configure option and description

 docs/tracing.txt  |  6 ++--
 scripts/tracetool/__init__.py | 67 +--
 2 files changed, 36 insertions(+), 37 deletions(-)

-- 
2.1.0

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2014-11-18 Thread Peter Maydell 
On 18 November 2014 15:04, Stefan Hajnoczi stefa...@redhat.com wrote:
 The following changes since commit 1aba4be97eb01b650d146c7f01dc961d55da62ab:

   Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into 
 staging (2014-11-17 17:22:03 +)

 are available in the git repository at:

   git://github.com/stefanha/qemu.git tags/tracing-pull-request

 for you to fetch changes up to 776ec96f790e2c943c13313d8ecab4713b47ab65:

   Tracing: Fix simpletrace.py error on tcg enabled binary traces (2014-11-18 
 14:05:58 +)

 

 

Applied, thanks.

-- PMM