Re: [Qemu-devel] [PULL 0/3] OpenRISC patch queue for 1.7
Hi Peter, On Fri, Aug 23, 2013 at 10:09 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 21 August 2013 03:06, Jia Liu pro...@gmail.com wrote: This is my OpenRISC patch queue for 1.7, it have been well tested, please pull. Jia Liu (3): hw/openrisc: Avoid using uninitialised variable 'entry' hw/openrisc: Fix masking in openrisc_pic_cpu_handler() hw/openrisc: Avoid undefined shift in openrisc_pic_cpu_handler() Hi -- a couple of minor notes for next time you put together a pull: (1) your process for putting the git tree together has lost the authorship -- these patches weren't written by you, but the commits in your git repo (and thus now in master) have you as the Author. (If you use 'git am' or Anthony's 'patches apply' script it will get this right.) Thank you for reminding me, I'll use git am next time. (2) You should put your own Signed-off-by: line in each patchset, as an indication that the patches have come through your tree. thanks -- PMM Regards, Jia
Re: [Qemu-devel] [PULL 0/3] OpenRISC patch queue for 1.7
On 21 August 2013 03:06, Jia Liu pro...@gmail.com wrote: This is my OpenRISC patch queue for 1.7, it have been well tested, please pull. Jia Liu (3): hw/openrisc: Avoid using uninitialised variable 'entry' hw/openrisc: Fix masking in openrisc_pic_cpu_handler() hw/openrisc: Avoid undefined shift in openrisc_pic_cpu_handler() Hi -- a couple of minor notes for next time you put together a pull: (1) your process for putting the git tree together has lost the authorship -- these patches weren't written by you, but the commits in your git repo (and thus now in master) have you as the Author. (If you use 'git am' or Anthony's 'patches apply' script it will get this right.) (2) You should put your own Signed-off-by: line in each patchset, as an indication that the patches have come through your tree. thanks -- PMM
[Qemu-devel] [PULL 0/3] OpenRISC patch queue for 1.7
Hi Anthony, This is my OpenRISC patch queue for 1.7, it have been well tested, please pull. Thanks to Peter Maydell and Xi Wang, it fix OpenRISC sim broad and pic: * Avoid using uninitialised variable 'entry' * Fix masking in openrisc_pic_cpu_handler() * Avoid undefined shift in openrisc_pic_cpu_handler() The following changes since commit ecfe10c9a6f9bc77d0e4b7eb5d0f5d61e8fbaed8: Merge remote-tracking branch 'pmaydell/tags/pull-target-arm-20130820' into staging (2013-08-20 11:23:52 -0500) are available in the git repository at: git://github.com/J-Liu/qemu.git or32 for you to fetch changes up to 7717f248eebdcfe6de400404d0cf65dcb3633308: hw/openrisc: Avoid undefined shift in openrisc_pic_cpu_handler() (2013-08-21 09:31:42 +0800) Jia Liu (3): hw/openrisc: Avoid using uninitialised variable 'entry' hw/openrisc: Fix masking in openrisc_pic_cpu_handler() hw/openrisc: Avoid undefined shift in openrisc_pic_cpu_handler() hw/openrisc/openrisc_sim.c | 3 +-- hw/openrisc/pic_cpu.c | 17 - 2 files changed, 9 insertions(+), 11 deletions(-)
[Qemu-devel] [PULL 0/3] OpenRISC patch queue
Hi Anthony, This is my OpenRISC patch queue, and myfirst time to send a pull requests, please pull. It fix OpenRISC CPU and sim broad: * Free typename in openrisc_cpu_class_by_name * Use stderr output in openrisc_sim.c * fixed a indent typo. The following changes since commit 3464700f6aecb3e2aa9098839d90672d6b3fa974: tests: Add test-bitops.c with some sextract tests (2013-07-22 15:41:49 -0500) are available in the git repository at: git://github.com/J-Liu/qemu.git or32 for you to fetch changes up to 9b146e9a28bbd9567f5ac6a8e2bcb543aa3b9392: target-openrisc: Free typename in openrisc_cpu_class_by_name (2013-07-23 18:32:30 +0800) Jia Liu (3): hw/openrisc: Indent typo hw/openrisc: Use stderr output instead of qemu_log target-openrisc: Free typename in openrisc_cpu_class_by_name hw/openrisc/openrisc_sim.c | 6 +++--- target-openrisc/cpu.c | 1 + 2 files changed, 4 insertions(+), 3 deletions(-)
