Re: [Qemu-devel] [PULL 0/5] NBD changes for 2014-06-27
Il 29/06/2014 13:55, Hani Benhabiles ha scritto: On Sun, Jun 29, 2014 at 12:45:27PM +0100, Peter Maydell wrote: On 27 June 2014 15:11, Paolo Bonzini wrote: The following changes since commit d4cba13bdf251baeedb36b87c1e9f6766773e380: tcg/ppc: Fix failure in tcg_out_mem_long (2014-06-27 13:23:41 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git nbd-next for you to fetch changes up to 34bf23a5e0e878e3cd650c47d670b881f9f61475: nbd: Handle NBD_OPT_LIST option. (2014-06-27 16:06:48 +0200) Three bugfixes, and a new feature. Hi. I'm afraid this doesn't build on win32: Hi Peter, Should be fixed with s/SHUT_RDWR/2/ That is how shutdown() is called elsewhere in nbd.c and block/nbd-client.c Will resubmit. Paolo
Re: [Qemu-devel] [PULL 0/5] NBD changes for 2014-06-27
On Sun, Jun 29, 2014 at 12:45:27PM +0100, Peter Maydell wrote: > On 27 June 2014 15:11, Paolo Bonzini wrote: > > The following changes since commit d4cba13bdf251baeedb36b87c1e9f6766773e380: > > > > tcg/ppc: Fix failure in tcg_out_mem_long (2014-06-27 13:23:41 +0100) > > > > are available in the git repository at: > > > > git://github.com/bonzini/qemu.git nbd-next > > > > for you to fetch changes up to 34bf23a5e0e878e3cd650c47d670b881f9f61475: > > > > nbd: Handle NBD_OPT_LIST option. (2014-06-27 16:06:48 +0200) > > > > Three bugfixes, and a new feature. > > Hi. I'm afraid this doesn't build on win32: Hi Peter, Should be fixed with s/SHUT_RDWR/2/ That is how shutdown() is called elsewhere in nbd.c and block/nbd-client.c > /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c: In function > ‘nbd_accept’: > /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c:31: error: > ‘SHUT_RDWR’ undeclared (first use in this function) > /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c:31: error: (Each > undeclared identifier is reported only once > /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c:31: error: for > each function it appears in.) > make: *** [blockdev-nbd.o] Error 1 > > thanks > -- PMM >
Re: [Qemu-devel] [PULL 0/5] NBD changes for 2014-06-27
On 27 June 2014 15:11, Paolo Bonzini wrote: > The following changes since commit d4cba13bdf251baeedb36b87c1e9f6766773e380: > > tcg/ppc: Fix failure in tcg_out_mem_long (2014-06-27 13:23:41 +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git nbd-next > > for you to fetch changes up to 34bf23a5e0e878e3cd650c47d670b881f9f61475: > > nbd: Handle NBD_OPT_LIST option. (2014-06-27 16:06:48 +0200) > > Three bugfixes, and a new feature. Hi. I'm afraid this doesn't build on win32: /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c: In function ‘nbd_accept’: /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c:31: error: ‘SHUT_RDWR’ undeclared (first use in this function) /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c:31: error: (Each undeclared identifier is reported only once /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c:31: error: for each function it appears in.) make: *** [blockdev-nbd.o] Error 1 thanks -- PMM
[Qemu-devel] [PULL 0/5] NBD changes for 2014-06-27
The following changes since commit d4cba13bdf251baeedb36b87c1e9f6766773e380: tcg/ppc: Fix failure in tcg_out_mem_long (2014-06-27 13:23:41 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git nbd-next for you to fetch changes up to 34bf23a5e0e878e3cd650c47d670b881f9f61475: nbd: Handle NBD_OPT_LIST option. (2014-06-27 16:06:48 +0200) Three bugfixes, and a new feature. Hani Benhabiles (5): nbd: Don't export a block device with no medium. nbd: Don't validate from and len in NBD_CMD_DISC. nbd: Shutdown socket before closing. nbd: Handle fixed new-style clients. nbd: Handle NBD_OPT_LIST option. blockdev-nbd.c | 5 ++ include/block/nbd.h | 12 +++ nbd.c | 217 qemu-nbd.c | 1 + 4 files changed, 186 insertions(+), 49 deletions(-) -- 1.8.3.1
