Re: [Qemu-devel] [PULL 0/9] Next set of s390x patches
> On Tue, 20 Oct 2015 16:35:44 +0100
> Peter Maydell wrote:
>
> > On 20 October 2015 at 16:00, Cornelia Huck wrote:
> > > The following changes since commit
> > > ee9dfed242610ecb91418270fd46b875ed56e201:
> > >
> > > Merge remote-tracking branch
> > > 'remotes/kraxel/tags/pull-input-20151020-1' into staging (2015-10-20
> > > 12:56:45 +0100)
> > >
> > > are available in the git repository at:
> > >
> > > git://github.com/cohuck/qemu tags/s390x-20151020
> > >
> > > for you to fetch changes up to bde5d1bcb63973802c21183d730e0ea7c0ae227c:
> > >
> > > s390x/cmma: clean up cmma reset (2015-10-20 16:21:01 +0200)
> > >
> > >
> > > More s390x patches. The first ones are fixes: A regression, missed
> > > compat and a missed part of the SIMD support. The others contain
> > > optimizations and cleanup.
> > >
> > >
> >
> > Hi; I'm afraid this fails to build with clang:
> > /home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-virtio-ccw.c:38:12:
> > error: duplicate 'const' declaration specifier
> > [-Werror,-Wduplicate-decl-specifier]
> > const char const *reset_dev_types[] = {
> >^
> >
> >
> >
> > Did you mean "const char * const" ? (I always have trouble with this
> > corner of C syntax...)
>
> Not only you...
>
> David, can you take a look at this?
Looks like I'm also having trouble with it ;) Guess I should start to also
compile with clang.
yes, "const char * const" should be the right thing ... if not simply "const
char *".
David
Re: [Qemu-devel] [PULL 0/9] Next set of s390x patches
Am 20.10.2015 um 17:35 schrieb Peter Maydell:
> On 20 October 2015 at 16:00, Cornelia Huck wrote:
>> The following changes since commit ee9dfed242610ecb91418270fd46b875ed56e201:
>>
>> Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20151020-1'
>> into staging (2015-10-20 12:56:45 +0100)
>>
>> are available in the git repository at:
>>
>> git://github.com/cohuck/qemu tags/s390x-20151020
>>
>> for you to fetch changes up to bde5d1bcb63973802c21183d730e0ea7c0ae227c:
>>
>> s390x/cmma: clean up cmma reset (2015-10-20 16:21:01 +0200)
>>
>>
>> More s390x patches. The first ones are fixes: A regression, missed
>> compat and a missed part of the SIMD support. The others contain
>> optimizations and cleanup.
>>
>>
>
> Hi; I'm afraid this fails to build with clang:
> /home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-virtio-ccw.c:38:12:
> error: duplicate 'const' declaration specifier
> [-Werror,-Wduplicate-decl-specifier]
> const char const *reset_dev_types[] = {
>^
>
>
>
> Did you mean "const char * const" ? (I always have trouble with this
> corner of C syntax...)
"const char * const" looks right, as the pointer and the data is const.
When fixing, you might also add "static" (please double check)
Christian
Re: [Qemu-devel] [PULL 0/9] Next set of s390x patches
On Tue, 20 Oct 2015 16:35:44 +0100
Peter Maydell wrote:
> On 20 October 2015 at 16:00, Cornelia Huck wrote:
> > The following changes since commit ee9dfed242610ecb91418270fd46b875ed56e201:
> >
> > Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20151020-1'
> > into staging (2015-10-20 12:56:45 +0100)
> >
> > are available in the git repository at:
> >
> > git://github.com/cohuck/qemu tags/s390x-20151020
> >
> > for you to fetch changes up to bde5d1bcb63973802c21183d730e0ea7c0ae227c:
> >
> > s390x/cmma: clean up cmma reset (2015-10-20 16:21:01 +0200)
> >
> >
> > More s390x patches. The first ones are fixes: A regression, missed
> > compat and a missed part of the SIMD support. The others contain
> > optimizations and cleanup.
> >
> >
>
> Hi; I'm afraid this fails to build with clang:
> /home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-virtio-ccw.c:38:12:
> error: duplicate 'const' declaration specifier
> [-Werror,-Wduplicate-decl-specifier]
> const char const *reset_dev_types[] = {
>^
>
>
>
> Did you mean "const char * const" ? (I always have trouble with this
> corner of C syntax...)
Not only you...
David, can you take a look at this?
Re: [Qemu-devel] [PULL 0/9] Next set of s390x patches
On 20 October 2015 at 16:00, Cornelia Huck wrote:
> The following changes since commit ee9dfed242610ecb91418270fd46b875ed56e201:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20151020-1'
> into staging (2015-10-20 12:56:45 +0100)
>
> are available in the git repository at:
>
> git://github.com/cohuck/qemu tags/s390x-20151020
>
> for you to fetch changes up to bde5d1bcb63973802c21183d730e0ea7c0ae227c:
>
> s390x/cmma: clean up cmma reset (2015-10-20 16:21:01 +0200)
>
>
> More s390x patches. The first ones are fixes: A regression, missed
> compat and a missed part of the SIMD support. The others contain
> optimizations and cleanup.
>
>
Hi; I'm afraid this fails to build with clang:
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-virtio-ccw.c:38:12:
error: duplicate 'const' declaration specifier
[-Werror,-Wduplicate-decl-specifier]
const char const *reset_dev_types[] = {
^
Did you mean "const char * const" ? (I always have trouble with this
corner of C syntax...)
thanks
-- PMM
[Qemu-devel] [PULL 0/9] Next set of s390x patches
The following changes since commit ee9dfed242610ecb91418270fd46b875ed56e201: Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20151020-1' into staging (2015-10-20 12:56:45 +0100) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20151020 for you to fetch changes up to bde5d1bcb63973802c21183d730e0ea7c0ae227c: s390x/cmma: clean up cmma reset (2015-10-20 16:21:01 +0200) More s390x patches. The first ones are fixes: A regression, missed compat and a missed part of the SIMD support. The others contain optimizations and cleanup. Christian Borntraeger (1): s390x/kvm: Fix vector validity bit in device machine checks Cornelia Huck (2): s390x/virtio-ccw: fix 2.4 virtio compat s390x: flagify mcic values David Hildenbrand (5): s390x: unify device reset during subsystem_reset() s390x/ipl: we always have an ipl device s390x: machine reset function with new ipl cpu handling s390x: reset crypto only on clear reset and QEMU reset s390x/cmma: clean up cmma reset Tony Krowiak (1): util/qemu-config: fix missing machine command line options hw/s390x/ipl.c | 53 +++-- hw/s390x/ipl.h | 5 +++- hw/s390x/s390-virtio-ccw.c | 44 +++ hw/s390x/s390-virtio.c | 15 +++ hw/s390x/s390-virtio.h | 1 + target-s390x/cpu.h | 65 ++ target-s390x/kvm.c | 32 --- target-s390x/misc_helper.c | 12 - util/qemu-config.c | 8 ++ 9 files changed, 168 insertions(+), 67 deletions(-) -- 2.6.2
