Re: [Qemu-devel] [PULL 00/64] slirp updates
Patchew URL: https://patchew.org/QEMU/20181218230442.27887-1-samuel.thiba...@ens-lyon.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time make docker-test-quick@centos7 SHOW_ENV=1 J=8 === TEST SCRIPT END === libpmem support no libudev no WARNING: Use of SDL 1.2 is deprecated and will be removed in WARNING: future releases. Please switch to using SDL 2.0 NOTE: cross-compilers enabled: 'cc' GEN x86_64-softmmu/config-devices.mak.tmp The full log is available at http://patchew.org/logs/20181218230442.27887-1-samuel.thiba...@ens-lyon.org/testing.docker-quick@centos7/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [Qemu-devel] [PULL 00/64] slirp updates
Patchew URL:
https://patchew.org/QEMU/20181218230442.27887-1-samuel.thiba...@ens-lyon.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181218230442.27887-1-samuel.thiba...@ens-lyon.org
Type: series
Subject: [Qemu-devel] [PULL 00/64] slirp updates
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e31b3cf slirp: Mark debugging calls as unlikely
6b01bfd slirp: call into g_debug() for DEBUG macros
a790e3d slirp: set G_LOG_DOMAIN
969e302 build-sys: use a seperate slirp-obj-y && slirp.mo
3332d62 slirp: add clock_get_ns() callback
f7af5a7 slirp: factor out guestfwd addition checks
b0b5168 slirp: replace DEBUG_ARGS with DEBUG_ARG
8493417 slirp: remove remaining DEBUG blocks
8fb3d34 slirp: use %p for pointers format
29b7c49 slirp: introduce SLIRP_DEBUG environment variable
454ba9c slirp: always build with debug statements
0b1c827 slirp: no need to make DPRINTF conditional on DEBUG
3659a07 slirp: replace a DEBUG block with WITH_ICMP_ERROR_MSG
4f8d093 slirp: replace some fprintf() with DEBUG_MISC
51a85a0 slirp: replace a fprintf with g_critical()
5120660 slirp: use virtual time for packet expiration
4193273 slirp: rename exec_list
69f9377 slirp: drop ex_chardev = do_pty == 3;$
ERROR: code indent should never use tabs
#37: FILE: slirp/misc.h:12:
+^Iint ex_chardev;$
total: 2 errors, 0 warnings, 40 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/64: slirp: use a dedicated field for chardev pointer...
ERROR: code indent should never use tabs
#79: FILE: slirp/misc.c:53:
+^I*ex_ptr = g_new0(struct ex_list, 1);$
ERROR: code indent should never use tabs
#84: FILE: slirp/misc.c:56:
+^Iif (chardev) {$
ERROR: code indent should never use tabs
#85: FILE: slirp/misc.c:57:
+^I^I(*ex_ptr)->ex_chardev = chardev;$
ERROR: code indent should never use tabs
#86: FILE: slirp/misc.c:58:
+^I} else {$
ERROR: code indent should never use tabs
#87: FILE: slirp/misc.c:59:
+^I^I(*ex_ptr)->ex_exec = g_strdup(cmdline);$
ERROR: code indent should never use tabs
#88: FILE: slirp/misc.c:60:
+^I}$
ERROR: code indent should never use tabs
#101: FILE: slirp/misc.h:12:
+^Ivoid *ex_chardev;$
total: 7 errors, 0 warnings, 100 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/64: slirp: remove unused EMU_RSH...
Checking PATCH 6/64: slirp: rename /extra/chardev...
ERROR: "foo * bar" should be "foo *bar"
#41: FILE: slirp/socket.h:70:
+ void * chardev;
total: 1 errors, 0 warnings, 28 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/64: slirp: move internal function declarations...
Checking PATCH 8/64: slirp: remove Monitor dependency, return a string for
info...
Checking PATCH 9/64: slirp: fix slirp_add_exec() leaks...
ERROR: code indent should never use tabs
#24: FILE: slirp/misc.h:15:
+^Ichar *ex_exec; /* Command line of what to exec */$
total: 1 errors, 0 warnings, 22 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 10/64: slirp: replace the poor-man string split with
g_strsplit()...
ERROR: code indent should never use tabs
#28: FILE: slirp/misc.c:91:
+^Ichar **argv;$
ERROR: code indent should never use tabs
#29: FILE: slirp/misc.c:92:
+^Iint ret;$
total: 2 errors, 0 warnings, 33 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/64: slirp: remove dead declarations...
Checking PATCH 12/64: slirp: add tftp tracing...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59:
new file mode 100644
total: 0 errors, 1 warnings, 33 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 13/64: slirp: move socket pai
Re: [Qemu-devel] [PULL 00/64] slirp updates
Patchew URL:
https://patchew.org/QEMU/20181218230442.27887-1-samuel.thiba...@ens-lyon.org/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=8
=== TEST SCRIPT END ===
CC net/filter-rewriter.o
CC net/filter-replay.o
/tmp/qemu-test/src/net/slirp.c: In function 'net_slirp_init':
/tmp/qemu-test/src/net/slirp.c:302:10: error: implicit declaration of function
'inet_pton'; did you mean 'inet_aton'? [-Werror=implicit-function-declaration]
if (!inet_pton(AF_INET6, vprefix6, &ip6_prefix)) {
^
inet_aton
/tmp/qemu-test/src/net/slirp.c:302:10: error: nested extern declaration of
'inet_pton' [-Werror=nested-externs]
cc1: all warnings being treated as errors
make: *** [/tmp/qemu-test/src/rules.mak:69: net/slirp.o] Error 1
make: *** Waiting for unfinished jobs
The full log is available at
http://patchew.org/logs/20181218230442.27887-1-samuel.thiba...@ens-lyon.org/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [Qemu-devel] [PULL 00/64] slirp updates
Marc-André Lureau, le jeu. 20 déc. 2018 16:01:44 +0400, a ecrit:
> > declaration of 'inet_pton' [-Werror=nested-externs]
> > if (!inet_pton(AF_INET6, vprefix6, &ip6_prefix)) {
> > ^
> >
>
> This one is easy, it needs "build-sys: require Vista API by default
> globally" series that Paolo has been sending in his last pullreqs.
Ok, let's wait for it for that part then.
> there is an obvious
> mistake in "build-sys: use a seperate slirp-obj-y && slirp.mo" (Sam,
> you should squash that fix)
Ok, squashed in my tree.
Samuel
Re: [Qemu-devel] [PULL 00/64] slirp updates
Hi
On Thu, Dec 20, 2018 at 4:01 PM Marc-André Lureau
wrote:
>
> Hi
>
> On Wed, Dec 19, 2018 at 11:45 PM Peter Maydell
> wrote:
> >
> > On Tue, 18 Dec 2018 at 23:04, Samuel Thibault
> > wrote:
> > >
> > > The following changes since commit
> > > e85c577158a2e8e252414959da9ef15c12eec63d:
> > >
> > > Merge remote-tracking branch
> > > 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging
> > > (2018-12-18 14:31:06 +)
> > >
> > > are available in the Git repository at:
> > >
> > > https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
> > >
> > > for you to fetch changes up to 4c2b5ca1b5dd42bb96e954db7a46ebe39fd24620:
> > >
> > > slirp: Mark debugging calls as unlikely (2018-12-18 23:44:35 +0100)
> > >
> > >
> > > Abstract away slirp toward a libslirp
> >
> > This fails to compile (all platforms):
> >
> > For the windows builds, a compile failure in slirp.c:
> > /home/petmay01/qemu-for-merges/net/slirp.c: In function 'net_slirp_init':
> > /home/petmay01/qemu-for-merges/net/slirp.c:302:10: error: implicit
> > declaration of function 'inet_pton'
> > [-Werror=implicit-function-declaration]
> > if (!inet_pton(AF_INET6, vprefix6, &ip6_prefix)) {
> > ^
> > /home/petmay01/qemu-for-merges/net/slirp.c:302:5: error: nested extern
> > declaration of 'inet_pton' [-Werror=nested-externs]
> > if (!inet_pton(AF_INET6, vprefix6, &ip6_prefix)) {
> > ^
> >
>
> This one is easy, it needs "build-sys: require Vista API by default
> globally" series that Paolo has been sending in his last pullreqs.
>
> > On Linux (x86-64 and other host archs) a link failure:
> >
> > LINKarm-softmmu/qemu-system-arm
> > ../slirp/ncsi.o: In function `ncsi_input':
> > /home/petmay01/linaro/qemu-for-merges/slirp/ncsi.c:166: undefined
> > reference to `slirp_output'
> > ../slirp/slirp.o: In function `arp_input':
> > /home/petmay01/linaro/qemu-for-merges/slirp/slirp.c:835: undefined
> > reference to `slirp_output'
> > ../slirp/slirp.o: In function `if_encap4':
> > /home/petmay01/linaro/qemu-for-merges/slirp/slirp.c:935: undefined
> > reference to `slirp_output'
> > ../slirp/slirp.o: In function `if_encap':
> > /home/petmay01/linaro/qemu-for-merges/slirp/slirp.c:1021: undefined
> > reference to `slirp_output'
> > collect2: error: ld returned 1 exit status
> > Makefile:199: recipe for target 'qemu-system-arm' failed
> >
>
> Hmm, weird linker error. Could you give some details on your build
> environment?
>
> > It also manages to provoke an internal linker error on freebsd:
> >
> > /usr/bin/ld: error in ../slirp/socket.o(.eh_frame); no .eh_frame_hdr
> > table will be created.
> > /usr/bin/ld: ../slirp/socket.o: invalid string offset 1416 >= 978 for
> > section `.strtab'
> > /usr/bin/ld: ../slirp/socket.o: invalid relocation type 38
> > /usr/bin/ld: BFD 2.17.50 [FreeBSD] 2007-07-03 assertion fail
> > /usr/src/gnu/usr.bin/binutils/libbfd/../../../../contrib/binutils/bfd/elf64-x86-
> > 64.c:276
> > /usr/bin/ld: ../slirp/socket.o: invalid relocation type 51
> > /usr/bin/ld: BFD 2.17.50 [FreeBSD] 2007-07-03 assertion fail
> > /usr/src/gnu/usr.bin/binutils/libbfd/../../../../contrib/binutils/bfd/elf64-x86-64.c:276
> > /usr/bin/ld: ../slirp/socket.o: invalid relocation type 57
> > [enormous long list of similar messages]
> > /usr/bin/ld: ../slirp/socket.o: invalid relocation type 8248
> > /usr/bin/ld: BFD 2.17.50 [FreeBSD] 2007-07-03 assertion fail
> > /usr/src/gnu/usr.bin/binutils/libbfd/../../../../contrib/binutils/bfd/elf64-x86-
> > 64.c:276
> > /usr/bin/ld: BFD 2.17.50 [FreeBSD] 2007-07-03 internal error, aborting
> > at /usr/src/gnu/usr.bin/binutils/libbfd/../../../../contrib/binutils/b
> > fd/reloc.c line 5288 in bfd_byte
> > *bfd_generic_get_relocated_section_contents(bfd *, struct
> > bfd_link_info *, struct bfd_link_order *, bfd_byte
> > *, bfd_boolean, asymbol **)
> >
> > /usr/bin/ld: Please report this bug.
>
> make vm-build-freebsd passes here... weirder
>
> >
> > c++: error: linker command failed with exit code 1 (use -v to see
> > invocation)
> >
> > On NetBSD, a different slirp.c compiler error building the bsd-user
> > target:
> > In file included from ../slirp/slirp.c:31:0:
> > /var/tmp/qemu-test.nLOQbq/include/hw/hw.h:6:2: error: #error Cannot
> > include hw/hw.h from user emulation
> > #error Cannot include hw/hw.h from user emulation
> > ^
> >
>
> make vm-build-netbsd passes here too...
>
> > On OpenBSD, a rather uninformative linker error:
> > /usr/bin/ld: final link failed: Nonrepresentable section on output
> > collect2: error: ld returned 1 exit status
>
> make vm-build-openbsd fails here however with the:
> "Cannot include hw/hw.h from user emulation" (interesting, no? ;)
>
> Eh, git blame:
> 062e552 Anthony Liguori2009-01-08 19:27 + 31│ #include "hw/hw.h"
>
> -#include "hw/hw.h"
> +#include "migration/vmstate.h"
> +#include "migration/qemu-file-types.h"
>
> Seems to solve it. I will sen
Re: [Qemu-devel] [PULL 00/64] slirp updates
Hi
On Wed, Dec 19, 2018 at 11:45 PM Peter Maydell wrote:
>
> On Tue, 18 Dec 2018 at 23:04, Samuel Thibault
> wrote:
> >
> > The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d:
> >
> > Merge remote-tracking branch
> > 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18
> > 14:31:06 +)
> >
> > are available in the Git repository at:
> >
> > https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
> >
> > for you to fetch changes up to 4c2b5ca1b5dd42bb96e954db7a46ebe39fd24620:
> >
> > slirp: Mark debugging calls as unlikely (2018-12-18 23:44:35 +0100)
> >
> >
> > Abstract away slirp toward a libslirp
>
> This fails to compile (all platforms):
>
> For the windows builds, a compile failure in slirp.c:
> /home/petmay01/qemu-for-merges/net/slirp.c: In function 'net_slirp_init':
> /home/petmay01/qemu-for-merges/net/slirp.c:302:10: error: implicit
> declaration of function 'inet_pton'
> [-Werror=implicit-function-declaration]
> if (!inet_pton(AF_INET6, vprefix6, &ip6_prefix)) {
> ^
> /home/petmay01/qemu-for-merges/net/slirp.c:302:5: error: nested extern
> declaration of 'inet_pton' [-Werror=nested-externs]
> if (!inet_pton(AF_INET6, vprefix6, &ip6_prefix)) {
> ^
>
This one is easy, it needs "build-sys: require Vista API by default
globally" series that Paolo has been sending in his last pullreqs.
> On Linux (x86-64 and other host archs) a link failure:
>
> LINKarm-softmmu/qemu-system-arm
> ../slirp/ncsi.o: In function `ncsi_input':
> /home/petmay01/linaro/qemu-for-merges/slirp/ncsi.c:166: undefined
> reference to `slirp_output'
> ../slirp/slirp.o: In function `arp_input':
> /home/petmay01/linaro/qemu-for-merges/slirp/slirp.c:835: undefined
> reference to `slirp_output'
> ../slirp/slirp.o: In function `if_encap4':
> /home/petmay01/linaro/qemu-for-merges/slirp/slirp.c:935: undefined
> reference to `slirp_output'
> ../slirp/slirp.o: In function `if_encap':
> /home/petmay01/linaro/qemu-for-merges/slirp/slirp.c:1021: undefined
> reference to `slirp_output'
> collect2: error: ld returned 1 exit status
> Makefile:199: recipe for target 'qemu-system-arm' failed
>
Hmm, weird linker error. Could you give some details on your build environment?
> It also manages to provoke an internal linker error on freebsd:
>
> /usr/bin/ld: error in ../slirp/socket.o(.eh_frame); no .eh_frame_hdr
> table will be created.
> /usr/bin/ld: ../slirp/socket.o: invalid string offset 1416 >= 978 for
> section `.strtab'
> /usr/bin/ld: ../slirp/socket.o: invalid relocation type 38
> /usr/bin/ld: BFD 2.17.50 [FreeBSD] 2007-07-03 assertion fail
> /usr/src/gnu/usr.bin/binutils/libbfd/../../../../contrib/binutils/bfd/elf64-x86-
> 64.c:276
> /usr/bin/ld: ../slirp/socket.o: invalid relocation type 51
> /usr/bin/ld: BFD 2.17.50 [FreeBSD] 2007-07-03 assertion fail
> /usr/src/gnu/usr.bin/binutils/libbfd/../../../../contrib/binutils/bfd/elf64-x86-64.c:276
> /usr/bin/ld: ../slirp/socket.o: invalid relocation type 57
> [enormous long list of similar messages]
> /usr/bin/ld: ../slirp/socket.o: invalid relocation type 8248
> /usr/bin/ld: BFD 2.17.50 [FreeBSD] 2007-07-03 assertion fail
> /usr/src/gnu/usr.bin/binutils/libbfd/../../../../contrib/binutils/bfd/elf64-x86-
> 64.c:276
> /usr/bin/ld: BFD 2.17.50 [FreeBSD] 2007-07-03 internal error, aborting
> at /usr/src/gnu/usr.bin/binutils/libbfd/../../../../contrib/binutils/b
> fd/reloc.c line 5288 in bfd_byte
> *bfd_generic_get_relocated_section_contents(bfd *, struct
> bfd_link_info *, struct bfd_link_order *, bfd_byte
> *, bfd_boolean, asymbol **)
>
> /usr/bin/ld: Please report this bug.
make vm-build-freebsd passes here... weirder
>
> c++: error: linker command failed with exit code 1 (use -v to see invocation)
>
> On NetBSD, a different slirp.c compiler error building the bsd-user
> target:
> In file included from ../slirp/slirp.c:31:0:
> /var/tmp/qemu-test.nLOQbq/include/hw/hw.h:6:2: error: #error Cannot
> include hw/hw.h from user emulation
> #error Cannot include hw/hw.h from user emulation
> ^
>
make vm-build-netbsd passes here too...
> On OpenBSD, a rather uninformative linker error:
> /usr/bin/ld: final link failed: Nonrepresentable section on output
> collect2: error: ld returned 1 exit status
make vm-build-openbsd fails here however with the:
"Cannot include hw/hw.h from user emulation" (interesting, no? ;)
Eh, git blame:
062e552 Anthony Liguori2009-01-08 19:27 + 31│ #include "hw/hw.h"
-#include "hw/hw.h"
+#include "migration/vmstate.h"
+#include "migration/qemu-file-types.h"
Seems to solve it. I will send a seperate patch.
> On OSX, the clang version of the same issue as Linux:
> Undefined symbols for architecture x86_64:
> "_slirp_output", referenced from:
> _ncsi_input in ncsi.o
> _slirp_input in slirp.o
> _if_encap in slirp.o
> ld: symbol(s) not found for architecture x86_64
> clang: err
Re: [Qemu-devel] [PULL 00/64] slirp updates
On Tue, 18 Dec 2018 at 23:04, Samuel Thibault
wrote:
>
> The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d:
>
> Merge remote-tracking branch
> 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18
> 14:31:06 +)
>
> are available in the Git repository at:
>
> https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
>
> for you to fetch changes up to 4c2b5ca1b5dd42bb96e954db7a46ebe39fd24620:
>
> slirp: Mark debugging calls as unlikely (2018-12-18 23:44:35 +0100)
>
>
> Abstract away slirp toward a libslirp
This fails to compile (all platforms):
For the windows builds, a compile failure in slirp.c:
/home/petmay01/qemu-for-merges/net/slirp.c: In function 'net_slirp_init':
/home/petmay01/qemu-for-merges/net/slirp.c:302:10: error: implicit
declaration of function 'inet_pton'
[-Werror=implicit-function-declaration]
if (!inet_pton(AF_INET6, vprefix6, &ip6_prefix)) {
^
/home/petmay01/qemu-for-merges/net/slirp.c:302:5: error: nested extern
declaration of 'inet_pton' [-Werror=nested-externs]
if (!inet_pton(AF_INET6, vprefix6, &ip6_prefix)) {
^
On Linux (x86-64 and other host archs) a link failure:
LINKarm-softmmu/qemu-system-arm
../slirp/ncsi.o: In function `ncsi_input':
/home/petmay01/linaro/qemu-for-merges/slirp/ncsi.c:166: undefined
reference to `slirp_output'
../slirp/slirp.o: In function `arp_input':
/home/petmay01/linaro/qemu-for-merges/slirp/slirp.c:835: undefined
reference to `slirp_output'
../slirp/slirp.o: In function `if_encap4':
/home/petmay01/linaro/qemu-for-merges/slirp/slirp.c:935: undefined
reference to `slirp_output'
../slirp/slirp.o: In function `if_encap':
/home/petmay01/linaro/qemu-for-merges/slirp/slirp.c:1021: undefined
reference to `slirp_output'
collect2: error: ld returned 1 exit status
Makefile:199: recipe for target 'qemu-system-arm' failed
It also manages to provoke an internal linker error on freebsd:
/usr/bin/ld: error in ../slirp/socket.o(.eh_frame); no .eh_frame_hdr
table will be created.
/usr/bin/ld: ../slirp/socket.o: invalid string offset 1416 >= 978 for
section `.strtab'
/usr/bin/ld: ../slirp/socket.o: invalid relocation type 38
/usr/bin/ld: BFD 2.17.50 [FreeBSD] 2007-07-03 assertion fail
/usr/src/gnu/usr.bin/binutils/libbfd/../../../../contrib/binutils/bfd/elf64-x86-
64.c:276
/usr/bin/ld: ../slirp/socket.o: invalid relocation type 51
/usr/bin/ld: BFD 2.17.50 [FreeBSD] 2007-07-03 assertion fail
/usr/src/gnu/usr.bin/binutils/libbfd/../../../../contrib/binutils/bfd/elf64-x86-64.c:276
/usr/bin/ld: ../slirp/socket.o: invalid relocation type 57
[enormous long list of similar messages]
/usr/bin/ld: ../slirp/socket.o: invalid relocation type 8248
/usr/bin/ld: BFD 2.17.50 [FreeBSD] 2007-07-03 assertion fail
/usr/src/gnu/usr.bin/binutils/libbfd/../../../../contrib/binutils/bfd/elf64-x86-
64.c:276
/usr/bin/ld: BFD 2.17.50 [FreeBSD] 2007-07-03 internal error, aborting
at /usr/src/gnu/usr.bin/binutils/libbfd/../../../../contrib/binutils/b
fd/reloc.c line 5288 in bfd_byte
*bfd_generic_get_relocated_section_contents(bfd *, struct
bfd_link_info *, struct bfd_link_order *, bfd_byte
*, bfd_boolean, asymbol **)
/usr/bin/ld: Please report this bug.
c++: error: linker command failed with exit code 1 (use -v to see invocation)
On NetBSD, a different slirp.c compiler error building the bsd-user
target:
In file included from ../slirp/slirp.c:31:0:
/var/tmp/qemu-test.nLOQbq/include/hw/hw.h:6:2: error: #error Cannot
include hw/hw.h from user emulation
#error Cannot include hw/hw.h from user emulation
^
On OpenBSD, a rather uninformative linker error:
/usr/bin/ld: final link failed: Nonrepresentable section on output
collect2: error: ld returned 1 exit status
On OSX, the clang version of the same issue as Linux:
Undefined symbols for architecture x86_64:
"_slirp_output", referenced from:
_ncsi_input in ncsi.o
_slirp_input in slirp.o
_if_encap in slirp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
thanks
-- PMM
[Qemu-devel] [PULL 00/64] slirp updates
The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18 14:31:06 +) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to 4c2b5ca1b5dd42bb96e954db7a46ebe39fd24620: slirp: Mark debugging calls as unlikely (2018-12-18 23:44:35 +0100) Abstract away slirp toward a libslirp Gerd Hoffmann (1): slirp: add tftp tracing Marc-André Lureau (61): slirp: associate slirp_output callback with the Slirp context slirp: remove do_pty from fork_exec() slirp: replace ex_pty with ex_chardev slirp: use a dedicated field for chardev pointer slirp: remove unused EMU_RSH slirp: rename /extra/chardev slirp: move internal function declarations slirp: remove Monitor dependency, return a string for info slirp: fix slirp_add_exec() leaks slirp: replace the poor-man string split with g_strsplit() slirp: remove dead declarations slirp: move socket pair creation in helper function slirp: remove unused M_TRAILINGSPACE slirp: use a callback structure to interface with qemu slirp: remove PROBE_CONN dead-code slirp: remove FULL_BOLT slirp: remove the disabled readv()/writev() code path slirp: remove HAVE_SYS_SIGNAL_H slirp: remove unused HAVE_SYS_BITYPES_H slirp: remove NO_UNIX_SOCKETS slirp: remove unused HAVE_SYS_STROPTS_H slirp: remove unused HAVE_ARPA_INET_H slirp: remove unused HAVE_SYS_WAIT_H slirp: remove unused HAVE_SYS_SELECT_H slirp: remove HAVE_SYS_IOCTL_H slirp: remove HAVE_SYS_FILIO_H slirp: remove unused DECLARE_IOVEC slirp: remove unused HAVE_INET_ATON slirp: replace HOST_WORDS_BIGENDIAN with glib equivalent slirp: replace SIZEOF_CHAR_P with glib equivalent slirp: replace compile time DO_KEEPALIVE slirp: remove unused global slirp_instance slirp: replace error_report() with g_critical() slirp: improve a bit the debug macros slirp: add a callback to log guest errors slirp: remove #if notdef dead code slirp: remove unused sbflush() slirp: NULL is defined by stddef.h slirp: remove dead TCP_ACK_HACK code slirp: replace ARRAY_SIZE with G_N_ELEMENTS net: do not depend on slirp internals glib-compat: add g_spawn_async_with_fds() fallback slirp: simplify fork_exec() slirp: replace error_report() with g_critical() slirp: drop
