Re: [Qemu-devel] [PULL 24/29] kvm: use DIV_ROUND_UP

[Peter Maydell]

On 31 August 2017 at 11:34, Marc-André Lureau
 wrote:
> I used the clang-tidy qemu-round check to generate the fix:
> https://github.com/elmarco/clang-tools-extra
>
> Signed-off-by: Marc-André Lureau 
> Reviewed-by: Richard Henderson 
> ---
>  linux-headers/asm-x86/kvm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-headers/asm-x86/kvm.h b/linux-headers/asm-x86/kvm.h
> index c2824d02ba..1930b95bcb 100644
> --- a/linux-headers/asm-x86/kvm.h
> +++ b/linux-headers/asm-x86/kvm.h
> @@ -153,7 +153,7 @@ struct kvm_sregs {
> __u64 cr0, cr2, cr3, cr4, cr8;
> __u64 efer;
> __u64 apic_base;
> -   __u64 interrupt_bitmap[(KVM_NR_INTERRUPTS + 63) / 64];
> +   __u64 interrupt_bitmap[DIV_ROUND_UP(KVM_NR_INTERRUPTS, 64)];
>  };
>
>  /* for KVM_GET_FPU and KVM_SET_FPU */

Hi -- I just noticed that this commit makes a change to linux-headers/.
This directory is for kernel headers which we keep in sync with the
upstream kernel via scripts/update-linux-headers.sh, so we shouldn't
be applying our code cleanups to it.

I'm going to revert it (206a0fc75d5f54886c1b3f3a65782a75e36b6b97).

thanks
-- PMM

[Qemu-devel] [PULL 24/29] kvm: use DIV_ROUND_UP

[Marc-André Lureau]

I used the clang-tidy qemu-round check to generate the fix:
https://github.com/elmarco/clang-tools-extra

Signed-off-by: Marc-André Lureau 
Reviewed-by: Richard Henderson 
---
 linux-headers/asm-x86/kvm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-headers/asm-x86/kvm.h b/linux-headers/asm-x86/kvm.h
index c2824d02ba..1930b95bcb 100644
--- a/linux-headers/asm-x86/kvm.h
+++ b/linux-headers/asm-x86/kvm.h
@@ -153,7 +153,7 @@ struct kvm_sregs {
__u64 cr0, cr2, cr3, cr4, cr8;
__u64 efer;
__u64 apic_base;
-   __u64 interrupt_bitmap[(KVM_NR_INTERRUPTS + 63) / 64];
+   __u64 interrupt_bitmap[DIV_ROUND_UP(KVM_NR_INTERRUPTS, 64)];
 };
 
 /* for KVM_GET_FPU and KVM_SET_FPU */
-- 
2.14.1.146.gd35faa819