[Qemu-devel] [PULL v2 0/1] error: More error_setg() usage
v2: Indentation touched up The following changes since commit 3c07587d49458341510360557c849e93e9afaf59: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-next-2015' into staging (2015-11-11 09:34:18 +) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-error-2015-11-11 for you to fetch changes up to 455b0fde8c38a0794743e2e7c1a40018b7bee9f6: error: More error_setg() usage (2015-11-11 18:56:26 +0100) error: More error_setg() usage Eric Blake (1): error: More error_setg() usage block.c | 3 +-- docs/writing-qmp-commands.txt | 20 +--- hw/i386/pc.c | 6 +++--- hw/net/rocker/rocker.c| 6 ++ hw/net/rocker/rocker_of_dpa.c | 12 qom/object.c | 4 ++-- 6 files changed, 21 insertions(+), 30 deletions(-) Eric Blake (1): error: More error_setg() usage block.c | 3 +-- docs/writing-qmp-commands.txt | 20 +--- hw/i386/pc.c | 6 +++--- hw/net/rocker/rocker.c| 6 ++ hw/net/rocker/rocker_of_dpa.c | 12 qom/object.c | 4 ++-- 6 files changed, 21 insertions(+), 30 deletions(-) -- 2.4.3
Re: [Qemu-devel] [PULL v2 0/1] error: More error_setg() usage
On 11 November 2015 at 17:59, Markus Armbruster wrote: > v2: Indentation touched up > > The following changes since commit 3c07587d49458341510360557c849e93e9afaf59: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-next-2015' into > staging (2015-11-11 09:34:18 +) > > are available in the git repository at: > > git://repo.or.cz/qemu/armbru.git tags/pull-error-2015-11-11 > > for you to fetch changes up to 455b0fde8c38a0794743e2e7c1a40018b7bee9f6: > > error: More error_setg() usage (2015-11-11 18:56:26 +0100) > > > error: More error_setg() usage > > > Eric Blake (1): > error: More error_setg() usage > > block.c | 3 +-- > docs/writing-qmp-commands.txt | 20 +--- > hw/i386/pc.c | 6 +++--- > hw/net/rocker/rocker.c| 6 ++ > hw/net/rocker/rocker_of_dpa.c | 12 > qom/object.c | 4 ++-- > 6 files changed, 21 insertions(+), 30 deletions(-) > > Eric Blake (1): > error: More error_setg() usage Not clear whether this is the fault of these patches, but I get 'make check' failures on OSX: GTESTER check-qtest-x86_64 blkdebug: Suspended request 'A' blkdebug: Resuming request 'A' qemu: qemu_mutex_lock: Invalid argument Broken pipe qemu-system-x86_64: Not a migration stream qemu-system-x86_64: load of migration failed: Invalid argument GTester: last random seed: R02Sfbfcf20abd428e92977792ecfb04e311 qemu: qemu_mutex_lock: Invalid argument Broken pipe qemu-system-x86_64: Not a migration stream qemu-system-x86_64: load of migration failed: Invalid argument GTester: last random seed: R02Sbc275d87280c5e0eda57526587e420e4 qemu: qemu_mutex_lock: Invalid argument Broken pipe qemu-system-x86_64: Not a migration stream qemu-system-x86_64: load of migration failed: Invalid argument GTester: last random seed: R02S55750416b970f9148f3a7f8b815fb4bb qemu: qemu_mutex_lock: Invalid argument Broken pipe qemu-system-x86_64: Not a migration stream qemu-system-x86_64: load of migration failed: Invalid argument GTester: last random seed: R02Se63079ce2611c8d190cd8a8e977115b2 qemu: qemu_mutex_lock: Invalid argument qemu-system-x86_64:Broken pipe Not a migration stream qemu-system-x86_64: load of migration failed: Invalid argument GTester: last random seed: R02S1fe6070267b9d10875b202681749a522 qemu: qemu_mutex_lock: Invalid argument Broken pipe qemu-system-x86_64: Not a migration stream qemu-system-x86_64: load of migration failed: Invalid argument GTester: last random seed: R02S0016ce2e45736aa3a77c29dac76ded01 [vmxnet3][WR][vmxnet3_peer_has_vnet_hdr]: Peer has no virtio extension. Task offloads will be emulated. thanks -- PMM
Re: [Qemu-devel] [PULL v2 0/1] error: More error_setg() usage
On 12 November 2015 at 10:28, Peter Maydell wrote: > On 11 November 2015 at 17:59, Markus Armbruster wrote: >> v2: Indentation touched up >> >> The following changes since commit 3c07587d49458341510360557c849e93e9afaf59: >> >> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-next-2015' into >> staging (2015-11-11 09:34:18 +) >> >> are available in the git repository at: >> >> git://repo.or.cz/qemu/armbru.git tags/pull-error-2015-11-11 >> >> for you to fetch changes up to 455b0fde8c38a0794743e2e7c1a40018b7bee9f6: >> >> error: More error_setg() usage (2015-11-11 18:56:26 +0100) >> >> >> error: More error_setg() usage >> >> >> Eric Blake (1): >> error: More error_setg() usage >> >> block.c | 3 +-- >> docs/writing-qmp-commands.txt | 20 +--- >> hw/i386/pc.c | 6 +++--- >> hw/net/rocker/rocker.c| 6 ++ >> hw/net/rocker/rocker_of_dpa.c | 12 >> qom/object.c | 4 ++-- >> 6 files changed, 21 insertions(+), 30 deletions(-) >> >> Eric Blake (1): >> error: More error_setg() usage > > > Not clear whether this is the fault of these patches, but I get > 'make check' failures on OSX: ...almost certainly not these patches. For some reason these don't actually cause 'make check' to return non-zero, and my "grep logs for warning/error etc" workflow wouldn't catch them. I just happened to look at this log by hand. thanks -- PMM
Re: [Qemu-devel] [PULL v2 0/1] error: More error_setg() usage
On 12 November 2015 at 10:38, Peter Maydell wrote: > On 12 November 2015 at 10:28, Peter Maydell wrote: >> On 11 November 2015 at 17:59, Markus Armbruster wrote: >>> v2: Indentation touched up >>> >>> The following changes since commit 3c07587d49458341510360557c849e93e9afaf59: >>> >>> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-next-2015' >>> into staging (2015-11-11 09:34:18 +) >>> >>> are available in the git repository at: >>> >>> git://repo.or.cz/qemu/armbru.git tags/pull-error-2015-11-11 >>> >>> for you to fetch changes up to 455b0fde8c38a0794743e2e7c1a40018b7bee9f6: >>> >>> error: More error_setg() usage (2015-11-11 18:56:26 +0100) >>> >>> >>> error: More error_setg() usage >>> >>> >>> Eric Blake (1): >>> error: More error_setg() usage >>> >>> block.c | 3 +-- >>> docs/writing-qmp-commands.txt | 20 +--- >>> hw/i386/pc.c | 6 +++--- >>> hw/net/rocker/rocker.c| 6 ++ >>> hw/net/rocker/rocker_of_dpa.c | 12 >>> qom/object.c | 4 ++-- >>> 6 files changed, 21 insertions(+), 30 deletions(-) >>> >>> Eric Blake (1): >>> error: More error_setg() usage >> >> >> Not clear whether this is the fault of these patches, but I get >> 'make check' failures on OSX: > > ...almost certainly not these patches. For some reason these > don't actually cause 'make check' to return non-zero, and > my "grep logs for warning/error etc" workflow wouldn't catch > them. I just happened to look at this log by hand. Tracked the failure down to something in the migration pull. Since that's already in master and we have rc0 scheduled for today I'm going to keep applying pullreqs for now. Applied this one to master, thanks. thanks -- PMM
