Re: [Qemu-devel] [PULL v2 00/35] Misc patches for 2018-12-18
Patchew URL: https://patchew.org/QEMU/20181219151917.3874-1-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181219151917.3874-1-pbonz...@redhat.com
Type: series
Subject: [Qemu-devel] [PULL v2 00/35] Misc patches for 2018-12-18
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
27038c1 avoid TABs in files that only contain a few
8380bfa remove space-tab sequences
dfd008b scripts: add script to convert multiline comments into 4-line format
b882f38 hw/watchdog/wdt_i6300esb: remove a unnecessary comment
623f846 checkpatch: warn about qemu/queue.h head structs that are not typedef-ed
d02ffd9 qemu/queue.h: simplify reverse access to QTAILQ
3810871 qemu/queue.h: reimplement QTAILQ without pointer-to-pointers
2008a06 qemu/queue.h: remove Q_TAILQ_{HEAD, ENTRY}
47cf78f qemu/queue.h: typedef QTAILQ heads
20e1b87 qemu/queue.h: leave head structs anonymous unless necessary
f23f8d2 vfio: make vfio_address_spaces static
cc4e7ee qemu/queue.h: do not access tqe_prev directly
d563f32 test: replace gtester with a TAP driver
602d090 test: execute g_test_run when tests are skipped
19c5978 qga: drop < Vista compatibility
7ab6ef5 build-sys: build with Vista API by default
9597923 build-sys: move windows defines in osdep.h header
f00ee90 build-sys: don't include windows.h, osdep.h does it
d397fb2 scsi: esp: Defer command completion until previous interrupts have been
handled
5868a6a esp-pci: Fix status register write erase control
21c3d03 block/iscsi: cancel libiscsi task when ABORT TASK TMF completes
04719ab block/iscsi: fix ioctl cancel use-after-free
a43e64e block/iscsi: take iscsilun->mutex in iscsi_timed_check_events()
67cce60 block/iscsi: drop unused IscsiAIOCB->buf field
6359fe7 hax: Support for Linux hosts
9a32ae1 memory: update coalesced_range on transaction_commit
8ddf23e memory: avoid unnecessary coalesced_io_del operations
922cf0d memory: extract flat_range_coalesced_io_{del, add}
2b40f43 pam: wrap MemoryRegion initialization in a transaction
a01d8ca6 checkpatch: colorize output to terminal
0848388 checkpatch: improve handling of multiple patches or files
9ca8c73 checkpatch: check Signed-off-by in --mailback mode
35c41e7 checkpatch: fix premature exit when no input or --mailback
d2ba5b1 vhost-user-bridge: fix "unknown type name" compilation error
60fb207 accel: Improve selection of the default accelerator
=== OUTPUT BEGIN ===
Checking PATCH 1/35: accel: Improve selection of the default accelerator...
Checking PATCH 2/35: vhost-user-bridge: fix "unknown type name" compilation
error...
Checking PATCH 3/35: checkpatch: fix premature exit when no input or
--mailback...
Checking PATCH 4/35: checkpatch: check Signed-off-by in --mailback mode...
Checking PATCH 5/35: checkpatch: improve handling of multiple patches or
files...
ERROR: line over 90 characters
#33: FILE: scripts/checkpatch.pl:344:
+ open($HASH, "-|", "git", "log", "--reverse", "--no-merges",
"--format=%H %s", $ARGV[0]) ||
ERROR: line over 90 characters
#34: FILE: scripts/checkpatch.pl:345:
+ die "$P: git log --reverse --no-merges --format='%H %s'
$ARGV[0] failed - $!\n";
WARNING: line over 80 characters
#65: FILE: scripts/checkpatch.pl:372:
+ $vname = substr($hash, 0, 12) . ' (' . $git_commits{$hash} .
')';
total: 2 errors, 1 warnings, 62 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/35: checkpatch: colorize output to terminal...
Checking PATCH 7/35: pam: wrap MemoryRegion initialization in a transaction...
Checking PATCH 8/35: memory: extract flat_range_coalesced_io_{del, add}...
Checking PATCH 9/35: memory: avoid unnecessary coalesced_io_del operations...
Checking PATCH 10/35: memory: update coalesced_range on transaction_commit...
Checking PATCH 11/35: hax: Support for Linux hosts...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#62:
rename from target/i386/hax-darwin.c
total: 0 errors, 1 warnings, 31 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking
Re: [Qemu-devel] [PULL v2 00/35] Misc patches for 2018-12-18
On 20/12/18 12:43, Philippe Mathieu-Daudé wrote: >> subprocess.CalledProcessError: Command '['docker', 'build', '-t', >> 'qemu:debian9', '-f', '/tmp/docker_buildsvtS6R/tmp74LVkj.docker', >> '/tmp/docker_buildsvtS6R']' returned non-zero exit status 100 >> /home/petmay01/linaro/qemu-for-merges/tests/docker/Makefile.include:53: >> recipe for target 'docker-image-debian9' failed >> make: *** [docker-image-debian9] Error 1 > > This looks an unrelated error. The Debian mirror you are using might be > out of sync (or syncing), or the filesystem where you store your Docker > image is full? Indeed I cannot reproduce it. I'll send the pull request with g_test_skip fixed (well, removed -- the harness notes 0 tests run and declares it a SKIP anyway). Paolo
Re: [Qemu-devel] [PULL v2 00/35] Misc patches for 2018-12-18
On 12/20/18 12:10 AM, Peter Maydell wrote: > On Wed, 19 Dec 2018 at 15:21, Paolo Bonzini wrote: >> >> The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d: >> >> Merge remote-tracking branch >> 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18 >> 14:31:06 +) >> >> are available in the Git repository at: >> >> git://github.com/bonzini/qemu.git tags/for-upstream >> >> for you to fetch changes up to b4e8bbb9ae50045160957e7ab66c4f1cae535ea4: >> >> avoid TABs in files that only contain a few (2018-12-19 16:03:22 +0100) >> >> >> * HAX support for Linux hosts (Alejandro) >> * esp bugfixes (Guenter) >> * Windows build cleanup (Marc-André) >> * checkpatch logic improvements (Paolo) >> * coalesced range bugfix (Paolo) >> * switch testsuite to TAP (Paolo) >> * QTAILQ rewrite (Paolo) >> * block/iscsi.c cancellation fixes (Stefan) >> * improve selection of the default accelerator (Thomas) >> >> [...] > I also get this splat trying to do 'make check-tcg': > > make: Entering directory > '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' > BUILD debian9 > The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive eatmydata > apt install -y --no-install-recommends bison > build-essential ca-certificates clang flex > gettext git libtest-harness-perl > pkg-config psmisc python texinfo > $(apt-get -s build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d\ > -f2)' returned a non-zero code: 100 > Traceback (most recent call last): > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 563, in > sys.exit(main()) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 560, in main > return args.cmdobj.run(args, argv) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 376, in run > extra_files_cksum=cksum) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 254, in build_image > quiet=quiet) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 181, in _do_check > return subprocess.check_call(self._command + cmd, **kwargs) > File "/usr/lib/python2.7/subprocess.py", line 541, in check_call > raise CalledProcessError(retcode, cmd) > subprocess.CalledProcessError: Command '['docker', 'build', '-t', > 'qemu:debian9', '-f', '/tmp/docker_buildsvtS6R/tmp74LVkj.docker', > '/tmp/docker_buildsvtS6R']' returned non-zero exit status 100 > /home/petmay01/linaro/qemu-for-merges/tests/docker/Makefile.include:53: > recipe for target 'docker-image-debian9' failed > make: *** [docker-image-debian9] Error 1 This looks an unrelated error. The Debian mirror you are using might be out of sync (or syncing), or the filesystem where you store your Docker image is full?
Re: [Qemu-devel] [PULL v2 00/35] Misc patches for 2018-12-18
On 20/12/18 00:10, Peter Maydell wrote: > I get a compile failure on my OSX system: > > CC tests/test-crypto-pbkdf.o > /Users/pm215/src/qemu-for-merges/tests/test-crypto-pbkdf.c:444:17: > error: too few arguments to function call, single argument 'msg' was > not specified > g_test_skip(); > ~~~ ^ > /usr/local/Cellar/glib/2.58.1/include/glib-2.0/glib/gtestutils.h:209:1: > note: 'g_test_skip' declared here > GLIB_AVAILABLE_IN_2_38 > ^ > /usr/local/Cellar/glib/2.58.1/include/glib-2.0/glib/gversionmacros.h:394:49: > note: expanded from macro 'GLIB_AVAILABLE_IN_2_38' > # define GLIB_AVAILABLE_IN_2_38 _GLIB_EXTERN > ^ > /usr/local/Cellar/glib/2.58.1/include/glib-2.0/glib/gmacros.h:456:22: > note: expanded from macro '_GLIB_EXTERN' > #define _GLIB_EXTERN extern > ^ > 1 error generated. Sorry, I forgot to commit the fix. > > I also get this splat trying to do 'make check-tcg': > > make: Entering directory > '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' > BUILD debian9 > The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive eatmydata > apt install -y --no-install-recommends bison > build-essential ca-certificates clang flex > gettext git libtest-harness-perl > pkg-config psmisc python texinfo > $(apt-get -s build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d\ > -f2)' returned a non-zero code: 100 > Traceback (most recent call last): > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 563, in > sys.exit(main()) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 560, in main > return args.cmdobj.run(args, argv) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 376, in run > extra_files_cksum=cksum) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 254, in build_image > quiet=quiet) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 181, in _do_check > return subprocess.check_call(self._command + cmd, **kwargs) > File "/usr/lib/python2.7/subprocess.py", line 541, in check_call > raise CalledProcessError(retcode, cmd) > subprocess.CalledProcessError: Command '['docker', 'build', '-t', > 'qemu:debian9', '-f', '/tmp/docker_buildsvtS6R/tmp74LVkj.docker', > '/tmp/docker_buildsvtS6R']' returned non-zero exit status 100 > /home/petmay01/linaro/qemu-for-merges/tests/docker/Makefile.include:53: > recipe for target 'docker-image-debian9' failed > make: *** [docker-image-debian9] Error 1 I'll try it too. Paolo
Re: [Qemu-devel] [PULL v2 00/35] Misc patches for 2018-12-18
On Wed, 19 Dec 2018 at 15:21, Paolo Bonzini wrote: > > The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18 > 14:31:06 +) > > are available in the Git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to b4e8bbb9ae50045160957e7ab66c4f1cae535ea4: > > avoid TABs in files that only contain a few (2018-12-19 16:03:22 +0100) > > > * HAX support for Linux hosts (Alejandro) > * esp bugfixes (Guenter) > * Windows build cleanup (Marc-André) > * checkpatch logic improvements (Paolo) > * coalesced range bugfix (Paolo) > * switch testsuite to TAP (Paolo) > * QTAILQ rewrite (Paolo) > * block/iscsi.c cancellation fixes (Stefan) > * improve selection of the default accelerator (Thomas) > > I get a compile failure on my OSX system: CC tests/test-crypto-pbkdf.o /Users/pm215/src/qemu-for-merges/tests/test-crypto-pbkdf.c:444:17: error: too few arguments to function call, single argument 'msg' was not specified g_test_skip(); ~~~ ^ /usr/local/Cellar/glib/2.58.1/include/glib-2.0/glib/gtestutils.h:209:1: note: 'g_test_skip' declared here GLIB_AVAILABLE_IN_2_38 ^ /usr/local/Cellar/glib/2.58.1/include/glib-2.0/glib/gversionmacros.h:394:49: note: expanded from macro 'GLIB_AVAILABLE_IN_2_38' # define GLIB_AVAILABLE_IN_2_38 _GLIB_EXTERN ^ /usr/local/Cellar/glib/2.58.1/include/glib-2.0/glib/gmacros.h:456:22: note: expanded from macro '_GLIB_EXTERN' #define _GLIB_EXTERN extern ^ 1 error generated. I also get this splat trying to do 'make check-tcg': make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' BUILD debian9 The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive eatmydata apt install -y --no-install-recommends bison build-essential ca-certificates clang flex gettext git libtest-harness-perl pkg-config psmisc python texinfo $(apt-get -s build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d\ -f2)' returned a non-zero code: 100 Traceback (most recent call last): File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 563, in sys.exit(main()) File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 560, in main return args.cmdobj.run(args, argv) File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 376, in run extra_files_cksum=cksum) File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 254, in build_image quiet=quiet) File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 181, in _do_check return subprocess.check_call(self._command + cmd, **kwargs) File "/usr/lib/python2.7/subprocess.py", line 541, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['docker', 'build', '-t', 'qemu:debian9', '-f', '/tmp/docker_buildsvtS6R/tmp74LVkj.docker', '/tmp/docker_buildsvtS6R']' returned non-zero exit status 100 /home/petmay01/linaro/qemu-for-merges/tests/docker/Makefile.include:53: recipe for target 'docker-image-debian9' failed make: *** [docker-image-debian9] Error 1 thanks -- PMM
[Qemu-devel] [PULL v2 00/35] Misc patches for 2018-12-18
The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d:
Merge remote-tracking branch
'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18
14:31:06 +)
are available in the Git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you to fetch changes up to b4e8bbb9ae50045160957e7ab66c4f1cae535ea4:
avoid TABs in files that only contain a few (2018-12-19 16:03:22 +0100)
* HAX support for Linux hosts (Alejandro)
* esp bugfixes (Guenter)
* Windows build cleanup (Marc-André)
* checkpatch logic improvements (Paolo)
* coalesced range bugfix (Paolo)
* switch testsuite to TAP (Paolo)
* QTAILQ rewrite (Paolo)
* block/iscsi.c cancellation fixes (Stefan)
* improve selection of the default accelerator (Thomas)
v1->v2: more g_test_run fixes
do not force-enable colors
Alexandro Sanchez Bach (1):
hax: Support for Linux hosts
Guenter Roeck (2):
esp-pci: Fix status register write erase control
scsi: esp: Defer command completion until previous interrupts have been
handled
Marc-André Lureau (5):
vhost-user-bridge: fix "unknown type name" compilation error
build-sys: don't include windows.h, osdep.h does it
build-sys: move windows defines in osdep.h header
build-sys: build with Vista API by default
qga: drop < Vista compatibility
Paolo Bonzini (21):
checkpatch: fix premature exit when no input or --mailback
checkpatch: check Signed-off-by in --mailback mode
checkpatch: improve handling of multiple patches or files
checkpatch: colorize output to terminal
pam: wrap MemoryRegion initialization in a transaction
memory: extract flat_range_coalesced_io_{del,add}
memory: avoid unnecessary coalesced_io_del operations
memory: update coalesced_range on transaction_commit
test: execute g_test_run when tests are skipped
test: replace gtester with a TAP driver
qemu/queue.h: do not access tqe_prev directly
vfio: make vfio_address_spaces static
qemu/queue.h: leave head structs anonymous unless necessary
qemu/queue.h: typedef QTAILQ heads
qemu/queue.h: remove Q_TAILQ_{HEAD,ENTRY}
qemu/queue.h: reimplement QTAILQ without pointer-to-pointers
qemu/queue.h: simplify reverse access to QTAILQ
checkpatch: warn about qemu/queue.h head structs that are not typedef-ed
scripts: add script to convert multiline comments into 4-line format
remove space-tab sequences
avoid TABs in files that only contain a few
Peng Hao (1):
hw/watchdog/wdt_i6300esb: remove a unnecessary comment
Stefan Hajnoczi (4):
block/iscsi: drop unused IscsiAIOCB->buf field
block/iscsi: take iscsilun->mutex in iscsi_timed_check_events()
block/iscsi: fix ioctl cancel use-after-free
block/iscsi: cancel libiscsi task when ABORT TASK TMF completes
Thomas Huth (1):
accel: Improve selection of the default accelerator
accel/accel.c| 18 +-
accel/kvm/kvm-all.c | 4 +-
accel/tcg/translate-all.c| 4 -
block/bochs.c| 22 +-
block/file-posix.c | 2 +-
block/file-win32.c | 8 +-
block/gluster.c | 2 +-
block/iscsi.c| 47 +++-
block/linux-aio.c| 4 +-
block/mirror.c | 2 +-
block/qcow2-bitmap.c | 4 +-
block/qcow2-cluster.c| 2 +-
block/qcow2.h| 5 +-
block/sheepdog.c | 6 +-
block/vhdx.h | 2 +-
block/vpc.c | 2 +-
blockdev.c | 4 +-
bsd-user/elfload.c | 2 +-
bsd-user/x86_64/target_syscall.h | 2 +-
configure| 3 -
contrib/elf2dmp/main.c | 2 +-
contrib/ivshmem-client/ivshmem-client.h | 4 +-
contrib/ivshmem-server/ivshmem-server.h | 5 +-
cpus-common.c| 2 +-
crypto/aes.c | 28 +-
disas/alpha.c| 8 +-
disas/arm.c | 2 +-
disas/i386.c | 4 +-
disas/m68k.c | 4 +-
dump.c | 2 +-
exec.c | 5 +-
fsdev/qemu-fsdev.c | 2 +-
hw/alpha/typhoon.c | 12 +-
hw/arm/stellaris.c | 2 +-
