Re: [Qemu-devel] [PULLv4 00/32] More work towards libslirp
On Thu, 7 Feb 2019 at 14:03, Samuel Thibault wrote: > > The following changes since commit 713acc316ddca119fe168e72846f1d2dd0548430: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190206' into > staging (2019-02-07 11:46:40 +) > > are available in the Git repository at: > > https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault > > for you to fetch changes up to ee261c02332ea856352f250b295a8ecd1eeb748e: > > slirp: API is extern C (2019-02-07 15:49:08 +0200) > > > More work towards libslirp > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0 for any user-visible changes. -- PMM
Re: [Qemu-devel] [PULLv4 00/32] More work towards libslirp
Patchew URL: https://patchew.org/QEMU/20190207140316.16103-1-samuel.thiba...@ens-lyon.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULLv4 00/32] More work towards libslirp Type: series Message-id: 20190207140316.16103-1-samuel.thiba...@ens-lyon.org === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 713acc316d..1dca054955 master -> master * [new tag] patchew/20190207140316.16103-1-samuel.thiba...@ens-lyon.org -> patchew/20190207140316.16103-1-samuel.thiba...@ens-lyon.org t [tag update]patchew/cover.1549545591.git.be...@igalia.com -> patchew/cover.1549545591.git.be...@igalia.com Switched to a new branch 'test' 33314ca993 slirp: API is extern C def44b9e1f slirp: pass opaque to all callbacks 619e3c22a9 slirp: use polling callbacks, drop glib requirement 25ed9a94b9 slirp: remove slirp_instances list 766080e20c slirp: replace global polling with per-instance & notifier 19f0fbff0b slirp: improve send_packet() callback 0767ffe68b slirp: prefer c99 types over BSD kind c862dcd06b slirp: replace remaining qemu headers dependency ba4a673af8 slirp: Move g_spawn_async_with_fds_qemu compatibility to slirp/ 114294c71e slirp: replace QEMU_BUILD_BUG_ON with G_STATIC_ASSERT 57ae54dfbb slirp: replace qemu qtailq with slirp own copy f854704da1 slirp: replace net/eth.h inclusion with own defines 3e22f44481 slirp: remove now useless QEMU headers inclusions 626c91b06d slirp: remove qemu timer.h dependency 31ff9b5865 slirp: add slirp own version of pstrcpy 5de0bf1688 slirp: improve windows headers inclusion 0a644d3622 slirp: do not include qemu headers in libslirp.h public API header 3b5081836c slirp: move QEMU state saving to a separate unit 0714ba3864 slirp: replace qemu_notify_event() with a callback 7cb0bee111 slirp: add unregister_poll_fd() callback bd2e721ae7 slirp: replace qemu_set_nonblock() a014aaa497 slirp: replace most qemu socket utilities with slirp own version 4762ebf715 slirp: replace QEMU_PACKED with SLIRP_PACKED 98685cf72f slirp: replace trace functions with DEBUG calls 40df17f75a slirp: add callbacks for timer f0223b5273 net/slirp: fix leaks on forwarding rule registration error f4f2eb80b0 net/slirp: free forwarding rules on cleanup 73cf8f5d37 net/slirp: simplify checking for cmd: prefix 227239db78 slirp: generalize guestfwd with a callback based approach 96e2f65d10 slirp: Don't mark struct ipq or struct ipasfrag as packed 0185e3b3b9 slirp: Avoid marking naturally packed structs as QEMU_PACKED 52f09e0c1c slirp: Avoid unaligned 16bit memory access === OUTPUT BEGIN === 1/32 Checking commit 52f09e0c1ccb (slirp: Avoid unaligned 16bit memory access) 2/32 Checking commit 0185e3b3b9ff (slirp: Avoid marking naturally packed structs as QEMU_PACKED) 3/32 Checking commit 96e2f65d109d (slirp: Don't mark struct ipq or struct ipasfrag as packed) 4/32 Checking commit 227239db78d4 (slirp: generalize guestfwd with a callback based approach) ERROR: code indent should never use tabs #148: FILE: slirp/misc.h:14: +^ISlirpWriteCb write_cb;$ ERROR: code indent should never use tabs #149: FILE: slirp/misc.h:15: +^Ivoid *opaque;$ total: 2 errors, 0 warnings, 226 lines checked Patch 4/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/32 Checking commit 73cf8f5d3774 (net/slirp: simplify checking for cmd: prefix) 6/32 Checking commit f4f2eb80b072 (net/slirp: free forwarding rules on cleanup) 7/32 Checking commit f0223b527316 (net/slirp: fix leaks on forwarding rule registration error) 8/32 Checking commit 40df17f75a79 (slirp: add callbacks for timer) 9/32 Checking commit 98685cf72fd0 (slirp: replace trace functions with DEBUG calls) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #100: deleted file mode 100644 total: 0 errors, 1 warnings, 62 lines checked Patch 9/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/32 Checking commit 4762ebf7159d (slirp: replace QEMU_PACKED with SLIRP_PACKED) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #111: new file mode 100644 total: 0 errors, 1 warnings, 111 lines checked Patch 10/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/32 Checking commit a014aaa49710 (slirp: replace most qemu socket utilities with slirp own version) ERROR: code indent should never use tabs #130: FILE: slirp/socket.c:190: +^Inn = slirp_recv(so->
[Qemu-devel] [PULLv4 00/32] More work towards libslirp
The following changes since commit 713acc316ddca119fe168e72846f1d2dd0548430: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190206' into staging (2019-02-07 11:46:40 +) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to ee261c02332ea856352f250b295a8ecd1eeb748e: slirp: API is extern C (2019-02-07 15:49:08 +0200) More work towards libslirp Marc-André Lureau (27): slirp: generalize guestfwd with a callback based approach net/slirp: simplify checking for cmd: prefix net/slirp: free forwarding rules on cleanup net/slirp: fix leaks on forwarding rule registration error slirp: add callbacks for timer slirp: replace trace functions with DEBUG calls slirp: replace QEMU_PACKED with SLIRP_PACKED slirp: replace most qemu socket utilities with slirp own version slirp: replace qemu_set_nonblock() slirp: add unregister_poll_fd() callback slirp: replace qemu_notify_event() with a callback slirp: move QEMU state saving to a separate unit slirp: do not include qemu headers in libslirp.h public API header slirp: improve windows headers inclusion slirp: add slirp own version of pstrcpy slirp: remove qemu timer.h dependency slirp: remove now useless QEMU headers inclusions slirp: replace net/eth.h inclusion with own defines slirp: replace qemu qtailq with slirp own copy slirp: replace remaining qemu headers dependency slirp: prefer c99 types over BSD kind slirp: improve send_packet() callback slirp: replace global polling with per-instance & notifier slirp: remove slirp_instances list slirp: use polling callbacks, drop glib requirement slirp: pass opaque to all callbacks slirp: API is extern C Peter Maydell (2): slirp: Avoid marking naturally packed structs as QEMU_PACKED slirp: Don't mark struct ipq or struct ipasfrag as packed Samuel Thibault (3): slirp: Avoid unaligned 16bit memory access slirp: replace QEMU_BUILD_BUG_ON with G_STATIC_ASSERT slirp: Move g_spawn_async_with_fds_qemu compatibility to slirp/ Marc-André Lureau (27): slirp: generalize guestfwd with a callback based approach net/slirp: simplify checking for cmd: prefix net/slirp: free forwarding rules on cleanup net/slirp: fix leaks on forwarding rule registration error slirp: add callbacks for timer slirp: replace trace functions with DEBUG calls slirp: replace QEMU_PACKED with SLIRP_PACKED slirp: replace most qemu socket utilities with slirp own version slirp: replace qemu_set_nonblock() slirp: add unregister_poll_fd() callback slirp: replace qemu_notify_event() with a callback slirp: move QEMU state saving to a separate unit slirp: do not include qemu headers in libslirp.h public API header slirp: improve windows headers inclusion slirp: add slirp own version of pstrcpy slirp: remove qemu timer.h dependency slirp: remove now useless QEMU headers inclusions slirp: replace net/eth.h inclusion with own defines slirp: replace qemu qtailq with slirp own copy slirp: replace remaining qemu headers dependency slirp: prefer c99 types over BSD kind slirp: improve send_packet() callback slirp: replace global polling with per-instance & notifier slirp: remove slirp_instances list slirp: use polling callbacks, drop glib requirement slirp: pass opaque to all callbacks slirp: API is extern C Peter Maydell (2): slirp: Avoid marking naturally packed structs as QEMU_PACKED slirp: Don't mark struct ipq or struct ipasfrag as packed Samuel Thibault (3): slirp: Avoid unaligned 16bit memory access slirp: replace QEMU_BUILD_BUG_ON with G_STATIC_ASSERT slirp: Move g_spawn_async_with_fds_qemu compatibility to slirp/ Makefile.objs| 1 - include/glib-compat.h| 57 --- include/net/net.h| 2 +- include/qemu/main-loop.h | 15 + net/net.c| 4 +- net/slirp.c | 185 - slirp/Makefile.objs | 4 +- slirp/arp_table.c| 3 +- slirp/bootp.c| 1 - slirp/cksum.c| 1 - slirp/debug.h| 13 +- slirp/dhcpv6.c | 4 +- slirp/dnssearch.c| 1 - slirp/if.c | 4 +- slirp/ip.h | 17 +- slirp/ip6.h | 14 +- slirp/ip6_icmp.c | 27 +- slirp/ip6_icmp.h | 26 +- slirp/ip6_input.c| 1 - slirp/ip6_output.c | 2 - slirp/ip_icmp.c | 14 +- slirp/ip_icmp.h | 18 +- slirp/ip_input.c | 5 +- slirp/ip_output.c| 1 - slirp/libslirp.h | 71 +++- slirp/main.h | 2 +- slirp/mbuf.c | 1 - slirp/mbuf.h | 2 +- slirp/mis
