Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-nbd: Document --tls-creds
On 10/03/2018 04:42 PM, Eric Blake wrote: > On 10/3/18 3:35 PM, John Snow wrote: >> >> >> On 10/03/2018 02:04 PM, Eric Blake wrote: >>> Commit 145614a1 introduced --tls-creds, but forgot to document >>> it in 'qemu-nbd --help'. >>> >>> Signed-off-by: Eric Blake >>> > >> Reviewed-by: John Snow >> >> Do we have a manpage/texi that needs to update, too? > > No; commit 145614a1 already covered that in qemu-nbd.texi. It's just > the --help output that needs it. I can tweak the commit message to > mention that, if it helps. > Not worth a re-spin. --js
Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-nbd: Document --tls-creds
On 10/3/18 3:35 PM, John Snow wrote: On 10/03/2018 02:04 PM, Eric Blake wrote: Commit 145614a1 introduced --tls-creds, but forgot to document it in 'qemu-nbd --help'. Signed-off-by: Eric Blake Reviewed-by: John Snow Do we have a manpage/texi that needs to update, too? No; commit 145614a1 already covered that in qemu-nbd.texi. It's just the --help output that needs it. I can tweak the commit message to mention that, if it helps. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-nbd: Document --tls-creds
On 10/03/2018 02:04 PM, Eric Blake wrote: > Commit 145614a1 introduced --tls-creds, but forgot to document > it in 'qemu-nbd --help'. > > Signed-off-by: Eric Blake > > --- > Sadly, 'git grep -i "qemu.nbd.*tls"' has no hits, making me wonder > if our iotests are even covering this. > > Noticed while writing my other patches for defaulting to newstyle. > --- > qemu-nbd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/qemu-nbd.c b/qemu-nbd.c > index 51b9d38c727..66e023f7fa4 100644 > --- a/qemu-nbd.c > +++ b/qemu-nbd.c > @@ -94,6 +94,7 @@ static void usage(const char *name) > "General purpose options:\n" > " --object type,id=ID,... define an object such as 'secret' for > providing\n" > "passwords and/or encryption keys\n" > +" --tls-creds=IDuse id of an earlier --object to provide TLS\n" > " -T, --trace [[enable=]][,events=][,file=]\n" > "specify tracing options\n" > " --forkfork off the server process and exit the > parent\n" > Reviewed-by: John Snow Do we have a manpage/texi that needs to update, too?
