Re: [Qemu-devel] [Qemu-block] [PATCH 5/5] tests: add test case for encrypted qcow2 read/write
On 05/12/2015 02:35 PM, Eric Blake wrote: On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: Add a simple test case for qemu-iotests that covers read/write with encrypted qcow2 files. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- tests/qemu-iotests/131 | 69 ++ tests/qemu-iotests/131.out | 46 +++ tests/qemu-iotests/group | 1 + 3 files changed, 116 insertions(+) create mode 100755 tests/qemu-iotests/131 create mode 100644 tests/qemu-iotests/131.out diff --git a/tests/qemu-iotests/131 b/tests/qemu-iotests/131 new file mode 100755 index 000..f44b0a0 --- /dev/null +++ b/tests/qemu-iotests/131 @@ -0,0 +1,69 @@ +#!/bin/bash +# +# Test encrypted read/write using plain bdrv_read/bdrv_write +# +# Copyright (C) 2009 Red Hat, Inc. Copy-and-paste strikes again; welcome to 2015. With that fixed, Reviewed-by: Eric Blake ebl...@redhat.com Fam Zheng already has a patch on-list that uses test 131, and I think his patch was submitted first. (Unless we want to play the Who gets merged first? game.) --js
Re: [Qemu-devel] [Qemu-block] [PATCH 5/5] tests: add test case for encrypted qcow2 read/write
On 05/12/2015 01:06 PM, John Snow wrote: tests/qemu-iotests/131 | 69 ++ tests/qemu-iotests/131.out | 46 +++ Fam Zheng already has a patch on-list that uses test 131, and I think his patch was submitted first. (Unless we want to play the Who gets merged first? game.) That's the sort of conflict that I expect a maintainer can clean up, if there is no other reason for a respin (although it is not always easy to coax git into understanding that a patch would be valid if the file is renamed. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [Qemu-block] [PATCH 5/5] tests: add test case for encrypted qcow2 read/write
On 05/12/2015 03:52 PM, Eric Blake wrote: On 05/12/2015 01:06 PM, John Snow wrote: tests/qemu-iotests/131 | 69 ++ tests/qemu-iotests/131.out | 46 +++ Fam Zheng already has a patch on-list that uses test 131, and I think his patch was submitted first. (Unless we want to play the Who gets merged first? game.) That's the sort of conflict that I expect a maintainer can clean up, if there is no other reason for a respin (although it is not always easy to coax git into understanding that a patch would be valid if the file is renamed. Sure, whoever fixes it. Just pointing it out. --js
