Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fixes i386 xchgq test
Le 10/12/2018 à 20:42, Richard Henderson a écrit : > On 12/10/18 1:26 PM, Philippe Mathieu-Daudé wrote: >> Hi Fabrice, >> >> On Fri, Dec 7, 2018 at 5:06 PM wrote: >>> >>> As "xchg" reads and writes both operands, the "+m" is required to avoid >>> undefined behavior on -O2 compilation. >>> >>> Signed-off-by: Fabrice Desclaux > > Reviewed-by: Richard Henderson > > Applied to my trivial-patches branch. Thanks, Laurent
Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fixes i386 xchgq test
On 12/10/18 1:26 PM, Philippe Mathieu-Daudé wrote: > Hi Fabrice, > > On Fri, Dec 7, 2018 at 5:06 PM wrote: >> >> As "xchg" reads and writes both operands, the "+m" is required to avoid >> undefined behavior on -O2 compilation. >> >> Signed-off-by: Fabrice Desclaux Reviewed-by: Richard Henderson >> --- >> tests/tcg/i386/test-i386.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/tcg/i386/test-i386.c b/tests/tcg/i386/test-i386.c >> index a29b41e764..18d5609665 100644 >> --- a/tests/tcg/i386/test-i386.c >> +++ b/tests/tcg/i386/test-i386.c >> @@ -1137,7 +1137,7 @@ void test_xchg(void) >> TEST_XCHG(xchgb, "b", "+q"); >> >> #if defined(__x86_64__) >> -TEST_XCHG(xchgq, "", "=m"); >> +TEST_XCHG(xchgq, "", "+m"); >> #endif >> TEST_XCHG(xchgl, "k", "+m"); >> TEST_XCHG(xchgw, "w", "+m"); >> -- >> 2.19.2 > > All QEMU patches has to go via the qemu-devel@nongnu.org list (you > only sent it to the trivial list). > I'm also Cc'ing the maintainers: Thanks, Phil. r~
Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fixes i386 xchgq test
Hi Fabrice, On Fri, Dec 7, 2018 at 5:06 PM wrote: > > As "xchg" reads and writes both operands, the "+m" is required to avoid > undefined behavior on -O2 compilation. > > Signed-off-by: Fabrice Desclaux > --- > tests/tcg/i386/test-i386.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/tcg/i386/test-i386.c b/tests/tcg/i386/test-i386.c > index a29b41e764..18d5609665 100644 > --- a/tests/tcg/i386/test-i386.c > +++ b/tests/tcg/i386/test-i386.c > @@ -1137,7 +1137,7 @@ void test_xchg(void) > TEST_XCHG(xchgb, "b", "+q"); > > #if defined(__x86_64__) > -TEST_XCHG(xchgq, "", "=m"); > +TEST_XCHG(xchgq, "", "+m"); > #endif > TEST_XCHG(xchgl, "k", "+m"); > TEST_XCHG(xchgw, "w", "+m"); > -- > 2.19.2 All QEMU patches has to go via the qemu-devel@nongnu.org list (you only sent it to the trivial list). I'm also Cc'ing the maintainers: $ ./scripts/get_maintainer.pl -f tests/tcg/i386/test-i386.c Paolo Bonzini (maintainer:X86) Richard Henderson (maintainer:X86) Eduardo Habkost (maintainer:X86) qemu-devel@nongnu.org (open list:All patches CC here) Regards, Phil.
