On 11/16/10 17:01, Michael Roth wrote: > Provide monitor command to initiate guest shutdown/reboot/powerdown
> +int do_agent_shutdown(Monitor *mon, const QDict *mon_params, > + MonitorCompletion cb, void *opaque) > +{ > + xmlrpc_env env; > + xmlrpc_value *params; > + VARPCData *rpc_data; > + const char *shutdown_type; > + int ret; > + > + TRACE("called"); > + > + xmlrpc_env_init(&env); > + shutdown_type = qdict_get_str(mon_params, "shutdown_type"); > + params = xmlrpc_build_value(&env, "(s)", shutdown_type); > + if (rpc_has_error(&env)) { > + return -1; > + } > + > + rpc_data = qemu_mallocz(sizeof(VARPCData)); > + rpc_data->cb = do_agent_shutdown_cb; > + rpc_data->mon_cb = cb; > + rpc_data->mon_data = opaque; > + > + ret = rpc_execute(&env, "va_shutdown", params, rpc_data); > + if (ret == -EREMOTE) { > + monitor_printf(mon, "RPC Failed (%i): %s\n", env.fault_code, > + env.fault_string); > + return -1; > + } else if (ret == -1) { > + monitor_printf(mon, "RPC communication error\n"); > + return -1; > + } I would think you could put a lot of this into a utility function instead of having it open coded for each command you want to support? Cheers, Jes > + > + return 0; > +} > diff --git a/virtagent.h b/virtagent.h > index c077582..96c6260 100644 > --- a/virtagent.h > +++ b/virtagent.h > @@ -29,5 +29,7 @@ int do_agent_viewfile(Monitor *mon, const QDict *mon_params, > void do_agent_viewdmesg_print(Monitor *mon, const QObject *qobject); > int do_agent_viewdmesg(Monitor *mon, const QDict *mon_params, > MonitorCompletion cb, void *opaque); > +int do_agent_shutdown(Monitor *mon, const QDict *mon_params, > + MonitorCompletion cb, void *opaque); > > #endif /* VIRTAGENT_H */