Re: [Qemu-devel] [RFC 0/8] virtio-crypto: add multiplexing mode support
On 09/11/2017 03:10 AM, Longpeng(Mike) wrote: > *NOTE* > The code realization is based on the latest virtio crypto spec: > [PATCH v19 0/2] virtio-crypto: virtio crypto device specification >https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg05217.html > > In session mode, the process of create/close a session > makes we have a least one full round-trip cost from guest to host to guest > to be able to send any data for symmetric algorithms. It gets ourself into > synchronization troubles in some scenarios like a web server handling lots > of small requests whose algorithms and keys are different. > > We can support one-blob request (no sessions) as well for symmetric > algorithms, including HASH, MAC services. The benefit is obvious for > HASH service because it's usually a one-blob operation. > Hi! I've just started looking at this. Patch #1 modifies linux/virtio_crypto.h which if I compare with the (almost) latest linux master is different. Thus I would expect a corresponding kernel patch set too, but I haven't received one, nor did I find a reference in the cover letter. I think if I want to test the new features I need the kernel counter-part too, or? Could you point me to the kernel counterpart? Regards, Halil > Gonglei (3): > virtio-crypto: add stateless crypto request handler > cryptodev: extract one util function > virtio-crypto: add host feature bits support > > Longpeng(Mike) (5): > virtio-crypto: add new definations for multiplexing mode > virtio-crypto: add session creation logic for mux mode > virtio-crypto: add dataq operation logic for mux mode > cryptodev: add stateless mode cipher support > cryptodev-builtin: add stateless cipher support > > backends/cryptodev-builtin.c | 189 --- > backends/cryptodev.c | 21 ++ > hw/virtio/virtio-crypto.c | 433 > +++-- > include/hw/virtio/virtio-crypto.h | 2 + > include/standard-headers/linux/virtio_crypto.h | 182 ++- > include/sysemu/cryptodev.h | 21 ++ > 6 files changed, 774 insertions(+), 74 deletions(-) >
Re: [Qemu-devel] [RFC 0/8] virtio-crypto: add multiplexing mode support
Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [RFC 0/8] virtio-crypto: add multiplexing mode support Message-id: 1505092240-10864-1-git-send-email-longpe...@huawei.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base" # branch set -e echo "=== ENV ===" env echo "=== PACKAGES ===" rpm -qa echo "=== TEST BEGIN ===" CC=$HOME/bin/cc INSTALL=$PWD/install BUILD=$PWD/build echo -n "Using CC: " realpath $CC mkdir -p $BUILD $INSTALL SRC=$PWD cd $BUILD $SRC/configure --cc=$CC --prefix=$INSTALL make -j4 # XXX: we need reliable clean up # make check -j4 V=1 make install === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1505092240-10864-1-git-send-email-longpe...@huawei.com -> patchew/1505092240-10864-1-git-send-email-longpe...@huawei.com Switched to a new branch 'test' 065187e virtio-crypto: add host feature bits support 4d57d09 cryptodev-builtin: add stateless cipher support f20737b cryptodev: extract one util function 9476810 virtio-crypto: add stateless crypto request handler 4062153 cryptodev: add stateless mode cipher support e34d808 virtio-crypto: add dataq operation logic for mux mode b4dd8b6 virtio-crypto: add session creation logic for mux mode b375b6a virtio-crypto: add new definations for multiplexing mode === OUTPUT BEGIN === === ENV === XDG_SESSION_ID=67185 SHELL=/bin/sh USER=fam PATCHEW=/home/fam/patchew/patchew-cli -s http://patchew.org --nodebug PATH=/usr/bin:/bin PWD=/var/tmp/patchew-tester-tmp-i0s02bpo/src LANG=en_US.UTF-8 HOME=/home/fam SHLVL=2 LOGNAME=fam DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1012/bus XDG_RUNTIME_DIR=/run/user/1012 _=/usr/bin/env === PACKAGES === gpg-pubkey-873529b8-54e386ff xz-libs-5.2.2-2.fc24.s390x libxshmfence-1.2-3.fc24.s390x giflib-4.1.6-15.fc24.s390x trousers-lib-0.3.13-6.fc24.s390x ncurses-base-6.0-6.20160709.fc25.noarch gmp-6.1.1-1.fc25.s390x libidn-1.33-1.fc25.s390x slang-2.3.0-7.fc25.s390x pkgconfig-0.29.1-1.fc25.s390x alsa-lib-1.1.1-2.fc25.s390x yum-metadata-parser-1.1.4-17.fc25.s390x python3-slip-dbus-0.6.4-4.fc25.noarch python2-cssselect-0.9.2-1.fc25.noarch createrepo_c-libs-0.10.0-6.fc25.s390x initscripts-9.69-1.fc25.s390x parted-3.2-21.fc25.s390x flex-2.6.0-3.fc25.s390x colord-libs-1.3.4-1.fc25.s390x python-osbs-client-0.33-3.fc25.noarch perl-Pod-Simple-3.35-1.fc25.noarch python2-simplejson-3.10.0-1.fc25.s390x brltty-5.4-2.fc25.s390x librados2-10.2.4-2.fc25.s390x tcp_wrappers-7.6-83.fc25.s390x libcephfs_jni1-10.2.4-2.fc25.s390x nettle-devel-3.3-1.fc25.s390x bzip2-devel-1.0.6-21.fc25.s390x libuuid-2.28.2-2.fc25.s390x python3-dnf-1.1.10-6.fc25.noarch texlive-kpathsea-doc-svn41139-33.fc25.1.noarch openssh-7.4p1-4.fc25.s390x texlive-kpathsea-bin-svn40473-33.20160520.fc25.1.s390x texlive-graphics-svn41015-33.fc25.1.noarch texlive-dvipdfmx-def-svn40328-33.fc25.1.noarch texlive-mfware-svn40768-33.fc25.1.noarch texlive-texlive-scripts-svn41433-33.fc25.1.noarch texlive-euro-svn22191.1.1-33.fc25.1.noarch texlive-etex-svn37057.0-33.fc25.1.noarch texlive-iftex-svn29654.0.2-33.fc25.1.noarch texlive-palatino-svn31835.0-33.fc25.1.noarch texlive-texlive-docindex-svn41430-33.fc25.1.noarch texlive-xunicode-svn30466.0.981-33.fc25.1.noarch texlive-koma-script-svn41508-33.fc25.1.noarch texlive-pst-grad-svn15878.1.06-33.fc25.1.noarch texlive-pst-blur-svn15878.2.0-33.fc25.1.noarch texlive-jknapltx-svn19440.0-33.fc25.1.noarch texinfo-6.1-4.fc25.s390x openssl-devel-1.0.2k-1.fc25.s390x gdk-pixbuf2-2.36.6-1.fc25.s390x nspr-4.14.0-2.fc25.s390x nss-softokn-freebl-3.30.2-1.0.fc25.s390x jansson-2.10-2.fc25.s390x fedora-repos-25-4.noarch python3-libs-3.5.3-6.fc25.s390x perl-Errno-1.25-387.fc25.s390x acl-2.2.52-13.fc25.s390x pcre2-utf16-10.23-8.fc25.s390x pango-1.40.5-1.fc25.s390x systemd-pam-231-17.fc25.s390x python2-gluster-3.10.4-1.fc25.s390x NetworkManager-libnm-1.4.4-5.fc25.s390x selinux-policy-3.13.1-225.18.fc25.noarch poppler-0.45.0-5.fc25.s390x ccache-3.3.4-1.fc25.s390x valgrind-3.12.0-9.fc25.s390x perl-open-1.10-387.fc25.noarch libaio-0.3.110-6.fc24.s390x libfontenc-1.1.3-3.fc24.s390x lzo-2.08-8.fc24.s390x isl-0.14-5.fc24.s390x libXau-1.0.8-6.fc24.s390x linux-atm-libs-2.5.1-14.fc24.s390x libXext-1.3.3-4.fc24.s390x libXxf86vm-1.1.4-3.fc24.s390x bison-3.0.4-4.fc24.s390x perl-srpm-macros-1-20.fc25.noarch gawk-4.1.3-8.fc25.s390x libwayland-client-1.12.0-1.fc25.s390x perl-Exporter-5.72-366.fc25.noarch perl-version-0.99.17-1.fc25.s390x fftw-libs-double-3.3.5-3.fc25.s390x libssh2-1.8.0-1.fc25.s390x ModemManager-glib-1.6.4-1.fc25.s390x newt-python3-0.52.19-2.fc25.s390x python-munch-2.0.4-3.fc25.noarch python-bugzilla-1.2.2-4.fc25.noarch libedit-3.1-16.20160618cvs.fc25.s390x createrepo_c-0.10.0-6.fc25.s390x device-mapper-multipath-l
[Qemu-devel] [RFC 0/8] virtio-crypto: add multiplexing mode support
*NOTE* The code realization is based on the latest virtio crypto spec: [PATCH v19 0/2] virtio-crypto: virtio crypto device specification https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg05217.html In session mode, the process of create/close a session makes we have a least one full round-trip cost from guest to host to guest to be able to send any data for symmetric algorithms. It gets ourself into synchronization troubles in some scenarios like a web server handling lots of small requests whose algorithms and keys are different. We can support one-blob request (no sessions) as well for symmetric algorithms, including HASH, MAC services. The benefit is obvious for HASH service because it's usually a one-blob operation. Gonglei (3): virtio-crypto: add stateless crypto request handler cryptodev: extract one util function virtio-crypto: add host feature bits support Longpeng(Mike) (5): virtio-crypto: add new definations for multiplexing mode virtio-crypto: add session creation logic for mux mode virtio-crypto: add dataq operation logic for mux mode cryptodev: add stateless mode cipher support cryptodev-builtin: add stateless cipher support backends/cryptodev-builtin.c | 189 --- backends/cryptodev.c | 21 ++ hw/virtio/virtio-crypto.c | 433 +++-- include/hw/virtio/virtio-crypto.h | 2 + include/standard-headers/linux/virtio_crypto.h | 182 ++- include/sysemu/cryptodev.h | 21 ++ 6 files changed, 774 insertions(+), 74 deletions(-) -- 1.8.3.1
