Re: [Qemu-devel] [RFC 00/14] VGA cleanups and endian control
On Di, 2014-06-24 at 09:10 +1000, Benjamin Herrenschmidt wrote: This series cleans up VGA and a bit of cirrus to remove all the now unused conversions to non-32bpp surfaces. Then the last two patches add a proposed variant of the endian control register and the (still somewhat controversial) trick to auto-switch VGA endian on powerpc SPAPR platforms. They apply on top of Gerd pixel format series Looks good overall. I'll go test this when I find time, after flushing my email backlog ... cheers, Gerd
Re: [Qemu-devel] [RFC 00/14] VGA cleanups and endian control
On Mon, 2014-06-30 at 13:50 +0200, Gerd Hoffmann wrote: On Di, 2014-06-24 at 09:10 +1000, Benjamin Herrenschmidt wrote: This series cleans up VGA and a bit of cirrus to remove all the now unused conversions to non-32bpp surfaces. Then the last two patches add a proposed variant of the endian control register and the (still somewhat controversial) trick to auto-switch VGA endian on powerpc SPAPR platforms. They apply on top of Gerd pixel format series Looks good overall. I'll go test this when I find time, after flushing my email backlog ... Thanks. The main issues I know of at this point are the HW cursor vs. cirrus and the lack of response from the Bochs guys... I'll respin based on your other comments some time this or next week, let me know if there's any other low hanging fruit in that area that I can take care of while I'm at it. Cheers, Ben.
Re: [Qemu-devel] [RFC 00/14] VGA cleanups and endian control
On Mo, 2014-06-30 at 22:36 +1000, Benjamin Herrenschmidt wrote: On Mon, 2014-06-30 at 13:50 +0200, Gerd Hoffmann wrote: On Di, 2014-06-24 at 09:10 +1000, Benjamin Herrenschmidt wrote: This series cleans up VGA and a bit of cirrus to remove all the now unused conversions to non-32bpp surfaces. Then the last two patches add a proposed variant of the endian control register and the (still somewhat controversial) trick to auto-switch VGA endian on powerpc SPAPR platforms. They apply on top of Gerd pixel format series Looks good overall. I'll go test this when I find time, after flushing my email backlog ... Thanks. The main issues I know of at this point are the HW cursor vs. cirrus and the lack of response from the Bochs guys... I'll respin based on your other comments some time this or next week, let me know if there's any other low hanging fruit in that area that I can take care of while I'm at it. One thing I've planed to do is rewrite text mode rendering. There are some helpers for that in ui/qemu-pixman.c. They are used by the qemu text console today (i.e. -chardev vc + Ctrl-Alt-$nr console switching, see ui/console.c). In theory these helpers should work as-is for vga text mode rendering too, allowing to zap a whole bunch of glyph drawing code from vga.c. Not sure how low hanging that actually is though ... cheers, Gerd
Re: [Qemu-devel] [RFC 00/14] VGA cleanups and endian control
On Mon, 2014-06-30 at 15:03 +0200, Gerd Hoffmann wrote: I'll respin based on your other comments some time this or next week, let me know if there's any other low hanging fruit in that area that I can take care of while I'm at it. One thing I've planed to do is rewrite text mode rendering. There are some helpers for that in ui/qemu-pixman.c. They are used by the qemu text console today (i.e. -chardev vc + Ctrl-Alt-$nr console switching, see ui/console.c). In theory these helpers should work as-is for vga text mode rendering too, allowing to zap a whole bunch of glyph drawing code from vga.c. Not sure how low hanging that actually is though ... That might be a bit more than I'm willing to swallow right now :-) I'm actually quite busy otherwise... anyway, I'll have a quick look just in case but don't get your hopes too high up on that one. Let me know if you find a test case for the cirrus HW cursor, I'll have a look at older X DDX on my side, or some other OS that might make use of it (I tried Haiku but that didn't seem to have a problem so I suspect they just do standard VESA). Cheers, Ben.
[Qemu-devel] [RFC 00/14] VGA cleanups and endian control
This series cleans up VGA and a bit of cirrus to remove all the now unused conversions to non-32bpp surfaces. Then the last two patches add a proposed variant of the endian control register and the (still somewhat controversial) trick to auto-switch VGA endian on powerpc SPAPR platforms. They apply on top of Gerd pixel format series
