Re: [Qemu-devel] [RFC PATCH 00/17] Declare device little or big endian
Patchew URL: https://patchew.org/QEMU/cover.1566467963.git.tony.ngu...@bt.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [RFC PATCH 00/17] Declare device little or big endian Message-id: cover.1566467963.git.tony.ngu...@bt.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/cover.1566466906.git.tony.ngu...@bt.com -> patchew/cover.1566466906.git.tony.ngu...@bt.com * [new tag] patchew/cover.1566467963.git.tony.ngu...@bt.com -> patchew/cover.1566467963.git.tony.ngu...@bt.com Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone' Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc' Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF' Submodule 'roms/edk2' (https://git.qemu.org/git/edk2.git) registered for path 'roms/edk2' Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe' Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios' Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware' Submodule 'roms/opensbi' (https://git.qemu.org/git/opensbi.git) registered for path 'roms/opensbi' Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode' Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios' Submodule 'roms/seabios-hppa' (https://git.qemu.org/git/seabios-hppa.git) registered for path 'roms/seabios-hppa' Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios' Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot' Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot' Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex' Submodule 'slirp' (https://git.qemu.org/git/libslirp.git) registered for path 'slirp' Submodule 'tests/fp/berkeley-softfloat-3' (https://git.qemu.org/git/berkeley-softfloat-3.git) registered for path 'tests/fp/berkeley-softfloat-3' Submodule 'tests/fp/berkeley-testfloat-3' (https://git.qemu.org/git/berkeley-testfloat-3.git) registered for path 'tests/fp/berkeley-testfloat-3' Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into 'capstone'... Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf' Cloning into 'dtc'... Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536' Cloning into 'roms/QemuMacDrivers'... Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266' Cloning into 'roms/SLOF'... Submodule path 'roms/SLOF': checked out '7bfe584e321946771692711ff83ad2b5850daca7' Cloning into 'roms/edk2'... Submodule path 'roms/edk2': checked out '20d2e5a125e34fc8501026613a71549b2a1a3e54' Submodule 'SoftFloat' (https://github.com/ucb-bar/berkeley-softfloat-3.git) registered for path 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3' Submodule 'CryptoPkg/Library/OpensslLib/openssl' (https://github.com/openssl/openssl) registered for path 'CryptoPkg/Library/OpensslLib/openssl' Cloning into 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'... Submodule path 'roms/edk2/ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'CryptoPkg/Library/OpensslLib/openssl'... Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl': checked out '50eaac9f3337667259de725451f201e784599687' Submodule 'boringssl' (https:
[Qemu-devel] [RFC PATCH 00/17] Declare device little or big endian
This series is an attempt to re-declare devices with DEVICE_NATIVE_ENDIAN as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN. This clean up was split out from an earlier series which collapsed byte swaps along the I/O path. On Wed, 7 Aug 2019 at 12:42, Paolo Bonzini wrote: > On 07/08/19 10:31, tony.nguyen@bt wrote: >> >> Device realizing code with MemorRegionOps endianness as >> DEVICE_NATIVE_ENDIAN is not common code. >> >> Corrected devices were identified by making the declaration of >> DEVICE_NATIVE_ENDIAN conditional upon NEED_CPU_H and then listing >> what failed to compile. > > The general approach makes sense. However, most of these should not be > DEVICE_NATIVE_ENDIAN. I can help with some of them. An RFC as most devices I have never heard of... a collective effort is needed =) On Fri, 16 Aug 2019 at 13:02, Peter Maydell wrote: > OTOH it's worth noting that it's quite likely that most of > the implementations of these DEVICE_NATIVE_ENDIAN devices > picked it in an equally naive way, by just copying some other > device's code... I am starting off with the following *naive* approach. For each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o. If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively. This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets. Please help spot devices which are genuinely native endian. Thanks! Tony Nguyen (17): hw/audio: Declare device little or big endian hw/block: Declare device little or big endian hw/char: Declare device little or big endian hw/display: Declare device little or big endian hw/dma: Declare device little or big endian hw/gpio: Declare device little or big endian hw/i2c: Declare device little or big endian hw/input: Declare device little or big endian hw/intc: Declare device little or big endian hw/isa: Declare device little or big endian hw/misc: Declare device little or big endian hw/net: Declare device little or big endian hw/pci-host: Declare device little or big endian hw/sd: Declare device little or big endian hw/ssi: Declare device little or big endian hw/timer: Declare device little or big endian build: Correct non-common common-obj-* to obj-* hw/audio/Makefile.objs | 3 ++- hw/audio/cs4231.c | 2 +- hw/audio/marvell_88w8618.c | 2 +- hw/audio/milkymist-ac97.c | 2 +- hw/audio/pl041.c| 2 +- hw/block/Makefile.objs | 6 +++--- hw/block/onenand.c | 2 +- hw/char/Makefile.objs | 4 ++-- hw/char/cadence_uart.c | 2 +- hw/char/escc.c | 2 +- hw/char/etraxfs_ser.c | 2 +- hw/char/grlib_apbuart.c | 2 +- hw/char/imx_serial.c| 2 +- hw/char/lm32_uart.c | 2 +- hw/char/milkymist-uart.c| 2 +- hw/char/pl011.c | 2 +- hw/core/Makefile.objs | 2 +- hw/display/Makefile.objs| 6 +++--- hw/display/pl110.c | 2 +- hw/display/tc6393xb.c | 2 +- hw/dma/Makefile.objs| 6 +++--- hw/dma/bcm2835_dma.c| 4 ++-- hw/dma/etraxfs_dma.c| 2 +- hw/dma/pl080.c | 2 +- hw/dma/pl330.c | 2 +- hw/dma/puv3_dma.c | 2 +- hw/dma/sparc32_dma.c| 2 +- hw/gpio/Makefile.objs | 2 +- hw/gpio/pl061.c | 2 +- hw/gpio/zaurus.c| 2 +- hw/i2c/Makefile.objs| 2 +- hw/i2c/imx_i2c.c| 2 +- hw/i2c/mpc_i2c.c| 2 +- hw/i2c/versatile_i2c.c | 2 +- hw/input/Makefile.objs | 2 +- hw/input/pl050.c| 2 +- hw/intc/Makefile.objs | 6 +++--- hw/intc/arm_gic.c | 12 ++-- hw/intc/arm_gicv3.c | 4 ++-- hw/intc/etraxfs_pic.c | 2 +- hw/intc/imx_avic.c | 2 +- hw/intc/imx_gpcv2.c | 2 +- hw/intc/pl190.c | 2 +- hw/intc/puv3_intc.c | 2 +- hw/ipack/Makefile.objs | 2 +- hw/isa/vt82c686.c | 2 +- hw/misc/Makefile.objs | 10 +- hw/misc/a9scu.c | 2 +- hw/misc/applesmc.c | 6 +++--- hw/misc/arm11scu.c | 2 +- hw/misc/arm_l2x0.c | 2 +- hw/misc/puv3_pm.c | 2 +- hw/net/Makefile.objs| 2 +- hw/net/allwinner_emac.c | 2 +- hw/net/imx_fec.c| 2 +- hw/net/lan9118.c| 4 ++-- hw/net/lance.c | 2 +- hw/net/smc91c111.c | 2 +- hw/net/stellaris_enet.c | 2 +- hw/pci-host/Makefile.objs | 2 +- hw/pci-host/q35.c | 2 +- hw/pci-host/versatile.c | 4 ++-- hw/scsi/Makefile.objs | 2 +- hw/sd/pl181.c | 2 +- hw/ssi/Makefile.objs| 2 +- hw/ssi/mss-spi.c| 2 +- hw/ssi/pl022.c | 2 +- hw/ssi/stm32f2xx_spi
