Re: [Qemu-devel] [RFC PATCH 1/9] Init colo-proxy object based on netfilter

[Wen Congyang]

On 11/27/2015 08:27 PM, Zhang Chen wrote:
> From: zhangchen 
> 
> add colo-proxy in vl.c and qemu-options.hx
> 
> Signed-off-by: zhangchen 
> ---
>  qemu-options.hx | 4 
>  vl.c| 3 ++-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 949db7f..5e6f1e3 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -3666,6 +3666,10 @@ queue @var{all|rx|tx} is an option that can be applied 
> to any netfilter.
>  @option{tx}: the filter is attached to the transmit queue of the netdev,
>   where it will receive packets sent by the netdev.
>  
> +@item -object 
> colo-proxy,id=@var{id},netdev=@var{netdevid},port=@var{t},addr=@var{ip:port},mode=@var{primary|secondary}[,queue=@var{all|rx|tx}]

1. queue *MUST* be all for the filter colo-proxy.
2. The option port should be removed
3. The option addr is socket address. The format can be host:port, or fd.

> +
> +colo-proxy

Add more description here.

Thanks
Wen Congyang

> +
>  @item -object 
> filter-dump,id=@var{id},netdev=@var{dev},file=@var{filename}][,maxlen=@var{len}]
>  
>  Dump the network traffic on netdev @var{dev} to the file specified by
> diff --git a/vl.c b/vl.c
> index f5f7c3f..9037743 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2774,7 +2774,8 @@ static bool object_create_initial(const char *type)
>   * they depend on netdevs already existing
>   */
>  if (g_str_equal(type, "filter-buffer") ||
> -g_str_equal(type, "filter-dump")) {
> +g_str_equal(type, "filter-dump") ||
> +g_str_equal(type, "colo-proxy")) {
>  return false;
>  }
>  
> 

Re: [Qemu-devel] [RFC PATCH 1/9] Init colo-proxy object based on netfilter

[Zhang Chen]

On 11/30/2015 10:50 AM, Wen Congyang wrote:

On 11/27/2015 08:27 PM, Zhang Chen wrote:

From: zhangchen 

add colo-proxy in vl.c and qemu-options.hx

Signed-off-by: zhangchen 
---
  qemu-options.hx | 4 
  vl.c| 3 ++-
  2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 949db7f..5e6f1e3 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -3666,6 +3666,10 @@ queue @var{all|rx|tx} is an option that can be applied 
to any netfilter.
  @option{tx}: the filter is attached to the transmit queue of the netdev,
   where it will receive packets sent by the netdev.
  
+@item -object colo-proxy,id=@var{id},netdev=@var{netdevid},port=@var{t},addr=@var{ip:port},mode=@var{primary|secondary}[,queue=@var{all|rx|tx}]

1. queue *MUST* be all for the filter colo-proxy.
2. The option port should be removed
3. The option addr is socket address. The format can be host:port, or fd.


will fix in next version

thanks for review
zhangchen


+
+colo-proxy

Add more description here.

Thanks
Wen Congyang



will fix in next version


+
  @item -object 
filter-dump,id=@var{id},netdev=@var{dev},file=@var{filename}][,maxlen=@var{len}]
  
  Dump the network traffic on netdev @var{dev} to the file specified by

diff --git a/vl.c b/vl.c
index f5f7c3f..9037743 100644
--- a/vl.c
+++ b/vl.c
@@ -2774,7 +2774,8 @@ static bool object_create_initial(const char *type)
   * they depend on netdevs already existing
   */
  if (g_str_equal(type, "filter-buffer") ||
-g_str_equal(type, "filter-dump")) {
+g_str_equal(type, "filter-dump") ||
+g_str_equal(type, "colo-proxy")) {
  return false;
  }
  


.

[Qemu-devel] [RFC PATCH 1/9] Init colo-proxy object based on netfilter

[Zhang Chen]

From: zhangchen 

add colo-proxy in vl.c and qemu-options.hx

Signed-off-by: zhangchen 
---
 qemu-options.hx | 4 
 vl.c| 3 ++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 949db7f..5e6f1e3 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -3666,6 +3666,10 @@ queue @var{all|rx|tx} is an option that can be applied 
to any netfilter.
 @option{tx}: the filter is attached to the transmit queue of the netdev,
  where it will receive packets sent by the netdev.
 
+@item -object 
colo-proxy,id=@var{id},netdev=@var{netdevid},port=@var{t},addr=@var{ip:port},mode=@var{primary|secondary}[,queue=@var{all|rx|tx}]
+
+colo-proxy
+
 @item -object 
filter-dump,id=@var{id},netdev=@var{dev},file=@var{filename}][,maxlen=@var{len}]
 
 Dump the network traffic on netdev @var{dev} to the file specified by
diff --git a/vl.c b/vl.c
index f5f7c3f..9037743 100644
--- a/vl.c
+++ b/vl.c
@@ -2774,7 +2774,8 @@ static bool object_create_initial(const char *type)
  * they depend on netdevs already existing
  */
 if (g_str_equal(type, "filter-buffer") ||
-g_str_equal(type, "filter-dump")) {
+g_str_equal(type, "filter-dump") ||
+g_str_equal(type, "colo-proxy")) {
 return false;
 }
 
-- 
1.9.1