Re: [Qemu-devel] [RFC PATCH 17/25] i2c: express dependencies with Kconfig

[Paolo Bonzini]

On 08/01/19 10:15, Yang Zhong wrote:
>>  config SM501
>>  bool
>> +depends on I2C
>>  
>>  config TCX
>>  bool
> I think XLNX_ZYNQMP_ARM likely needs "depends on I2C" nowadays, too ?

CONFIG_DDC should depend on I2C, while CONFIG_AUX should select I2C.

In a second phase, XLNX_ZYNQMP will select DDC.

Paolo

Re: [Qemu-devel] [RFC PATCH 17/25] i2c: express dependencies with Kconfig

[Yang Zhong]

On Fri, Jan 04, 2019 at 04:30:01PM +0100, Thomas Huth wrote:
> On 2018-12-27 07:34, Yang Zhong wrote:
> > From: Paolo Bonzini 
> > 
> > Signed-off-by: Paolo Bonzini 
> > Signed-off-by: Yang Zhong 
> > ---
> [...]
> > diff --git a/hw/display/Kconfig b/hw/display/Kconfig
> > index 8ce968bfff..8ddce09ead 100644
> > --- a/hw/display/Kconfig
> > +++ b/hw/display/Kconfig
> > @@ -24,9 +24,11 @@ config PL110
> >  
> >  config SII9022
> >  bool
> > +depends on I2C
> >  
> >  config SSD0303
> >  bool
> > +depends on I2C
> >  
> >  config SSD0323
> >  bool
> > @@ -70,6 +72,7 @@ config MILKYMIST_TMU2
> >  
> >  config SM501
> >  bool
> > +depends on I2C
> >  
> >  config TCX
> >  bool
> 
> I think XLNX_ZYNQMP_ARM likely needs "depends on I2C" nowadays, too ?
> 
>  Thomas

  Thomas, thanks for comments!
  Since this is pure ARM's config, we will move this "config XLNX_ZYNQMP_ARM" 
into ./hw/arm/Kconfig.
  otehr platforms will be in next steps. thanks! 

  ./hw/arm/Makefile.objs:obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx-zynqmp.o 
xlnx-zcu102.o
  ./hw/display/Makefile.objs:obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx_dp.o
  ./hw/dma/Makefile.objs:obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx_dpdma.o
  ./hw/dma/Makefile.objs:common-obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx-zdma.o
  ./default-configs/aarch64-softmmu.mak:CONFIG_XLNX_ZYNQMP_ARM=y

  Regards,

  Yang

Re: [Qemu-devel] [RFC PATCH 17/25] i2c: express dependencies with Kconfig

[Thomas Huth]

On 2018-12-27 07:34, Yang Zhong wrote:
> From: Paolo Bonzini 
> 
> Signed-off-by: Paolo Bonzini 
> Signed-off-by: Yang Zhong 
> ---
[...]
> diff --git a/hw/display/Kconfig b/hw/display/Kconfig
> index 8ce968bfff..8ddce09ead 100644
> --- a/hw/display/Kconfig
> +++ b/hw/display/Kconfig
> @@ -24,9 +24,11 @@ config PL110
>  
>  config SII9022
>  bool
> +depends on I2C
>  
>  config SSD0303
>  bool
> +depends on I2C
>  
>  config SSD0323
>  bool
> @@ -70,6 +72,7 @@ config MILKYMIST_TMU2
>  
>  config SM501
>  bool
> +depends on I2C
>  
>  config TCX
>  bool

I think XLNX_ZYNQMP_ARM likely needs "depends on I2C" nowadays, too ?

 Thomas

[Qemu-devel] [RFC PATCH 17/25] i2c: express dependencies with Kconfig

[Yang Zhong]

From: Paolo Bonzini 

Signed-off-by: Paolo Bonzini 
Signed-off-by: Yang Zhong 
---
 hw/Makefile.objs | 2 +-
 hw/audio/Kconfig | 1 +
 hw/display/Kconfig   | 3 +++
 hw/gpio/Kconfig  | 1 +
 hw/i2c/Kconfig   | 6 ++
 hw/i2c/Makefile.objs | 3 ++-
 hw/i386/Kconfig  | 1 +
 hw/input/Kconfig | 1 +
 hw/isa/Kconfig   | 1 +
 hw/misc/Kconfig  | 4 
 hw/timer/Kconfig | 3 +++
 11 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/hw/Makefile.objs b/hw/Makefile.objs
index b95b0c74a1..920086b182 100644
--- a/hw/Makefile.objs
+++ b/hw/Makefile.objs
@@ -10,7 +10,7 @@ devices-dirs-$(CONFIG_SOFTMMU) += display/
 devices-dirs-$(CONFIG_SOFTMMU) += dma/
 devices-dirs-$(CONFIG_SOFTMMU) += gpio/
 devices-dirs-$(CONFIG_HYPERV) += hyperv/
-devices-dirs-$(CONFIG_SOFTMMU) += i2c/
+devices-dirs-$(CONFIG_I2C) += i2c/
 devices-dirs-$(CONFIG_SOFTMMU) += ide/
 devices-dirs-$(CONFIG_SOFTMMU) += input/
 devices-dirs-$(CONFIG_SOFTMMU) += intc/
diff --git a/hw/audio/Kconfig b/hw/audio/Kconfig
index 350f2d4359..5cb7118e44 100644
--- a/hw/audio/Kconfig
+++ b/hw/audio/Kconfig
@@ -40,6 +40,7 @@ config PCSPK
 
 config WM8750
 bool
+depends on I2C
 
 config PL041
 bool
diff --git a/hw/display/Kconfig b/hw/display/Kconfig
index 8ce968bfff..8ddce09ead 100644
--- a/hw/display/Kconfig
+++ b/hw/display/Kconfig
@@ -24,9 +24,11 @@ config PL110
 
 config SII9022
 bool
+depends on I2C
 
 config SSD0303
 bool
+depends on I2C
 
 config SSD0323
 bool
@@ -70,6 +72,7 @@ config MILKYMIST_TMU2
 
 config SM501
 bool
+depends on I2C
 
 config TCX
 bool
diff --git a/hw/gpio/Kconfig b/hw/gpio/Kconfig
index d0a4abf93f..9227cb5598 100644
--- a/hw/gpio/Kconfig
+++ b/hw/gpio/Kconfig
@@ -1,5 +1,6 @@
 config MAX7310
 bool
+depends on I2C
 
 config PL061
 bool
diff --git a/hw/i2c/Kconfig b/hw/i2c/Kconfig
index d6d4402608..74c9328729 100644
--- a/hw/i2c/Kconfig
+++ b/hw/i2c/Kconfig
@@ -3,18 +3,24 @@ config I2C
 
 config SMBUS_EEPROM
 bool
+depends on I2C
 
 config DDC
 bool
+depends on I2C
 
 config VERSATILE_I2C
 bool
+select I2C
 
 config ACPI_SMBUS
 bool
+select I2C
 
 config BITBANG_I2C
 bool
+select I2C
 
 config IMX_I2C
 bool
+select I2C
diff --git a/hw/i2c/Makefile.objs b/hw/i2c/Makefile.objs
index 48f7760379..ff22aa6541 100644
--- a/hw/i2c/Makefile.objs
+++ b/hw/i2c/Makefile.objs
@@ -1,4 +1,5 @@
-common-obj-$(CONFIG_I2C) += core.o smbus.o smbus_eeprom.o
+common-obj-$(CONFIG_I2C) += core.o smbus.o
+common-obj-$(CONFIG_SMBUS_EEPROM) += smbus_eeprom.o
 common-obj-$(CONFIG_DDC) += i2c-ddc.o
 common-obj-$(CONFIG_VERSATILE_I2C) += versatile_i2c.o
 common-obj-$(CONFIG_ACPI_X86_ICH) += smbus_ich9.o
diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index f53a788a95..695a67f88d 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -24,6 +24,7 @@ config PC_ACPI
 select ACPI_X86
 select ACPI_CPU_HOTPLUG
 select ACPI_MEMORY_HOTPLUG
+select SMBUS_EEPROM
 depends on ACPI_SMBUS
 
 config I440FX
diff --git a/hw/input/Kconfig b/hw/input/Kconfig
index 01805ed17b..5d64e07fc6 100644
--- a/hw/input/Kconfig
+++ b/hw/input/Kconfig
@@ -3,6 +3,7 @@ config ADB
 
 config LM832X
 bool
+depends on I2C
 
 config PCKBD
 bool
diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
index bf72e4fef2..82eaf183b1 100644
--- a/hw/isa/Kconfig
+++ b/hw/isa/Kconfig
@@ -18,6 +18,7 @@ config PIIX4
 config VT82C686
 bool
 select ISA_BUS
+select ACPI_SMBUS
 
 config SMC37C669
 bool
diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig
index e6df7480c6..0a87b52ec7 100644
--- a/hw/misc/Kconfig
+++ b/hw/misc/Kconfig
@@ -7,9 +7,11 @@ config MAX111X
 
 config TMP105
 bool
+depends on I2C
 
 config TMP421
 bool
+depends on I2C
 
 config ISA_DEBUG
 bool
@@ -34,6 +36,7 @@ config EDU
 
 config PCA9552
 bool
+depends on I2C
 
 config PL310
 bool
@@ -100,3 +103,4 @@ config PVPANIC
 
 config AUX
 bool
+depends on I2C
diff --git a/hw/timer/Kconfig b/hw/timer/Kconfig
index 7dbc1211ab..e1a6e7469b 100644
--- a/hw/timer/Kconfig
+++ b/hw/timer/Kconfig
@@ -9,6 +9,7 @@ config A9_GTIMER
 
 config DS1338
 bool
+depends on I2C
 
 config HPET
 bool
@@ -18,6 +19,7 @@ config I8254
 
 config M41T80
 bool
+depends on I2C
 
 config M48T59
 bool
@@ -27,6 +29,7 @@ config PL031
 
 config TWL92230
 bool
+depends on I2C
 
 config XLNX_ZYNQMP
 bool
-- 
2.17.1