[Qemu-devel] [RFC PATCH v2 2/6] rule.mak: allow per object cflags and libs

2013-09-06 Thread Fam Zheng
Adds extract-libs in LINK to expand any "per object libs", the syntax to define
such a libs options is like:

$(obj)/curl.o-libs = $(CURL_LIBS)

in block/Makefile.objs.

Similarly,

$(obj)foo.o-cflags = $(FOO_CFLAGS)

is also supported.

Signed-off-by: Fam Zheng 
---
 rules.mak | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/rules.mak b/rules.mak
index eef1b71..e581d55 100644
--- a/rules.mak
+++ b/rules.mak
@@ -17,15 +17,17 @@ QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d
 # Same as -I$(SRC_PATH) -I., but for the nested source/object directories
 QEMU_INCLUDES += -I$(

Re: [Qemu-devel] [RFC PATCH v2 2/6] rule.mak: allow per object cflags and libs

2013-09-06 Thread Michael Tokarev
06.09.2013 11:28, Fam Zheng wrote:
> Adds extract-libs in LINK to expand any "per object libs", the syntax to 
> define
> such a libs options is like:
> 
> $(obj)/curl.o-libs = $(CURL_LIBS)
> 
> in block/Makefile.objs.
> 
> Similarly,
> 
> $(obj)foo.o-cflags = $(FOO_CFLAGS)
> 
> is also supported.

Please note the UNsimilarity of -libs and -cflags --
one is with slash and another is without.  Is it just
the patch comment?

Thanks,

/mjt




Re: [Qemu-devel] [RFC PATCH v2 2/6] rule.mak: allow per object cflags and libs

2013-09-06 Thread Fam Zheng
On Fri, 09/06 14:42, Michael Tokarev wrote:
> 06.09.2013 11:28, Fam Zheng wrote:
> > Adds extract-libs in LINK to expand any "per object libs", the syntax to 
> > define
> > such a libs options is like:
> > 
> > $(obj)/curl.o-libs = $(CURL_LIBS)
> > 
> > in block/Makefile.objs.
> > 
> > Similarly,
> > 
> > $(obj)foo.o-cflags = $(FOO_CFLAGS)
> > 
> > is also supported.
> 
> Please note the UNsimilarity of -libs and -cflags --
> one is with slash and another is without.  Is it just
> the patch comment?
> 
It's a typo in the commit message. I will fix it.

Thanks,

Fam