Re: [Qemu-devel] [RFC v1 2/2] netduino2: Specify the valid CPUs

[Alistair Francis]

On Mon, Sep 11, 2017 at 4:56 AM, KONRAD Frederic
 wrote:
>
>
> On 09/06/2017 02:12 AM, Alistair Francis wrote:
>>
>> Signed-off-by: Alistair Francis 
>> ---
>>
>>   hw/arm/netduino2.c | 5 +
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/hw/arm/netduino2.c b/hw/arm/netduino2.c
>> index 3cfe332dd1..accca344fd 100644
>> --- a/hw/arm/netduino2.c
>> +++ b/hw/arm/netduino2.c
>> @@ -43,8 +43,13 @@ static void netduino2_init(MachineState *machine)
>> static void netduino2_machine_init(MachineClass *mc)
>>   {
>> +const char *val = "cortex-m3";
>> +
>>   mc->desc = "Netduino 2 Machine";
>>   mc->init = netduino2_init;
>> +
>> +mc->valid_cpu_types = g_array_new(false, false, sizeof(char *));
>> +g_array_append_val(mc->valid_cpu_types, val);
>>   }
>
>
> Hi Alistair,
>
> Nice idea! Why not adding an helper function which take a const
> char** in argument?

Thanks Fred.

I'm going to send a v2 with just that :)

Thanks,
Alistair

>
> Fred
>
>> DEFINE_MACHINE("netduino2", netduino2_machine_init)
>>
>

Re: [Qemu-devel] [RFC v1 2/2] netduino2: Specify the valid CPUs

[KONRAD Frederic]

On 09/06/2017 02:12 AM, Alistair Francis wrote:

Signed-off-by: Alistair Francis 
---

  hw/arm/netduino2.c | 5 +
  1 file changed, 5 insertions(+)

diff --git a/hw/arm/netduino2.c b/hw/arm/netduino2.c
index 3cfe332dd1..accca344fd 100644
--- a/hw/arm/netduino2.c
+++ b/hw/arm/netduino2.c
@@ -43,8 +43,13 @@ static void netduino2_init(MachineState *machine)
  
  static void netduino2_machine_init(MachineClass *mc)

  {
+const char *val = "cortex-m3";
+
  mc->desc = "Netduino 2 Machine";
  mc->init = netduino2_init;
+
+mc->valid_cpu_types = g_array_new(false, false, sizeof(char *));
+g_array_append_val(mc->valid_cpu_types, val);
  }


Hi Alistair,

Nice idea! Why not adding an helper function which take a const
char** in argument?

Fred

  
  DEFINE_MACHINE("netduino2", netduino2_machine_init)

[Qemu-devel] [RFC v1 2/2] netduino2: Specify the valid CPUs

[Alistair Francis]

Signed-off-by: Alistair Francis 
---

 hw/arm/netduino2.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/hw/arm/netduino2.c b/hw/arm/netduino2.c
index 3cfe332dd1..accca344fd 100644
--- a/hw/arm/netduino2.c
+++ b/hw/arm/netduino2.c
@@ -43,8 +43,13 @@ static void netduino2_init(MachineState *machine)
 
 static void netduino2_machine_init(MachineClass *mc)
 {
+const char *val = "cortex-m3";
+
 mc->desc = "Netduino 2 Machine";
 mc->init = netduino2_init;
+
+mc->valid_cpu_types = g_array_new(false, false, sizeof(char *));
+g_array_append_val(mc->valid_cpu_types, val);
 }
 
 DEFINE_MACHINE("netduino2", netduino2_machine_init)
-- 
2.11.0