[Qemu-devel] [RFC v4 12/71] alpha: convert to helper_cpu_halted_set

[Emilio G. Cota]

Signed-off-by: Emilio G. Cota 
---
 target/alpha/translate.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/target/alpha/translate.c b/target/alpha/translate.c
index e5d62850c5..25cd95931d 100644
--- a/target/alpha/translate.c
+++ b/target/alpha/translate.c
@@ -1226,8 +1226,7 @@ static DisasJumpType gen_call_pal(DisasContext *ctx, int 
palcode)
 /* WTINT */
 {
 TCGv_i32 tmp = tcg_const_i32(1);
-tcg_gen_st_i32(tmp, cpu_env, -offsetof(AlphaCPU, env) +
- offsetof(CPUState, halted));
+gen_helper_cpu_halted_set(cpu_env, tmp);
 tcg_temp_free_i32(tmp);
 }
 tcg_gen_movi_i64(ctx->ir[IR_V0], 0);
@@ -1382,8 +1381,7 @@ static DisasJumpType gen_mtpr(DisasContext *ctx, TCGv vb, 
int regno)
 /* WAIT */
 {
 TCGv_i32 tmp = tcg_const_i32(1);
-tcg_gen_st_i32(tmp, cpu_env, -offsetof(AlphaCPU, env) +
- offsetof(CPUState, halted));
+gen_helper_cpu_halted_set(cpu_env, tmp);
 tcg_temp_free_i32(tmp);
 }
 return gen_excp(ctx, EXCP_HALTED, 0);
-- 
2.17.1

Re: [Qemu-devel] [RFC v4 12/71] alpha: convert to helper_cpu_halted_set

[Richard Henderson]

On 10/25/18 3:45 PM, Emilio G. Cota wrote:
> Signed-off-by: Emilio G. Cota 
> ---
>  target/alpha/translate.c | 6 ++
>  1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Richard Henderson 

r~

Re: [Qemu-devel] [RFC v4 12/71] alpha: convert to helper_cpu_halted_set

[Alex Bennée]

Emilio G. Cota  writes:

> Signed-off-by: Emilio G. Cota 

Reviewed-by: Alex Bennée 

> ---
>  target/alpha/translate.c | 6 ++
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/target/alpha/translate.c b/target/alpha/translate.c
> index e5d62850c5..25cd95931d 100644
> --- a/target/alpha/translate.c
> +++ b/target/alpha/translate.c
> @@ -1226,8 +1226,7 @@ static DisasJumpType gen_call_pal(DisasContext *ctx, 
> int palcode)
>  /* WTINT */
>  {
>  TCGv_i32 tmp = tcg_const_i32(1);
> -tcg_gen_st_i32(tmp, cpu_env, -offsetof(AlphaCPU, env) +
> - offsetof(CPUState, halted));
> +gen_helper_cpu_halted_set(cpu_env, tmp);
>  tcg_temp_free_i32(tmp);
>  }
>  tcg_gen_movi_i64(ctx->ir[IR_V0], 0);
> @@ -1382,8 +1381,7 @@ static DisasJumpType gen_mtpr(DisasContext *ctx, TCGv 
> vb, int regno)
>  /* WAIT */
>  {
>  TCGv_i32 tmp = tcg_const_i32(1);
> -tcg_gen_st_i32(tmp, cpu_env, -offsetof(AlphaCPU, env) +
> - offsetof(CPUState, halted));
> +gen_helper_cpu_halted_set(cpu_env, tmp);
>  tcg_temp_free_i32(tmp);
>  }
>  return gen_excp(ctx, EXCP_HALTED, 0);


--
Alex Bennée