Re: [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files
On Fri, Jun 08, 2018 at 09:59:00AM -0500, Eric Blake wrote:
> On 06/07/2018 05:31 PM, Ross Zwisler wrote:
> > With a fully built QEMU I currently see the following with "git status":
> >
> >Untracked files:
> > (use "git add ..." to include in what will be committed)
> >
> > qapi/qapi-commands-job.c
> > qapi/qapi-commands-job.h
> > qapi/qapi-events-job.c
> > qapi/qapi-events-job.h
> > qapi/qapi-types-job.c
> > qapi/qapi-types-job.h
> > qapi/qapi-visit-job.c
> > qapi/qapi-visit-job.h
> >
> > These are all generated files. Ignore them.
> >
> > Signed-off-by: Ross Zwisler
> > Cc: Kevin Wolf
> > Cc: Eric Blake
> > Fixes: commit bf42508f24ee ("job: Introduce qapi/job.json")
>
> You're the third to post this:
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg07280.html
> https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg01624.html
I pulled your master branch yesterday before posting the series. If multiple
people are sending fixes to the same issue and the fixes are correct, the
easiest way to stop getting those fixes is probably to merge one of the
patches.
Re: [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files
On 06/08/2018 09:59 AM, Eric Blake wrote:
On 06/07/2018 05:31 PM, Ross Zwisler wrote:
With a fully built QEMU I currently see the following with "git status":
Untracked files:
(use "git add ..." to include in what will be committed)
qapi/qapi-commands-job.c
qapi/qapi-commands-job.h
qapi/qapi-events-job.c
qapi/qapi-events-job.h
qapi/qapi-types-job.c
qapi/qapi-types-job.h
qapi/qapi-visit-job.c
qapi/qapi-visit-job.h
These are all generated files. Ignore them.
Signed-off-by: Ross Zwisler
Cc: Kevin Wolf
Cc: Eric Blake
Fixes: commit bf42508f24ee ("job: Introduce qapi/job.json")
You're the third to post this:
https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg07280.html
https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg01624.html
Also, when sending a series, it's best to include a 0/5 cover letter
(the automated CI tooling handles that better, among other reasons).
You can use 'git config' to automatically send a cover letter for any
patch series > 1. For more tips,
https://wiki.qemu.org/Contribute/SubmitAPatch
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
Re: [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files
On 06/07/2018 05:31 PM, Ross Zwisler wrote:
With a fully built QEMU I currently see the following with "git status":
Untracked files:
(use "git add ..." to include in what will be committed)
qapi/qapi-commands-job.c
qapi/qapi-commands-job.h
qapi/qapi-events-job.c
qapi/qapi-events-job.h
qapi/qapi-types-job.c
qapi/qapi-types-job.h
qapi/qapi-visit-job.c
qapi/qapi-visit-job.h
These are all generated files. Ignore them.
Signed-off-by: Ross Zwisler
Cc: Kevin Wolf
Cc: Eric Blake
Fixes: commit bf42508f24ee ("job: Introduce qapi/job.json")
You're the third to post this:
https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg07280.html
https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg01624.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files
With a fully built QEMU I currently see the following with "git status":
Untracked files:
(use "git add ..." to include in what will be committed)
qapi/qapi-commands-job.c
qapi/qapi-commands-job.h
qapi/qapi-events-job.c
qapi/qapi-events-job.h
qapi/qapi-types-job.c
qapi/qapi-types-job.h
qapi/qapi-visit-job.c
qapi/qapi-visit-job.h
These are all generated files. Ignore them.
Signed-off-by: Ross Zwisler
Cc: Kevin Wolf
Cc: Eric Blake
Fixes: commit bf42508f24ee ("job: Introduce qapi/job.json")
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 81e1f2fb0f..2980090f0a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -100,6 +100,7 @@
/qapi/qapi-visit-ui.[ch]
/qapi/qapi-visit.[ch]
/qapi/qapi-doc.texi
+/qapi/qapi-*-job.[ch]
/qemu-doc.html
/qemu-doc.info
/qemu-doc.txt
--
2.14.4
