Re: [Qemu-devel] AArch64 linux-user: SA_ONSTACK usage in get_sigframe

2014-06-24 Thread Riku Voipio 
On Mon, Jun 23, 2014 at 06:15:03PM +0200, Laurent Desnogues wrote:
 Hello,
 
 in linux-user/signal.c the code for AArch64 get_sigframe reads like this:
 
 if ((ka-sa_flags  SA_ONSTACK)  !sas_ss_flags(sp)) {
 
 Shouldn't that be TARGET_SA_ONSTACK?
 
 The same question applies to Microblaze and OpenRISC.

Correct. Most people wont just notice since SA_ONSTACK appears to be
0x0800 for everything but alpha and parisc where it is 1.

Riku

[Qemu-devel] AArch64 linux-user: SA_ONSTACK usage in get_sigframe

2014-06-23 Thread Laurent Desnogues 
Hello,

in linux-user/signal.c the code for AArch64 get_sigframe reads like this:

if ((ka-sa_flags  SA_ONSTACK)  !sas_ss_flags(sp)) {

Shouldn't that be TARGET_SA_ONSTACK?

The same question applies to Microblaze and OpenRISC.

Thanks,

Laurent