Re: [Qemu-devel] Adding make check to the QEMU buildbot

2012-03-16 Thread Gerd Hoffmann
On 03/15/12 18:21, Stefan Weil wrote:
 Am 15.03.2012 09:06, schrieb Stefan Hajnoczi:
 QEMU has grown a number of sanity tests that can be run using make
 check. They are fast and do not require many resources.

 Is it possible to add make check after the build?

 We may have to deal with some failures in the beginning - either due to
 buildslave environment or legitimate broken platforms. But I think we
 can get all green pretty easily.

 Stefan
 
 You can combine build and check by running make  all check.

It is useful to keep them as separate steps though as the error mails
can tell you then which step failed.

cheers,
  Gerd



Re: [Qemu-devel] Adding make check to the QEMU buildbot

2012-03-16 Thread Anthony Liguori

On 03/15/2012 12:21 PM, Stefan Weil wrote:

Am 15.03.2012 09:06, schrieb Stefan Hajnoczi:

QEMU has grown a number of sanity tests that can be run using make
check. They are fast and do not require many resources.

Is it possible to add make check after the build?

We may have to deal with some failures in the beginning - either due to
buildslave environment or legitimate broken platforms. But I think we
can get all green pretty easily.

Stefan


You can combine build and check by running make all check.
I don't expect much red (if any at all).

The iotests need some disk space (400 MB are sufficient, but I
don't know the lower limit). An incremental build and check
takes typically less than 3 minutes on my virtual server.
I nearly always compile without optimization because that
speeds compilation a lot, and errors caused by optimization
are very rare.

Non-Linux hosts currently won't run the iotests.

Cross builds cannot run the tests.


Once qtest gets merged, there will be a make check-report.html which has a nice 
HTML output.


Regards,

Anthony Liguori



Regards,

Stefan W.







[Qemu-devel] Adding make check to the QEMU buildbot

2012-03-15 Thread Stefan Hajnoczi
QEMU has grown a number of sanity tests that can be run using make
check.  They are fast and do not require many resources.

Is it possible to add make check after the build?

We may have to deal with some failures in the beginning - either due to
buildslave environment or legitimate broken platforms.  But I think we
can get all green pretty easily.

Stefan




Re: [Qemu-devel] Adding make check to the QEMU buildbot

2012-03-15 Thread Stefan Weil

Am 15.03.2012 09:06, schrieb Stefan Hajnoczi:

QEMU has grown a number of sanity tests that can be run using make
check. They are fast and do not require many resources.

Is it possible to add make check after the build?

We may have to deal with some failures in the beginning - either due to
buildslave environment or legitimate broken platforms. But I think we
can get all green pretty easily.

Stefan


You can combine build and check by running make  all check.
I don't expect much red (if any at all).

The iotests need some disk space (400 MB are sufficient, but I
don't know the lower limit). An incremental build and check
takes typically less than 3 minutes on my virtual server.
I nearly always compile without optimization because that
speeds compilation a lot, and errors caused by optimization
are very rare.

Non-Linux hosts currently won't run the iotests.

Cross builds cannot run the tests.

Regards,

Stefan W.