Re: [Qemu-devel] For 1.2: Re: [PATCH 3/8] migration: move total_time from ram stats to migration info
Eric Blake ebl...@redhat.com writes:
On 08/18/2012 05:17 AM, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hmp.c| 4 ++--
migration.c | 6 +++---
qapi-schema.json | 14 +++---
qmp-commands.hx | 6 +++---
4 files changed, 15 insertions(+), 15 deletions(-)
+++ b/qapi-schema.json
@@ -290,10 +290,6 @@
#
# @total: total amount of bytes involved in the migration process
#
-# @total-time: total amount of ms since migration started. If
-#migration has ended, it returns the total migration
-#time. (since 1.2)
-#
# @duplicate: number of duplicate pages (since 1.2)
#
# @normal : number of normal pages (since 1.2)
@@ -304,8 +300,7 @@
##
{ 'type': 'MigrationStats',
'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' ,
- 'total-time': 'int', 'duplicate': 'int', 'normal': 'int',
- 'normal-bytes': 'int' } }
+ 'duplicate': 'int', 'normal': 'int', 'normal-bytes': 'int' } }
##
# @XBZRLECacheStats
@@ -350,12 +345,17 @@
#migration statistics, only returned if XBZRLE feature is
on and
#status is 'active' or 'completed' (since 1.2)
#
+# @total-time: total amount of milliseconds since migration started.
+#If migration has ended, it returns the total migration
+#time. (since 1.2)
+#
# Since: 0.14.0
##
{ 'type': 'MigrationInfo',
'data': {'*status': 'str', '*ram': 'MigrationStats',
'*disk': 'MigrationStats',
- '*xbzrle-cache': 'XBZRLECacheStats'} }
+ '*xbzrle-cache': 'XBZRLECacheStats',
+ 'total-time': 'int'} }
Anthony - are you planning on taking this series for 1.2?
No. This is a new feature and we're past freeze.
If we don't
get this patch in on time, then taking this for 1.3 would result in
changing released QMP interface (right now, there has been no release
with the field in the wrong type).
Ack. We need to preserve compat with the 1.2 interface.
Regards,
Anthony Liguori
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
Re: [Qemu-devel] For 1.2: Re: [PATCH 3/8] migration: move total_time from ram stats to migration info
On 08/22/2012 07:22 AM, Anthony Liguori wrote:
Just restating things to make sure I'm clear...
{ 'type': 'MigrationInfo',
'data': {'*status': 'str', '*ram': 'MigrationStats',
'*disk': 'MigrationStats',
- '*xbzrle-cache': 'XBZRLECacheStats'} }
+ '*xbzrle-cache': 'XBZRLECacheStats',
+ 'total-time': 'int'} }
Anthony - are you planning on taking this series for 1.2?
No. This is a new feature and we're past freeze.
No, the overall series (patches 1,2,4-8) is not appropriate at this time.
If we don't
get this patch in on time, then taking this for 1.3 would result in
changing released QMP interface (right now, there has been no release
with the field in the wrong type).
Ack. We need to preserve compat with the 1.2 interface.
Yes, this particular patch 3 is a bug fix in order to prevent a future
regression when 1.3 takes the rest of the series, and must therefore be
part of the 1.2 release (and Luiz is on top of that, via the qmp branch).
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] For 1.2: Re: [PATCH 3/8] migration: move total_time from ram stats to migration info
On Sat, 18 Aug 2012 07:02:50 -0600
Eric Blake ebl...@redhat.com wrote:
On 08/18/2012 05:17 AM, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hmp.c| 4 ++--
migration.c | 6 +++---
qapi-schema.json | 14 +++---
qmp-commands.hx | 6 +++---
4 files changed, 15 insertions(+), 15 deletions(-)
+++ b/qapi-schema.json
@@ -290,10 +290,6 @@
#
# @total: total amount of bytes involved in the migration process
#
-# @total-time: total amount of ms since migration started. If
-#migration has ended, it returns the total migration
-#time. (since 1.2)
-#
# @duplicate: number of duplicate pages (since 1.2)
#
# @normal : number of normal pages (since 1.2)
@@ -304,8 +300,7 @@
##
{ 'type': 'MigrationStats',
'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' ,
- 'total-time': 'int', 'duplicate': 'int', 'normal': 'int',
- 'normal-bytes': 'int' } }
+ 'duplicate': 'int', 'normal': 'int', 'normal-bytes': 'int' } }
##
# @XBZRLECacheStats
@@ -350,12 +345,17 @@
#migration statistics, only returned if XBZRLE feature is
on and
#status is 'active' or 'completed' (since 1.2)
#
+# @total-time: total amount of milliseconds since migration started.
+#If migration has ended, it returns the total migration
+#time. (since 1.2)
Field is optional, needs to be marked as such and the has_total_time field
should be set appropriately.
+#
# Since: 0.14.0
##
{ 'type': 'MigrationInfo',
'data': {'*status': 'str', '*ram': 'MigrationStats',
'*disk': 'MigrationStats',
- '*xbzrle-cache': 'XBZRLECacheStats'} }
+ '*xbzrle-cache': 'XBZRLECacheStats',
+ 'total-time': 'int'} }
Anthony - are you planning on taking this series for 1.2? If we don't
get this patch in on time, then taking this for 1.3 would result in
changing released QMP interface (right now, there has been no release
with the field in the wrong type).
I can cherry-pick this into the qmp branch.
Juan, I can also fix myself the problem I pointed out above if that
works for you.
Re: [Qemu-devel] For 1.2: Re: [PATCH 3/8] migration: move total_time from ram stats to migration info
Luiz Capitulino lcapitul...@redhat.com wrote: On Sat, 18 Aug 2012 07:02:50 -0600 Eric Blake ebl...@redhat.com wrote: I can cherry-pick this into the qmp branch. Juan, I can also fix myself the problem I pointed out above if that works for you. I very much preffer that. But what to do with the other ones? They are really simple, and it makes things better for users? Anthony? Later, Juan.
Re: [Qemu-devel] For 1.2: Re: [PATCH 3/8] migration: move total_time from ram stats to migration info
On Tue, 21 Aug 2012 17:00:20 +0200 Juan Quintela quint...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com wrote: On Sat, 18 Aug 2012 07:02:50 -0600 Eric Blake ebl...@redhat.com wrote: I can cherry-pick this into the qmp branch. Juan, I can also fix myself the problem I pointed out above if that works for you. I very much preffer that. Done, and applied to the qmp branch for 1.2. But what to do with the other ones? They look good to me, but I think it's too late for 1.2.
[Qemu-devel] For 1.2: Re: [PATCH 3/8] migration: move total_time from ram stats to migration info
On 08/18/2012 05:17 AM, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hmp.c| 4 ++--
migration.c | 6 +++---
qapi-schema.json | 14 +++---
qmp-commands.hx | 6 +++---
4 files changed, 15 insertions(+), 15 deletions(-)
+++ b/qapi-schema.json
@@ -290,10 +290,6 @@
#
# @total: total amount of bytes involved in the migration process
#
-# @total-time: total amount of ms since migration started. If
-#migration has ended, it returns the total migration
-#time. (since 1.2)
-#
# @duplicate: number of duplicate pages (since 1.2)
#
# @normal : number of normal pages (since 1.2)
@@ -304,8 +300,7 @@
##
{ 'type': 'MigrationStats',
'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' ,
- 'total-time': 'int', 'duplicate': 'int', 'normal': 'int',
- 'normal-bytes': 'int' } }
+ 'duplicate': 'int', 'normal': 'int', 'normal-bytes': 'int' } }
##
# @XBZRLECacheStats
@@ -350,12 +345,17 @@
#migration statistics, only returned if XBZRLE feature is on
and
#status is 'active' or 'completed' (since 1.2)
#
+# @total-time: total amount of milliseconds since migration started.
+#If migration has ended, it returns the total migration
+#time. (since 1.2)
+#
# Since: 0.14.0
##
{ 'type': 'MigrationInfo',
'data': {'*status': 'str', '*ram': 'MigrationStats',
'*disk': 'MigrationStats',
- '*xbzrle-cache': 'XBZRLECacheStats'} }
+ '*xbzrle-cache': 'XBZRLECacheStats',
+ 'total-time': 'int'} }
Anthony - are you planning on taking this series for 1.2? If we don't
get this patch in on time, then taking this for 1.3 would result in
changing released QMP interface (right now, there has been no release
with the field in the wrong type).
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
