Re: [Qemu-devel] PATCH: allow Sparc hosts to run arm/mips/sparc-softmmu
On Tuesday 13 March 2007 10:25 am, Ben Taylor wrote: However, it's very wax-on, wax-off kind of thing. Without the patch, arm-test and mips-test crash. With the patch, I can run both tests. Could we get a reproduction sequence for the crashes please? Rob -- Vista: Windows Millenium Second Edition ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] PATCH: allow Sparc hosts to run arm/mips/sparc-softmmu
This patch fixes crashes when testing with arm-test-0.2.tar.gz and mips-test-0.2.tar.gz. Without the patch, both arm-test and mips-test segfault when trying to boot. The original patch was authored by Martin Bochnig. --- qemu/cpu-exec.c.ORIG 2007-03-13 09:46:51.940624000 -0400 +++ qemu/cpu-exec.c 2007-03-13 09:33:34.130534000 -0400 @@ -738,7 +744,10 @@ #else gen_func(); #endif +/* sparc hosts don't seem to like this method very much */ +#if !(defined(__sparc__) !defined(TARGET_I386) !defined(TARGET_X86_64) !defined(TARGET_PPC)) env-current_tb = NULL; +#endif /* reset soft MMU for next block (it can currently only be set by a memory fault) */ #if defined(TARGET_I386) !defined(CONFIG_SOFTMMU) ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
Re: [Qemu-devel] PATCH: allow Sparc hosts to run arm/mips/sparc-softmmu
Paul Brook [EMAIL PROTECTED] wrote: On Tuesday 13 March 2007 14:01, Ben Taylor wrote: This patch fixes crashes when testing with arm-test-0.2.tar.gz and mips-test-0.2.tar.gz. Without the patch, both arm-test and mips-test segfault when trying to boot. I don't believe this is correct. You're going to have to come up with a fairly convincing argument to get a patch like this accepted. don't seem to like this very much is not a useful comment. Yeah, so the comment is not very useful. I copied it from the author. I'll see if he can actually explain why this patch is important. However, it's very wax-on, wax-off kind of thing. Without the patch, arm-test and mips-test crash. With the patch, I can run both tests. Ben ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
Re: [Qemu-devel] PATCH: allow Sparc hosts to run arm/mips/sparc-softmmu
However, it's very wax-on, wax-off kind of thing. Without the patch, arm-test and mips-test crash. With the patch, I can run both tests. As I've said before it's not sufficient to say that a patch fixes a bug, you have to explain *what* bug you are fixing, *how* it fixes the bug, and *why* it's the correct way to fix it. In order to review the patch I need to be able to follow your logic for creating the patch. If you don't understand the patch you should not be submitting it. In this specific case: * What: qemu crashes is not a particularly useful description of the failure mode. I want to know how (eg. segfault, abort, infinite loop, does wrong thing) it crashes, which bit of code it's executing when it crashes, and how it got to that point. * How: I'm also not convinced your #ifdef does what you think it does, though It's somewhat unclear what you're trying to achieve. I'm guessing you intended to disable the code on sparc hosted arm+mips targets * Why: I randomly changed things until it started working is not a valid justification for a change. Why doesn't this failure occur on other hosts? Why only arm and mips targets? Paul ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
