Re: [Qemu-devel] RE. [PATCH] sheepdog: fix send req helpers

[Kevin Wolf]

Am 03.04.2012 13:13, schrieb MORITA Kazutaka:
> At Tue,  3 Apr 2012 18:04:21 +0800,
> Liu Yuan wrote:
>>
>> From: Liu Yuan 
>>
>> Yes, I think so. Here is the patch.
>>
>> Subject: [PATCH] sheepdog: fix send req helpers
>> From: Liu Yuan 
>>
>> We should return if reading of the header fails.
>>
>> Cc: Kevin Wolf 
>> Cc: MORITA Kazutaka 
>> Signed-off-by: Liu Yuan 
>> ---
>>  block/sheepdog.c |2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> Acked-by: MORITA Kazutaka 

Thanks, applied this one as well.

Kevin

Re: [Qemu-devel] RE. [PATCH] sheepdog: fix send req helpers

[MORITA Kazutaka]

At Tue,  3 Apr 2012 18:04:21 +0800,
Liu Yuan wrote:
> 
> From: Liu Yuan 
> 
> Yes, I think so. Here is the patch.
> 
> Subject: [PATCH] sheepdog: fix send req helpers
> From: Liu Yuan 
> 
> We should return if reading of the header fails.
> 
> Cc: Kevin Wolf 
> Cc: MORITA Kazutaka 
> Signed-off-by: Liu Yuan 
> ---
>  block/sheepdog.c |2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Acked-by: MORITA Kazutaka 

[Qemu-devel] RE. [PATCH] sheepdog: fix send req helpers

[Liu Yuan]

From: Liu Yuan 

Yes, I think so. Here is the patch.

Subject: [PATCH] sheepdog: fix send req helpers
From: Liu Yuan 

We should return if reading of the header fails.

Cc: Kevin Wolf 
Cc: MORITA Kazutaka 
Signed-off-by: Liu Yuan 
---
 block/sheepdog.c |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/block/sheepdog.c b/block/sheepdog.c
index 62dfa48..73308b2 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -510,6 +510,7 @@ static int send_req(int sockfd, SheepdogReq *hdr, void 
*data,
 ret = qemu_send_full(sockfd, hdr, sizeof(*hdr), 0);
 if (ret < sizeof(*hdr)) {
 error_report("failed to send a req, %s", strerror(errno));
+return ret;
 }
 
 ret = qemu_send_full(sockfd, data, *wlen, 0);
@@ -528,6 +529,7 @@ static int send_co_req(int sockfd, SheepdogReq *hdr, void 
*data,
 ret = qemu_co_send(sockfd, hdr, sizeof(*hdr));
 if (ret < sizeof(*hdr)) {
 error_report("failed to send a req, %s", strerror(errno));
+return ret;
 }
 
 ret = qemu_co_send(sockfd, data, *wlen);
-- 
1.7.8.2