[Qemu-devel] Re: [PATCH 01/11] Add hard build dependency on glib

2011-03-23 Thread Paolo Bonzini

On 03/23/2011 09:58 AM, Roy Tam wrote:

I think I have to change my words. Glib works in win32, but adding
Glib to QEMU will bloat the binary size. It adds more dependency on
building and the result binary. I wonder if it is a must to add it.


That's very far from my definition of breaking.

Paolo



[Qemu-devel] Re: [PATCH 01/11] Add hard build dependency on glib

2011-03-12 Thread Paolo Bonzini

On 03/11/2011 10:00 PM, Anthony Liguori wrote:

GLib is an extremely common library that has a portable thread implementation
along with tons of other goodies.

GLib and GObject have a fantastic amount of infrastructure we can leverage in
QEMU including an object oriented programming infrastructure.

Short term, it has a very nice thread pool implementation that we could leverage
in something like virtio-9p.  It also has a test harness implementation that
this series will use.

Signed-off-by: Anthony Liguorialigu...@us.ibm.com


This doesn't need to go in until there is use for it, which is IIRC for 
the QAPI tests?


Paolo



Re: [Qemu-devel] Re: [PATCH 01/11] Add hard build dependency on glib

2011-03-12 Thread Anthony Liguori

On 03/12/2011 02:09 AM, Paolo Bonzini wrote:

On 03/11/2011 10:00 PM, Anthony Liguori wrote:
GLib is an extremely common library that has a portable thread 
implementation

along with tons of other goodies.

GLib and GObject have a fantastic amount of infrastructure we can 
leverage in

QEMU including an object oriented programming infrastructure.

Short term, it has a very nice thread pool implementation that we 
could leverage
in something like virtio-9p.  It also has a test harness 
implementation that

this series will use.

Signed-off-by: Anthony Liguorialigu...@us.ibm.com


This doesn't need to go in until there is use for it, which is IIRC 
for the QAPI tests?


Correct.  I mistakenly thought I still used it in Error but I removed 
that dependency.


Regards,

Anthony Liguori


Paolo