[Qemu-devel] Re: [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu
Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 24 February 2011 10:33, Juan Quintela quint...@redhat.com wrote: +# shared-obj-y has the object that are shared by qemu binary and tools + +shared-obj-y = qemu-error.o $(block-obj-y) $(qobject-obj-y) $(oslib-obj-y) +shared-obj-y += qemu-timer-common.o I don't feel very strongly about this, but: It seems a bit odd to have a shared-obj-y variable that isn't actually a list of shared objects (ie .so files, DLLs). Maybe there's a better name? common-obj-y? already taken :-( common-obj-y is the list of files that are shared by all qemu-softmmu ## # libqemu_common.a: Target independent part of system emulation. The # long term path is to suppress *all* target specific code in case of # system emulation, i.e. a single QEMU executable should support all # CPUs and machines. common-obj-y = $(block-obj-y) blockdev.o ... so, this is the list of files that are shared between all the softmmu (common) and the tools. I am open to suggestions, but all names I thought are worse than shared (common-common-obj-y) :p Later, Juan.
[Qemu-devel] Re: [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu
Juan Quintela quint...@redhat.com writes: Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 24 February 2011 10:33, Juan Quintela quint...@redhat.com wrote: +# shared-obj-y has the object that are shared by qemu binary and tools + +shared-obj-y = qemu-error.o $(block-obj-y) $(qobject-obj-y) $(oslib-obj-y) +shared-obj-y += qemu-timer-common.o I don't feel very strongly about this, but: It seems a bit odd to have a shared-obj-y variable that isn't actually a list of shared objects (ie .so files, DLLs). Maybe there's a better name? common-obj-y? already taken :-( common-obj-y is the list of files that are shared by all qemu-softmmu ## # libqemu_common.a: Target independent part of system emulation. The # long term path is to suppress *all* target specific code in case of # system emulation, i.e. a single QEMU executable should support all # CPUs and machines. common-obj-y = $(block-obj-y) blockdev.o ... so, this is the list of files that are shared between all the softmmu (common) and the tools. I am open to suggestions, but all names I thought are worse than shared (common-common-obj-y) :p really-common-obj-y? ;) Seriously, what about renaming common-obj-y away? target-indep-obj-y?
[Qemu-devel] Re: [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu
On 02/24/2011 02:53 PM, Markus Armbruster wrote: really-common-obj-y?;) Seriously, what about renaming common-obj-y away? target-indep-obj-y? softmmu-obj-y? Paolo
[Qemu-devel] Re: [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu
Paolo Bonzini pbonz...@redhat.com wrote: On 02/24/2011 02:53 PM, Markus Armbruster wrote: really-common-obj-y?;) Seriously, what about renaming common-obj-y away? target-indep-obj-y? softmmu-obj-y? Waiting for Anthony to decide anything, renaming the variable is the easy thing to do. Later, Juan.
