[Qemu-devel] Re: [PATCH 4/6] Tell BIOS about the number of CPUs

2008-01-31 Thread Paul Brook
> > Are the CMOS contents documented anywhere?
>
> No, but if you have a suggestion of where to document them, I'll add
> documentation.

I suggest in or with the BIOS sources.
As we're using a common BIOS it seems a good idea to make sure this kind of 
things is coordinated.

Paul




[Qemu-devel] Re: [PATCH 4/6] Tell BIOS about the number of CPUs

2008-01-31 Thread Anthony Liguori

Paul Brook wrote:

-cmos_init(ram_size, above_4g_mem_size, boot_device, hd);
+cmos_init(ram_size, above_4g_mem_size, boot_device, hd, smp_cpus);



smp_cpus is a global variable. Why bother passing it around?
  


True, I'll update the patch


Are the CMOS contents documented anywhere?
  


No, but if you have a suggestion of where to document them, I'll add 
documentation.


Regards,

Anthony Liguori


Paul
  






[Qemu-devel] Re: [PATCH 4/6] Tell BIOS about the number of CPUs

2008-01-31 Thread Paul Brook
> -cmos_init(ram_size, above_4g_mem_size, boot_device, hd);
> +cmos_init(ram_size, above_4g_mem_size, boot_device, hd, smp_cpus);

smp_cpus is a global variable. Why bother passing it around?

Are the CMOS contents documented anywhere?

Paul