[Qemu-devel] Re: [PATCH 5/5] char: Equip the unix/tcp backend to handle nonblocking writes

2011-01-11 Thread Amit Shah
On (Tue) Jan 11 2011 [14:38:00], Paolo Bonzini wrote:
> On 01/11/2011 12:10 PM, Amit Shah wrote:
> >+char_set_fd_handlers(s->fd, tcp_chr_read_poll, tcp_chr_read,
> >+ char_write_unblocked, chr, poll_out);
> 
> Would the 4th parameter always be char_write_unblocked?  If so, what
> about making it hidden within char_set_fd_handlers (also because
> char_write_unblocked is static in qemu-char.c).

It could change for other backends, but the plan is to move to a
struct-type declaration even for the fd handlers, like discussed in the
other thread with Gerd.

Amit



[Qemu-devel] Re: [PATCH 5/5] char: Equip the unix/tcp backend to handle nonblocking writes

2011-01-11 Thread Paolo Bonzini

On 01/11/2011 12:10 PM, Amit Shah wrote:

+char_set_fd_handlers(s->fd, tcp_chr_read_poll, tcp_chr_read,
+ char_write_unblocked, chr, poll_out);


Would the 4th parameter always be char_write_unblocked?  If so, what 
about making it hidden within char_set_fd_handlers (also because 
char_write_unblocked is static in qemu-char.c).


Paolo