Re: [Qemu-devel] Stair step trace output since 12fb0ac05
On 06.06.2018 20:33, Peter Maydell wrote: > On 6 June 2018 at 18:15, BALATON Zoltan wrote: >> Hello, >> >> Since 12fb0ac05 (char: Remove unwanted crlf conversion) trace output is >> printed in stair steps when using -trace and -serial stdio together. E.g. >> $ qemu-system-i386 -trace 'pci*' -serial stdio > > I had a feeling that we were going to find that there were > situations where we really wanted to retain the crlf > processing... I think the problem is that we've turned it on in char-stdio.c, too. char-serial.c should be sufficient. Is someone volunteering for sending a patch to revert the changes in char-stdio.c ? Thomas
Re: [Qemu-devel] Stair step trace output since 12fb0ac05
On Thu, Jun 7, 2018 at 6:56 AM, Thomas Huth wrote: > On 06.06.2018 20:56, Markus Armbruster wrote: >> BALATON Zoltan writes: >> >>> Hello, >>> >>> Since 12fb0ac05 (char: Remove unwanted crlf conversion) trace output >>> is printed in stair steps when using -trace and -serial stdio >>> together. E.g. >>> $ qemu-system-i386 -trace 'pci*' -serial stdio >>> >>> Regards, >>> BALATON Zoltan >> >> I cc'ed the people involved with this patch for you. > > Is it OK if you revert the change to chardev/char-stdio.c, but not > chardev/char-serial.c ? That's what I did, and it was enough to fix the issues I had. Thanks, Laurent
Re: [Qemu-devel] Stair step trace output since 12fb0ac05
On 06.06.2018 20:56, Markus Armbruster wrote: > BALATON Zoltan writes: > >> Hello, >> >> Since 12fb0ac05 (char: Remove unwanted crlf conversion) trace output >> is printed in stair steps when using -trace and -serial stdio >> together. E.g. >> $ qemu-system-i386 -trace 'pci*' -serial stdio >> >> Regards, >> BALATON Zoltan > > I cc'ed the people involved with this patch for you. Is it OK if you revert the change to chardev/char-stdio.c, but not chardev/char-serial.c ? Thomas
Re: [Qemu-devel] Stair step trace output since 12fb0ac05
BALATON Zoltan writes: > Hello, > > Since 12fb0ac05 (char: Remove unwanted crlf conversion) trace output > is printed in stair steps when using -trace and -serial stdio > together. E.g. > $ qemu-system-i386 -trace 'pci*' -serial stdio > > Regards, > BALATON Zoltan I cc'ed the people involved with this patch for you.
Re: [Qemu-devel] Stair step trace output since 12fb0ac05
On 6 June 2018 at 18:15, BALATON Zoltan wrote: > Hello, > > Since 12fb0ac05 (char: Remove unwanted crlf conversion) trace output is > printed in stair steps when using -trace and -serial stdio together. E.g. > $ qemu-system-i386 -trace 'pci*' -serial stdio I had a feeling that we were going to find that there were situations where we really wanted to retain the crlf processing... thanks -- PMM
Re: [Qemu-devel] Stair step trace output since 12fb0ac05
On 06/06/2018 02:15 PM, BALATON Zoltan wrote: > Since 12fb0ac05 (char: Remove unwanted crlf conversion) trace output is > printed in stair steps when using -trace and -serial stdio together. E.g. > $ qemu-system-i386 -trace 'pci*' -serial stdio True! I'm seeing this too, didn't mind to bisect. $ arm-softmmu/qemu-system-arm -M lm3s6965evb -serial vc -kernel sd_card.bin -sd sdcard.img -d trace:sd* -S -monitor stdio WARNING: Image format was not specified for 'sdcard.img' and probing guessed raw. Automatically detecting the format is dangerous for raw images, write operations on block 0 will be restricted. Specify the 'raw' format explicitly to remove the restrictions. QEMU 2.12.50 monitor - type 'help' for more information (qemu) 24447@1528302742.804868:sdcard_hard_reset power-on 24447@1528302742.804880:sdcard_set_voltage 3.300V (UHS:0) 24447@1528302742.804887:sdcard_soft_reset reset
[Qemu-devel] Stair step trace output since 12fb0ac05
Hello, Since 12fb0ac05 (char: Remove unwanted crlf conversion) trace output is printed in stair steps when using -trace and -serial stdio together. E.g. $ qemu-system-i386 -trace 'pci*' -serial stdio Regards, BALATON Zoltan
