[Qemu-devel] qemu -device ? segfaults

2012-02-23 Thread Gerd Hoffmann
  Hi,

$subject says all, which pretty much breaks libvirt-managed qemu ...

cheers,
  Gerd



Re: [Qemu-devel] qemu -device ? segfaults

2012-02-23 Thread Gerd Hoffmann
On 02/23/12 09:20, Gerd Hoffmann wrote:
   Hi,
 
 $subject says all, which pretty much breaks libvirt-managed qemu ...

Even just qemu segfaults, right here:

(gdb) bt
#0  qemu_opt_get (opts=0x0, name=0x77f7478f kernel)
at /home/kraxel/projects/qemu/qemu-option.c:545
#1  0x77deb1b0 in main (argc=value optimized out, argv=value
optimized out,
envp=value optimized out) at /home/kraxel/projects/qemu/vl.c:3250

cheers,
  Gerd



Re: [Qemu-devel] qemu -device ? segfaults

2012-02-23 Thread Peter Maydell
On 23 February 2012 08:20, Gerd Hoffmann kra...@redhat.com wrote:
 $subject says all, which pretty much breaks libvirt-managed qemu ...

Does http://patchwork.ozlabs.org/patch/142548/ fix this for you?

-- PMM



Re: [Qemu-devel] qemu -device ? segfaults

2012-02-23 Thread andrzej zaborowski
On 23 February 2012 09:20, Gerd Hoffmann kra...@redhat.com wrote:
 $subject says all, which pretty much breaks libvirt-managed qemu ...

Also device_add nonexistent-device in the monitor gives a rather
unhelpful message:

Parameter 'driver' expects device type

Cheers



Re: [Qemu-devel] qemu -device ? segfaults

2012-02-23 Thread Markus Armbruster
andrzej zaborowski balr...@gmail.com writes:

 On 23 February 2012 09:20, Gerd Hoffmann kra...@redhat.com wrote:
 $subject says all, which pretty much breaks libvirt-managed qemu ...

 Also device_add nonexistent-device in the monitor gives a rather
 unhelpful message:

 Parameter 'driver' expects device type

-device foo is really shorthand for -device driver=foo.  And deep
down in the bowels of qdev, where the error get reported, the value of
parameter driver gets treated like any other parameter's value: if
it's not within ACCEPTABLE-SET, complain Parameter 'NAME' expected
ACCEPTABLE-SET.

Overuse of syntactic sugar considered harmful.



Re: [Qemu-devel] qemu -device ? segfaults

2012-02-23 Thread Gerd Hoffmann
On 02/23/12 09:23, Peter Maydell wrote:
 On 23 February 2012 08:20, Gerd Hoffmann kra...@redhat.com wrote:
 $subject says all, which pretty much breaks libvirt-managed qemu ...
 
 Does http://patchwork.ozlabs.org/patch/142548/ fix this for you?

Yes.

thanks,
  Gerd




Re: [Qemu-devel] qemu -device ? segfaults

2012-02-23 Thread andrzej zaborowski
On 23 February 2012 09:48, Markus Armbruster arm...@redhat.com wrote:
 andrzej zaborowski balr...@gmail.com writes:

 On 23 February 2012 09:20, Gerd Hoffmann kra...@redhat.com wrote:
 $subject says all, which pretty much breaks libvirt-managed qemu ...

 Also device_add nonexistent-device in the monitor gives a rather
 unhelpful message:

 Parameter 'driver' expects device type

 -device foo is really shorthand for -device driver=foo.  And deep
 down in the bowels of qdev, where the error get reported, the value of
 parameter driver gets treated like any other parameter's value: if
 it's not within ACCEPTABLE-SET, complain Parameter 'NAME' expected
 ACCEPTABLE-SET.

Yeah, I looked at this code, perhaps 'INPUT' is not a valid
'ACCEPTABLE-SET' would be more helpful.  In my message I was talking
about the monitor command though.  Something like you typoed in the
device name should be reported by the human readable monitor.

Cheers