Re: [Qemu-devel] typofixes

2015-09-11 Thread Michael Tokarev 
08.09.2015 11:26, Peter Maydell wrote:
> On 7 September 2015 at 22:45, Veres Lajos  wrote:
>> Hi,
>>
>> Please find attached a couple of typo fixes, mostly in comments/docs.
>> (Please cc me directly, I am not on the list.)
> 
> That patch includes at least one change to linux-headers/,
> which is definitely wrong. Typos in the kernel headers need
> to be sent to the kernel list, and we will get them next time
> we do a header sync. It also has a change to disas/libvixl,
> which is also a bit pointless as that is an external project
> which we sync with. Further, it mixes changes to comments and
> docs (totally safe) with changes to code function names etc
> (needs closer review), and it's pretty huge so it's hard to
> review the latter very easily.
> 
> MJT: can you drop this patch from the trivial queue, please?

Dropped now :)  I apologize for not seeing the obvious problems
you and others found, this is the result of me being too relaxed
after returning from vacation :)

Thanks,

/mjt

Re: [Qemu-devel] typofixes

2015-09-08 Thread Markus Armbruster 
Veres Lajos  writes:

> Hi,
>
> Please find attached a couple of typo fixes, mostly in comments/docs.
> (Please cc me directly, I am not on the list.)
>
> Best regards,

Thanks.  Next time, please follow
http://qemu-project.org/Contribute/SubmitAPatch
to produce a patch in the orthodox format.

Re: [Qemu-devel] typofixes

2015-09-08 Thread Peter Maydell 
On 7 September 2015 at 22:45, Veres Lajos  wrote:
> Hi,
>
> Please find attached a couple of typo fixes, mostly in comments/docs.
> (Please cc me directly, I am not on the list.)

That patch includes at least one change to linux-headers/,
which is definitely wrong. Typos in the kernel headers need
to be sent to the kernel list, and we will get them next time
we do a header sync. It also has a change to disas/libvixl,
which is also a bit pointless as that is an external project
which we sync with. Further, it mixes changes to comments and
docs (totally safe) with changes to code function names etc
(needs closer review), and it's pretty huge so it's hard to
review the latter very easily.

MJT: can you drop this patch from the trivial queue, please?

Veres: can you drop the libvixl and linux-headers changes,
and at least split the remainder into docs/comments vs
code changes, and resend the patches to qemu-devel, please?

thanks
-- PMM

Re: [Qemu-devel] typofixes

2015-09-08 Thread Eric Blake 
On 09/08/2015 12:01 PM, Veres Lajos wrote:
> On Tue, 8 Sep 2015, Peter Maydell wrote:
> 

In addition to the problems Peter pointed out,

> +++ b/target-cris/translate.c
> @@ -103,8 +103,8 @@ typedef struct DisasContext {
>  int cc_size_uptodate; /* -1 invalid or last written value.  */
>  
>  int cc_x_uptodate;  /* 1 - ccs, 2 - known | X_FLAG. 0 not uptodate.  */
> -int flags_uptodate; /* Wether or not $ccs is uptodate.  */
> -int flagx_known; /* Wether or not flags_x has the x flag known at
> +int flags_uptodate; /* Whether or not $ccs is uptodate.  */

s/uptodate/up-to-date/ in both comments

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature

Re: [Qemu-devel] typofixes

2015-09-08 Thread Veres Lajos 
On Tue, 8 Sep 2015, Peter Maydell wrote:

> Veres: can you drop the libvixl and linux-headers changes,
> and at least split the remainder into docs/comments vs
> code changes, and resend the patches to qemu-devel, please?

I have removed the linux-headers/ and disas/libvixl/ changes.
And I think the only non-comment/non-doc change is this:
tests/qemu-iotests/041
-def test_unexistant_replaces(self):
+def test_unexistent_replaces(self):

If you want I can move this to another patch.

The patch contains mostly simple typos, it is a bit easier to review them
with --word-diff.

Best regards,
-- 
Lajos Veres
vla...@gmail.com
0792 7460 778From 6d3fe18be0b595b1a439d9bd9767cd2eed60cae2 Mon Sep 17 00:00:00 2001
From: Veres Lajos 
Date: Fri, 7 Aug 2015 23:05:21 +0100
Subject: [PATCH] typofix - https://github.com/vlajos/misspell_fixer

---
 disas/i386.c|2 +-
 disas/s390.c|4 ++--
 docs/specs/ppc-spapr-hcalls.txt |4 ++--
 docs/writing-qmp-commands.txt   |2 +-
 hw/audio/fmopl.c|2 +-
 hw/core/qdev.c  |2 +-
 hw/cris/axis_dev88.c|2 +-
 hw/display/qxl-render.c |2 +-
 hw/dma/xilinx_axidma.c  |2 +-
 hw/input/stellaris_input.c  |2 +-
 hw/intc/xics.c  |2 +-
 hw/net/fsl_etsec/etsec.c|2 +-
 hw/sd/pl181.c   |2 +-
 hw/vfio/pci.c   |2 +-
 hw/xen/xen-host-pci-device.c|2 +-
 include/block/scsi.h|2 +-
 include/exec/memory.h   |2 +-
 libcacard/card_7816t.h  |2 +-
 libdecnumber/decContext.c   |2 +-
 libdecnumber/decNumber.c|8 
 linux-user/syscall.c|2 +-
 linux-user/syscall_defs.h   |4 ++--
 qga/commands-posix.c|2 +-
 target-alpha/mem_helper.c   |2 +-
 target-arm/cpu.h|4 ++--
 target-cris/cpu.h   |2 +-
 target-cris/translate.c |4 ++--
 target-mips/helper.c|2 +-
 target-s390x/kvm.c  |4 ++--
 target-sh4/helper.c |6 +++---
 tcg/ia64/tcg-target.c   |2 +-
 tcg/tcg.c   |4 ++--
 tests/image-fuzzer/runner.py|2 +-
 tests/qemu-iotests/041  |2 +-
 util/qemu-thread-posix.c|2 +-
 35 files changed, 47 insertions(+), 47 deletions(-)

diff --git a/disas/i386.c b/disas/i386.c
index 00ceca9..c63d4a0 100644
--- a/disas/i386.c
+++ b/disas/i386.c
@@ -357,7 +357,7 @@ fetch_data(struct disassemble_info *info, bfd_byte *addr)
 #define Rd { OP_R, d_mode }
 #define Rm { OP_R, m_mode }
 #define Ib { OP_I, b_mode }
-#define sIb { OP_sI, b_mode }	/* sign extened byte */
+#define sIb { OP_sI, b_mode }	/* sign extended byte */
 #define Iv { OP_I, v_mode }
 #define Iq { OP_I, q_mode }
 #define Iv64 { OP_I64, v_mode }
diff --git a/disas/s390.c b/disas/s390.c
index 974460c..c29bc4e 100644
--- a/disas/s390.c
+++ b/disas/s390.c
@@ -613,7 +613,7 @@ static const struct s390_operand s390_operands[] =
   names of the instruction format that you can find in the principals
   of operation.
2) the last part of the definition (y in INSTR_x_y) gives you an idea
-  which operands the binary represenation of the instruction has.
+  which operands the binary representation of the instruction has.
   The meanings of the letters in y are:
   a - access register
   c - control register
@@ -627,7 +627,7 @@ static const struct s390_operand s390_operands[] =
   m - mode field, 4 bit
   0 - operand skipped.
   The order of the letters reflects the layout of the format in
-  storage and not the order of the paramaters of the instructions.
+  storage and not the order of the parameters of the instructions.
   The use of the letters is not a 100% match with the PoP but it is
   quite close.
 
diff --git a/docs/specs/ppc-spapr-hcalls.txt b/docs/specs/ppc-spapr-hcalls.txt
index 667b3fa..5bd8eab 100644
--- a/docs/specs/ppc-spapr-hcalls.txt
+++ b/docs/specs/ppc-spapr-hcalls.txt
@@ -41,8 +41,8 @@ When the guest runs in "real mode" (in powerpc lingua this means
 with MMU disabled, ie guest effective == guest physical), it only
 has access to a subset of memory and no IOs.
 
-PAPR provides a set of hypervisor calls to perform cachable or
-non-cachable accesses to any guest physical addresses that the
+PAPR provides a set of hypervisor calls to perform cacheable or
+non-cacheable accesses to any guest physical addresses that the
 guest can use in order to access IO devices while in real mode.
 
 This is typically used by the firmware running in the guest.
diff --git a/docs/writing-qmp-commands.txt b/docs/writing-qmp-commands.txt
index ab1fdd3..af73bf3 100644
--- a/docs/writing-qmp-commands.txt
+++ b/docs/writing-qmp-commands.txt
@@ -122,7 +122,7 @@ There are a few things to be noticed:
 Now a little hack is needed. As we're

Re: [Qemu-devel] typofixes

2015-09-08 Thread Peter Maydell 
On 8 September 2015 at 19:01, Veres Lajos  wrote:
> On Tue, 8 Sep 2015, Peter Maydell wrote:
>
>> Veres: can you drop the libvixl and linux-headers changes,
>> and at least split the remainder into docs/comments vs
>> code changes, and resend the patches to qemu-devel, please?
>
> I have removed the linux-headers/ and disas/libvixl/ changes.
> And I think the only non-comment/non-doc change is this:
> tests/qemu-iotests/041
> -def test_unexistant_replaces(self):
> +def test_unexistent_replaces(self):
>
> If you want I can move this to another patch.

OK, if there's just the one that's fine.

You forgot your signed-off-by line; we can't take the patch
without one. Also, please can you send it inline rather
than as an attachment? There are several places here which
want a better phrasing rather than just a typo fix, but
it's hard to comment on a patch provided as an attachment.

(For instance, that should be 'nonexistent', not
'unexistent' in that functionname; 'be deferring'
should be 'by deferring' in pl181.c, 'notable' should be
'notably' in various bits of decNumber.c, ...)

thanks
-- PMM

Re: [Qemu-devel] typofixes

2015-09-07 Thread Markus Armbruster 
Michael Tokarev  writes:

> 11.08.2015 00:42, Veres Lajos wrote:
>> On Sun, 9 Aug 2015, Veres Lajos wrote:
>> 
>>> Hi,
>>>
>>> Please find attached a couple of typo fixes, mostly in comments/docs.
>>> I hope it meets the trivial criteria...
>
> Now that's a bunch of typos ;)
>
> Applied everything to -trivial. Thank you!
>
> Please the next time send it to qemu-devel too,
> so that people will be able to review.

Yes.  Has a copy been sent to qemu-devel meanwhile?

Re: [Qemu-devel] typofixes

2015-09-07 Thread Markus Armbruster 
Veres Lajos  writes:

> On Mon, 7 Sep 2015, Markus Armbruster wrote:
>
>> Michael Tokarev  writes:
>>
>> > 11.08.2015 00:42, Veres Lajos wrote:
>> >> On Sun, 9 Aug 2015, Veres Lajos wrote:
>> >>
>> >>> Hi,
>> >>>
>> >>> Please find attached a couple of typo fixes, mostly in comments/docs.
>> >>> I hope it meets the trivial criteria...
>> >
>> > Now that's a bunch of typos ;)
>> >
>> > Applied everything to -trivial. Thank you!
>> >
>> > Please the next time send it to qemu-devel too,
>> > so that people will be able to review.
>>
>> Yes.  Has a copy been sent to qemu-devel meanwhile?
>
> No. Not yet. Should I send?

Yes, please.

See also
http://lists.gnu.org/archive/html/qemu-devel/2015-05/msg05887.html

Re: [Qemu-devel] typofixes

2015-09-07 Thread Veres Lajos 
On Mon, 7 Sep 2015, Markus Armbruster wrote:

> Michael Tokarev  writes:
>
> > 11.08.2015 00:42, Veres Lajos wrote:
> >> On Sun, 9 Aug 2015, Veres Lajos wrote:
> >>
> >>> Hi,
> >>>
> >>> Please find attached a couple of typo fixes, mostly in comments/docs.
> >>> I hope it meets the trivial criteria...
> >
> > Now that's a bunch of typos ;)
> >
> > Applied everything to -trivial. Thank you!
> >
> > Please the next time send it to qemu-devel too,
> > so that people will be able to review.
>
> Yes.  Has a copy been sent to qemu-devel meanwhile?

No. Not yet. Should I send?

-- 
Veres Lajos
vla...@gmail.com
+36 20 438 5909

Re: [Qemu-devel] typofixes

2015-09-07 Thread Veres Lajos 
Hi,

Please find attached a couple of typo fixes, mostly in comments/docs.
(Please cc me directly, I am not on the list.)

Best regards,
-- 
Lajos Veres
vla...@gmail.com
0792 7460 778From 56d869ab666a51106eefa398ed404f4272b4db8b Mon Sep 17 00:00:00 2001
From: Veres Lajos 
Date: Fri, 7 Aug 2015 23:05:21 +0100
Subject: [PATCH] typofix - https://github.com/vlajos/misspell_fixer

---
 disas/i386.c |2 +-
 disas/libvixl/a64/constants-a64.h|2 +-
 disas/s390.c |4 ++--
 docs/specs/ppc-spapr-hcalls.txt  |4 ++--
 docs/writing-qmp-commands.txt|2 +-
 hw/audio/fmopl.c |2 +-
 hw/core/qdev.c   |2 +-
 hw/cris/axis_dev88.c |2 +-
 hw/display/qxl-render.c  |2 +-
 hw/dma/xilinx_axidma.c   |2 +-
 hw/input/stellaris_input.c   |2 +-
 hw/intc/xics.c   |2 +-
 hw/net/fsl_etsec/etsec.c |2 +-
 hw/sd/pl181.c|2 +-
 hw/vfio/pci.c|2 +-
 hw/xen/xen-host-pci-device.c |2 +-
 include/block/scsi.h |2 +-
 include/exec/memory.h|2 +-
 libcacard/card_7816t.h   |2 +-
 libdecnumber/decContext.c|2 +-
 libdecnumber/decNumber.c |8 
 linux-headers/asm-powerpc/epapr_hcalls.h |4 ++--
 linux-user/syscall.c |2 +-
 linux-user/syscall_defs.h|4 ++--
 qga/commands-posix.c |2 +-
 target-alpha/mem_helper.c|2 +-
 target-arm/cpu.h |4 ++--
 target-cris/cpu.h|2 +-
 target-cris/translate.c  |4 ++--
 target-mips/helper.c |2 +-
 target-s390x/kvm.c   |4 ++--
 target-sh4/helper.c  |6 +++---
 tcg/ia64/tcg-target.c|2 +-
 tcg/tcg.c|4 ++--
 tests/image-fuzzer/runner.py |2 +-
 tests/qemu-iotests/041   |2 +-
 util/qemu-thread-posix.c |2 +-
 37 files changed, 50 insertions(+), 50 deletions(-)

diff --git a/disas/i386.c b/disas/i386.c
index 00ceca9..c63d4a0 100644
--- a/disas/i386.c
+++ b/disas/i386.c
@@ -357,7 +357,7 @@ fetch_data(struct disassemble_info *info, bfd_byte *addr)
 #define Rd { OP_R, d_mode }
 #define Rm { OP_R, m_mode }
 #define Ib { OP_I, b_mode }
-#define sIb { OP_sI, b_mode }	/* sign extened byte */
+#define sIb { OP_sI, b_mode }	/* sign extended byte */
 #define Iv { OP_I, v_mode }
 #define Iq { OP_I, q_mode }
 #define Iv64 { OP_I64, v_mode }
diff --git a/disas/libvixl/a64/constants-a64.h b/disas/libvixl/a64/constants-a64.h
index bc1a2c4..dc984a3 100644
--- a/disas/libvixl/a64/constants-a64.h
+++ b/disas/libvixl/a64/constants-a64.h
@@ -64,7 +64,7 @@ V_(ImmDPShift, 15, 10, Bits)   \
 V_(ImmAddSub, 21, 10, Bits)\
 V_(ShiftAddSub, 23, 22, Bits)  \
\
-/* Add/substract extend */ \
+/* Add/subtract extend */ \
 V_(ImmExtendShift, 12, 10, Bits)   \
 V_(ExtendMode, 15, 13, Bits)   \
\
diff --git a/disas/s390.c b/disas/s390.c
index 974460c..c29bc4e 100644
--- a/disas/s390.c
+++ b/disas/s390.c
@@ -613,7 +613,7 @@ static const struct s390_operand s390_operands[] =
   names of the instruction format that you can find in the principals
   of operation.
2) the last part of the definition (y in INSTR_x_y) gives you an idea
-  which operands the binary represenation of the instruction has.
+  which operands the binary representation of the instruction has.
   The meanings of the letters in y are:
   a - access register
   c - control register
@@ -627,7 +627,7 @@ static const struct s390_operand s390_operands[] =
   m - mode field, 4 bit
   0 - operand skipped.
   The order of the letters reflects the layout of the format in
-  storage and not the order of the paramaters of the instructions.
+  storage and not the order of the parameters of the instructions.
   The use of the letters is not a 100% match with the PoP but it is
   quite close.
 
diff --git a/docs/specs/ppc-spapr-hcalls.txt b/docs/specs/ppc-spapr-hcalls.txt
index 667b3fa..5bd8eab 100644
---

Re: [Qemu-devel] typofixes

2015-09-06 Thread Michael Tokarev 
11.08.2015 00:42, Veres Lajos wrote:
> On Sun, 9 Aug 2015, Veres Lajos wrote:
> 
>> Hi,
>>
>> Please find attached a couple of typo fixes, mostly in comments/docs.
>> I hope it meets the trivial criteria...

Now that's a bunch of typos ;)

Applied everything to -trivial. Thank you!

Please the next time send it to qemu-devel too,
so that people will be able to review.

/mjt