Re: [RFC PATCH 1/8] fpu/softfloat: fix up float16 nan recognition

[Alex Bennée]

LIU Zhiwei  writes:

> Signed-off-by: LIU Zhiwei 

Queued to misc/for-5.1-rc0, thanks.

-- 
Alex Bennée

Re: [RFC PATCH 1/8] fpu/softfloat: fix up float16 nan recognition

[Richard Henderson]

On 7/12/20 4:45 PM, LIU Zhiwei wrote:
> Signed-off-by: LIU Zhiwei 
> ---
>  fpu/softfloat-specialize.inc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson 

This one should go into 5.1.  Are you collecting, Alex?


r~

[RFC PATCH 1/8] fpu/softfloat: fix up float16 nan recognition

[LIU Zhiwei]

Signed-off-by: LIU Zhiwei 
---
 fpu/softfloat-specialize.inc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fpu/softfloat-specialize.inc.c b/fpu/softfloat-specialize.inc.c
index 44f5b661f8..034d18199c 100644
--- a/fpu/softfloat-specialize.inc.c
+++ b/fpu/softfloat-specialize.inc.c
@@ -254,7 +254,7 @@ bool float16_is_quiet_nan(float16 a_, float_status *status)
 if (snan_bit_is_one(status)) {
 return (((a >> 9) & 0x3F) == 0x3E) && (a & 0x1FF);
 } else {
-return ((a & ~0x8000) >= 0x7C80);
+return ((a >> 9) & 0x3F) == 0x3F;
 }
 #endif
 }
@@ -271,7 +271,7 @@ bool float16_is_signaling_nan(float16 a_, float_status 
*status)
 #else
 uint16_t a = float16_val(a_);
 if (snan_bit_is_one(status)) {
-return ((a & ~0x8000) >= 0x7C80);
+return ((a >> 9) & 0x3F) == 0x3F;
 } else {
 return (((a >> 9) & 0x3F) == 0x3E) && (a & 0x1FF);
 }
-- 
2.23.0