Re: [PATCH v3 0/2] Fix coverity issues for AST2700
On 6/25/24 9:07 AM, Jamin Lin wrote: change from v1: aspeed/soc: coverity defect: DIVIDE_BY_ZERO aspeed/sdmc: coverity defect: Control flow issues (DEADCODE) change from v2: add more commit log from reviewer suggestion, Cédric. change from v3: replace qemu_log_mask with assert dram size 0. Jamin Lin (2): aspeed/soc: Fix possible divide by zero aspeed/sdmc: Remove extra R_MAIN_STATUS case hw/arm/aspeed_ast27x0.c | 2 ++ hw/misc/aspeed_sdmc.c | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) Applied to aspeed-next. Thanks, C.
RE: [PATCH v3 0/2] Fix coverity issues for AST2700
Hi Cedric, > -Original Message- > From: Cédric Le Goater > Sent: Tuesday, June 25, 2024 3:22 PM > To: Jamin Lin ; Peter Maydell > ; Steven Lee ; Troy > Lee ; Andrew Jeffery ; > Joel Stanley ; open list:ASPEED BMCs > ; open list:All patches CC here > > Subject: Re: [PATCH v3 0/2] Fix coverity issues for AST2700 > > Hello Jamin > > On 6/25/24 9:07 AM, Jamin Lin wrote: > > change from v1: > > aspeed/soc: coverity defect: DIVIDE_BY_ZERO > > aspeed/sdmc: coverity defect: Control flow issues (DEADCODE) > > > > change from v2: > > add more commit log from reviewer suggestion, Cédric. > > > > change from v3: > > replace qemu_log_mask with assert dram size 0. > > > > Jamin Lin (2): > >aspeed/soc: Fix possible divide by zero > >aspeed/sdmc: Remove extra R_MAIN_STATUS case > > > > hw/arm/aspeed_ast27x0.c | 2 ++ > > hw/misc/aspeed_sdmc.c | 1 - > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > LGTM. > > Could you please review : > Done. Thanks-Jamin > https://lore.kernel.org/qemu-devel/20240625065839.485034-1-...@redhat.co > m/T/#u > > Thanks, > > C. >
Re: [PATCH v3 0/2] Fix coverity issues for AST2700
Hello Jamin On 6/25/24 9:07 AM, Jamin Lin wrote: change from v1: aspeed/soc: coverity defect: DIVIDE_BY_ZERO aspeed/sdmc: coverity defect: Control flow issues (DEADCODE) change from v2: add more commit log from reviewer suggestion, Cédric. change from v3: replace qemu_log_mask with assert dram size 0. Jamin Lin (2): aspeed/soc: Fix possible divide by zero aspeed/sdmc: Remove extra R_MAIN_STATUS case hw/arm/aspeed_ast27x0.c | 2 ++ hw/misc/aspeed_sdmc.c | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) LGTM. Could you please review : https://lore.kernel.org/qemu-devel/20240625065839.485034-1-...@redhat.com/T/#u Thanks, C.
