RE: [Qemu-devel] [PATCH]Fix for minor video corruption under Windows
Fabrice- Well, I've been assuming that the Windows driver doesn't call the BIOS to do a video mode switch (that seems like a silly thing to do and without sources I hate having to guess at things) but this is Windows so I guess it's possible. If you've got a BIOS patch I'd love to try it out when you're ready. -- Don Dugger Censeo Toto nos in Kansa esse decisse. - D. Gale [EMAIL PROTECTED] Ph: (303)440-1368 -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] ] On Behalf Of Fabrice Bellard Sent: Thursday, May 11, 2006 4:48 PM To: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH]Fix for minor video corruption under Windows Hi, I think the proper fix must be done in the BIOS (set VRAM to 0xFF at cirrus mode init). I made a patch for that but I must test it a little more. Fabrice. Dugger, Donald D wrote: Leo- Yeah, I started there but it turns out there are multiple reasons why that is the wrong place to fix things: 1) `hw/vga.c' only knows about resolution changes, the bug also appears if you change the pixel size, e.g. 24 bpp to 16 bpp. 2) Technically, because of the lazy screen update, your change would be too late. To improve performance the vga code is only called periodically, not after every VRAM change. It is theoretically possible for the target to change video mode, assume VRAM got reset, do a bitblt from non-visible VRAM to visible VRAM and then have the `hw/vga.c' code get called, overwriting the changes done to visible VRAM. -- Don Dugger Censeo Toto nos in Kansa esse decisse. - D. Gale [EMAIL PROTECTED] Ph: (303)440-1368 -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] ] On Behalf Of Leonardo E. Reiter Sent: Tuesday, May 09, 2006 2:29 PM To: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH]Fix for minor video corruption under Windows Donald... thanks... I actually posted a patch to fix this sometime ago, but your patch seems more thorough and probably more correct. Just FYI, I attached my patch again. I will test your patch as well. Thanks again, Leo Reiter Donald D. Dugger wrote: If you change the video resolution while running a Windows XP image such that it uses fewer bytes of VRAM (either by using fewer bytes per pixel or by lowering the resolution) then some window backgrounds will become corrupted. This happens because the Windows XP Cirrus Logic driver assumes that VRAM is initialized to 0xff whenever the video mode switches between VGA and SVGA. This patch fixes this problem by resetting VRAM whenever a VGA/SVGA mode switch occurs. Signed-off-by: [EMAIL PROTECTED] -- Leonardo E. Reiter Vice President of Product Development, CTO Win4Lin, Inc. Virtual Computing that means Business Main: +1 512 339 7979 Fax: +1 512 532 6501 http://www.win4lin.com ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
Re: [Qemu-devel] [PATCH]Fix for minor video corruption under Windows
I tried out this patch (with CVS, after fixing it) with XP SP2 and 2k3 SP1. It did address the corruption when changing bpp or resolution, but paints the screen white while the UI elements repaint themselves. Just a little disturbing, but I'll get used to it. Also, I had the leave the second chunk in, otherwise XP failed to paint much of the screen upon bootup. Index: hw/cirrus_vga.c === RCS file: /sources/qemu/qemu/hw/cirrus_vga.c,v retrieving revision 1.21 diff -u -r1.21 cirrus_vga.c --- hw/cirrus_vga.c 30 Apr 2006 21:28:36 - 1.21 +++ hw/cirrus_vga.c 10 May 2006 14:08:25 - @@ -1181,6 +1181,17 @@ break; case 0x05: // ??? case 0x07: // Extended Sequencer Mode + /* Win2K seems to assume that the VRAM is set to 0xff +* whenever VGA/SVGA mode changes +*/ +if ((s-sr[0x07] ^ *reg_value) CIRRUS_SR7_BPP_SVGA) +memset(s-vram_ptr, 0xff, s-real_vram_size); +*reg_value = s-sr[0x07]; +#ifdef DEBUG_CIRRUS +printf(cirrus: handled outport sr_index %02x, sr_value %02x\n, + reg_index, reg_value); +#endif +break; case 0x08: // EEPROM Control case 0x09: // Scratch Register 0 case 0x0a: // Scratch Register 1 WD -- ReactOS is a hub, follow the spokes and you'll immediately find absolutely everything you need to know about Windows. ReactOS is not just software, it's people. kjk_hyperion ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
RE: [Qemu-devel] [PATCH]Fix for minor video corruption under Windows
WD- I see the problem here, `patch' got confused because my patch was against a 0.8.0 tree and you applied it to a 0.8.1 tree. You wound up making the change to `cirrus_hook_read_sr', where the Windows driver attempts to read the mode register. The patch is supposed to apply to the routine `cirrus_hook_write_sr', where the video mode is set. I've attached a version of the patch that should apply cleanly against the 0.8.1 tree. (Sorry about the attachment, IT policies force me to use a broken mailer and I can only reply to you with an attachment.) -- Don Dugger Censeo Toto nos in Kansa esse decisse. - D. Gale [EMAIL PROTECTED] Ph: (303)440-1368 -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] ] On Behalf Of WaxDragon Sent: Wednesday, May 10, 2006 8:27 AM To: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH]Fix for minor video corruption under Windows I tried out this patch (with CVS, after fixing it) with XP SP2 and 2k3 SP1. It did address the corruption when changing bpp or resolution, but paints the screen white while the UI elements repaint themselves. Just a little disturbing, but I'll get used to it. Also, I had the leave the second chunk in, otherwise XP failed to paint much of the screen upon bootup. Index: hw/cirrus_vga.c === RCS file: /sources/qemu/qemu/hw/cirrus_vga.c,v retrieving revision 1.21 diff -u -r1.21 cirrus_vga.c --- hw/cirrus_vga.c 30 Apr 2006 21:28:36 - 1.21 +++ hw/cirrus_vga.c 10 May 2006 14:08:25 - @@ -1181,6 +1181,17 @@ break; case 0x05: // ??? case 0x07: // Extended Sequencer Mode + /* Win2K seems to assume that the VRAM is set to 0xff +* whenever VGA/SVGA mode changes +*/ +if ((s-sr[0x07] ^ *reg_value) CIRRUS_SR7_BPP_SVGA) +memset(s-vram_ptr, 0xff, s-real_vram_size); +*reg_value = s-sr[0x07]; +#ifdef DEBUG_CIRRUS +printf(cirrus: handled outport sr_index %02x, sr_value %02x\n, + reg_index, reg_value); +#endif +break; case 0x08: // EEPROM Control case 0x09: // Scratch Register 0 case 0x0a: // Scratch Register 1 WD -- ReactOS is a hub, follow the spokes and you'll immediately find absolutely everything you need to know about Windows. ReactOS is not just software, it's people. kjk_hyperion ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel patch-cirrus-0510.l Description: patch-cirrus-0510.l ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
Re: [Qemu-devel] [PATCH]Fix for minor video corruption under Windows
Donald...
thanks... I actually posted a patch to fix this sometime ago, but your
patch seems more thorough and probably more correct. Just FYI, I
attached my patch again. I will test your patch as well.
Thanks again,
Leo Reiter
Donald D. Dugger wrote:
If you change the video resolution while running a Windows XP image such that
it uses fewer bytes of VRAM (either by using fewer bytes per pixel or by
lowering the resolution) then some window backgrounds will become corrupted.
This happens because the Windows XP Cirrus Logic driver assumes that VRAM is
initialized to 0xff whenever the video mode switches between VGA and SVGA.
This patch fixes this problem by resetting VRAM whenever a VGA/SVGA mode switch
occurs.
Signed-off-by: [EMAIL PROTECTED]
--
Leonardo E. Reiter
Vice President of Product Development, CTO
Win4Lin, Inc.
Virtual Computing that means Business
Main: +1 512 339 7979
Fax: +1 512 532 6501
http://www.win4lin.com
Index: hw/vga.c
===
RCS file: /cvsroot/qemu/qemu/hw/vga.c,v
retrieving revision 1.42
diff -a -u -r1.42 vga.c
--- hw/vga.c 9 Apr 2006 01:06:34 - 1.42
+++ hw/vga.c 12 Apr 2006 14:53:06 -
@@ -1366,6 +1366,8 @@
if (disp_width != s-last_width ||
height != s-last_height) {
+if (cirrus_vga_enabled s-get_bpp(s) = 8)
+memset(s-vram_ptr, 0xff, s-vram_size);
dpy_resize(s-ds, disp_width, height);
s-last_scr_width = disp_width;
s-last_scr_height = height;
___
Qemu-devel mailing list
Qemu-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/qemu-devel
RE: [Qemu-devel] [PATCH]Fix for minor video corruption under Windows
Leo- Yeah, I started there but it turns out there are multiple reasons why that is the wrong place to fix things: 1) `hw/vga.c' only knows about resolution changes, the bug also appears if you change the pixel size, e.g. 24 bpp to 16 bpp. 2) Technically, because of the lazy screen update, your change would be too late. To improve performance the vga code is only called periodically, not after every VRAM change. It is theoretically possible for the target to change video mode, assume VRAM got reset, do a bitblt from non-visible VRAM to visible VRAM and then have the `hw/vga.c' code get called, overwriting the changes done to visible VRAM. -- Don Dugger Censeo Toto nos in Kansa esse decisse. - D. Gale [EMAIL PROTECTED] Ph: (303)440-1368 -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] ] On Behalf Of Leonardo E. Reiter Sent: Tuesday, May 09, 2006 2:29 PM To: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH]Fix for minor video corruption under Windows Donald... thanks... I actually posted a patch to fix this sometime ago, but your patch seems more thorough and probably more correct. Just FYI, I attached my patch again. I will test your patch as well. Thanks again, Leo Reiter Donald D. Dugger wrote: If you change the video resolution while running a Windows XP image such that it uses fewer bytes of VRAM (either by using fewer bytes per pixel or by lowering the resolution) then some window backgrounds will become corrupted. This happens because the Windows XP Cirrus Logic driver assumes that VRAM is initialized to 0xff whenever the video mode switches between VGA and SVGA. This patch fixes this problem by resetting VRAM whenever a VGA/SVGA mode switch occurs. Signed-off-by: [EMAIL PROTECTED] -- Leonardo E. Reiter Vice President of Product Development, CTO Win4Lin, Inc. Virtual Computing that means Business Main: +1 512 339 7979 Fax: +1 512 532 6501 http://www.win4lin.com ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
