Re: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros

[Philippe Mathieu-Daudé]

On 9/30/20 11:22 PM, Taylor Simpson wrote:
>> -Original Message-
>> From: Philippe Mathieu-Daudé  On
>> Behalf Of Philippe Mathieu-Daudé
>> Sent: Tuesday, September 29, 2020 6:34 AM
>> To: Taylor Simpson ; qemu-devel@nongnu.org
>> Cc: richard.hender...@linaro.org; laur...@vivier.eu; riku.voi...@iki.fi;
>> aleksandar.m.m...@gmail.com; a...@rev.ng
>> Subject: Re: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros
>>
>> On 9/28/20 7:28 PM, Taylor Simpson wrote:
>>> macros to interface with the generator
>>> macros referenced in instruction semantics
>>>
>>> +#ifndef HEXAGON_MACROS_H
>>> +#define HEXAGON_MACROS_H
>>> +
>>> +#include "qemu/osdep.h"
>>
>> Please do not include "qemu/osdep.h" in header.
>>
>>> +#include "qemu/host-utils.h"
>>
>> "qemu/host-utils.h" doesn't seem used.
>>
>>> +#include "cpu.h"
>>> +#include "hex_regs.h"
>>> +#include "reg_fields.h"
>>> +
>> [...]
> 
> To clarify, does the "[...]" mean I should remove all the includes (and 
> include them in the .c files that include this header file)?

No! No further comment on the rest of this patch, so to avoid you
looking for any comment, I simply stripped the rest. ;)

> 
> Thanks,
> Taylor
> 
> 

RE: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros

[Taylor Simpson]

> -Original Message-
> From: Philippe Mathieu-Daudé  On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, September 29, 2020 6:34 AM
> To: Taylor Simpson ; qemu-devel@nongnu.org
> Cc: richard.hender...@linaro.org; laur...@vivier.eu; riku.voi...@iki.fi;
> aleksandar.m.m...@gmail.com; a...@rev.ng
> Subject: Re: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros
>
> On 9/28/20 7:28 PM, Taylor Simpson wrote:
> > macros to interface with the generator
> > macros referenced in instruction semantics
> >
> > +#ifndef HEXAGON_MACROS_H
> > +#define HEXAGON_MACROS_H
> > +
> > +#include "qemu/osdep.h"
>
> Please do not include "qemu/osdep.h" in header.
>
> > +#include "qemu/host-utils.h"
>
> "qemu/host-utils.h" doesn't seem used.
>
> > +#include "cpu.h"
> > +#include "hex_regs.h"
> > +#include "reg_fields.h"
> > +
> [...]

To clarify, does the "[...]" mean I should remove all the includes (and include 
them in the .c files that include this header file)?

Thanks,
Taylor

Re: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros

[Philippe Mathieu-Daudé]

On 9/28/20 7:28 PM, Taylor Simpson wrote:
> macros to interface with the generator
> macros referenced in instruction semantics
> 
> Signed-off-by: Taylor Simpson 
> ---
>  target/hexagon/macros.h | 654 
> 
>  1 file changed, 654 insertions(+)
>  create mode 100644 target/hexagon/macros.h
> 
> diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h
> new file mode 100644
> index 000..34831d4
> --- /dev/null
> +++ b/target/hexagon/macros.h
> @@ -0,0 +1,654 @@
> +/*
> + *  Copyright(c) 2019-2020 Qualcomm Innovation Center, Inc. All Rights 
> Reserved.
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License as published by
> + *  the Free Software Foundation; either version 2 of the License, or
> + *  (at your option) any later version.
> + *
> + *  This program is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *  GNU General Public License for more details.
> + *
> + *  You should have received a copy of the GNU General Public License
> + *  along with this program; if not, see .
> + */
> +
> +#ifndef HEXAGON_MACROS_H
> +#define HEXAGON_MACROS_H
> +
> +#include "qemu/osdep.h"

Please do not include "qemu/osdep.h" in header.

> +#include "qemu/host-utils.h"

"qemu/host-utils.h" doesn't seem used.

> +#include "cpu.h"
> +#include "hex_regs.h"
> +#include "reg_fields.h"
> +
[...]