Re: [PATCH 0/7] s390x/ccw: Error reporting cleanups

2024-05-26 Thread Cédric Le Goater 

On 5/27/24 08:23, Thomas Huth wrote:

On 22/05/2024 19.01, Cédric Le Goater wrote:

Hello,

The first patches of this series simply apply the practices described
in the Rules section of the qapi/error.h file for routines taking an
'Error **' argument. The remaining patches are a fixup in the error
path of vfio_ccw_realize() and some error reporting adjustements.

Applies on top of this vfio PR :

   https://lore.kernel.org/qemu-devel/20240522095442.195243-1-...@redhat.com

Thanks,

C.

Cédric Le Goater (6):
   hw/s390x/ccw: Make s390_ccw_get_dev_info() return a bool
   s390x/css: Make CCWDeviceClass::realize return bool
   hw/s390x/ccw: Remove local Error variable from s390_ccw_realize()
   s390x/css: Make S390CCWDeviceClass::realize return bool
   vfio/ccw: Use the 'Error **errp' argument of vfio_ccw_realize()
   vfio/{ap,ccw}: Use warn_report_err() for IRQ notifier registration
 errors


Series
Reviewed-by: Thomas Huth 




Applied to vfio-next.

Thanks,

C.

Re: [PATCH 0/7] s390x/ccw: Error reporting cleanups

2024-05-26 Thread Thomas Huth 

On 22/05/2024 19.01, Cédric Le Goater wrote:

Hello,

The first patches of this series simply apply the practices described
in the Rules section of the qapi/error.h file for routines taking an
'Error **' argument. The remaining patches are a fixup in the error
path of vfio_ccw_realize() and some error reporting adjustements.

Applies on top of this vfio PR :

   https://lore.kernel.org/qemu-devel/20240522095442.195243-1-...@redhat.com

Thanks,

C.

Cédric Le Goater (6):
   hw/s390x/ccw: Make s390_ccw_get_dev_info() return a bool
   s390x/css: Make CCWDeviceClass::realize return bool
   hw/s390x/ccw: Remove local Error variable from s390_ccw_realize()
   s390x/css: Make S390CCWDeviceClass::realize return bool
   vfio/ccw: Use the 'Error **errp' argument of vfio_ccw_realize()
   vfio/{ap,ccw}: Use warn_report_err() for IRQ notifier registration
 errors


Series
Reviewed-by: Thomas Huth

Re: [PATCH 0/7] s390x/ccw: Error reporting cleanups

2024-05-23 Thread Eric Farman 
On Wed, 2024-05-22 at 19:01 +0200, Cédric Le Goater wrote:
> Hello,
> 
> The first patches of this series simply apply the practices described
> in the Rules section of the qapi/error.h file for routines taking an
> 'Error **' argument. The remaining patches are a fixup in the error
> path of vfio_ccw_realize() and some error reporting adjustements.
> 
> Applies on top of this vfio PR :
> 
>  
> https://lore.kernel.org/qemu-devel/20240522095442.195243-1-...@redhat.com
> 
> Thanks,
> 
> C.
> 
> Cédric Le Goater (6):
>   hw/s390x/ccw: Make s390_ccw_get_dev_info() return a bool
>   s390x/css: Make CCWDeviceClass::realize return bool
>   hw/s390x/ccw: Remove local Error variable from s390_ccw_realize()
>   s390x/css: Make S390CCWDeviceClass::realize return bool
>   vfio/ccw: Use the 'Error **errp' argument of vfio_ccw_realize()
>   vfio/{ap,ccw}: Use warn_report_err() for IRQ notifier registration
>     errors
> 
> Zhenzhong Duan (1):
>   vfio/ccw: Fix the missed unrealize() call in error path
> 
>  hw/s390x/ccw-device.h   |  2 +-
>  include/hw/s390x/s390-ccw.h |  2 +-
>  hw/s390x/ccw-device.c   |  3 ++-
>  hw/s390x/s390-ccw.c | 29 +
>  hw/vfio/ap.c    |  2 +-
>  hw/vfio/ccw.c   | 18 --
>  6 files changed, 26 insertions(+), 30 deletions(-)
> 

Reviewed-by: Eric Farman