Re: [PATCH 07/72] softfloat: Inline float_raise

2021-05-11 Thread David Hildenbrand

On 08.05.21 03:46, Richard Henderson wrote:

Signed-off-by: Richard Henderson 
---
  include/fpu/softfloat.h|  5 -
  fpu/softfloat-specialize.c.inc | 12 
  2 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h
index 78ad5ca738..019c2ec66d 100644
--- a/include/fpu/softfloat.h
+++ b/include/fpu/softfloat.h
@@ -100,7 +100,10 @@ typedef enum {
  | Routine to raise any or all of the software IEC/IEEE floating-point
  | exception flags.
  
**/
-void float_raise(uint8_t flags, float_status *status);
+static inline void float_raise(uint8_t flags, float_status *status)
+{
+status->float_exception_flags |= flags;
+}
  
  /*

  | If `a' is denormal and we are in flush-to-zero mode then set the
diff --git a/fpu/softfloat-specialize.c.inc b/fpu/softfloat-specialize.c.inc
index 9ea318f3e2..487b29155c 100644
--- a/fpu/softfloat-specialize.c.inc
+++ b/fpu/softfloat-specialize.c.inc
@@ -228,18 +228,6 @@ floatx80 floatx80_default_nan(float_status *status)
  const floatx80 floatx80_infinity
  = make_floatx80_init(floatx80_infinity_high, floatx80_infinity_low);
  
-/*

-| Raises the exceptions specified by `flags'.  Floating-point traps can be
-| defined here if desired.  It is currently not possible for such a trap
-| to substitute a result value.  If traps are not implemented, this routine
-| should be simply `float_exception_flags |= flags;'.
-**/
-
-void float_raise(uint8_t flags, float_status *status)
-{
-status->float_exception_flags |= flags;
-}
-
  /*
  | Internal canonical NaN format.
  
**/



Reviewed-by: David Hildenbrand 

--
Thanks,

David / dhildenb




Re: [PATCH 07/72] softfloat: Inline float_raise

2021-05-09 Thread Philippe Mathieu-Daudé
On 5/8/21 3:46 AM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson 
> ---
>  include/fpu/softfloat.h|  5 -
>  fpu/softfloat-specialize.c.inc | 12 
>  2 files changed, 4 insertions(+), 13 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé