Re: [PATCH 1/5] target/mips: Remove duplicated check_cp0_enabled() calls in gen_cp0()
On 4/20/21 12:34 PM, Philippe Mathieu-Daudé wrote: We already check for CP0 enabled at the beginning of gen_cp0(), no need to check it again after. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 2 -- 1 file changed, 2 deletions(-) Having noticed the default case for the nanomips decode, I do wonder if having the cp0 check happen before the switch in gen_cp0 is actually correct. r~
Re: [PATCH 1/5] target/mips: Remove duplicated check_cp0_enabled() calls in gen_cp0()
On 4/20/21 12:34 PM, Philippe Mathieu-Daudé wrote: We already check for CP0 enabled at the beginning of gen_cp0(), no need to check it again after. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 2 -- 1 file changed, 2 deletions(-) Reviewed-by: Richard Henderson r~
