Re: [PATCH 4/8] meson: drop the .fa library suffix
On 2/23/22 10:14, Marc-André Lureau wrote:
Hi
On Wed, Feb 23, 2022 at 1:08 PM Paolo Bonzini wrote:
On 2/22/22 20:40, marcandre.lur...@redhat.com wrote:
The .fa suffix was a temporary hack introduced in commit
1f0a1d8a51 ("build-sys hack: link with whole .fa archives") when the
build system was mixed between meson & makefiles. It is no longer
needed.
It is still needed to separate internal and system archives, otherwise
the oss-fuzz build fails. Meson adds a --start-group/--end-group pair
Ah, but gitlab oss-fuzz build passed
https://gitlab.com/marcandre.lureau/qemu/-/pipelines/476763089
Alexander, do you remember how to reproduce this?
around all libraries, and the fork-fuzz.ld linker script should be
outside it. If the libraries are named .a, the --start-group is placed
much earlier.
This is of course a very ugly workaround; Meson should just use the
objects instead of the archives when link_whole is used with an internal
convenience archive.
Any meson github issue we can point to?
#9292 maybe, I'm not sure if there's anything better.
Paolo
Re: [PATCH 4/8] meson: drop the .fa library suffix
Hi
On Wed, Feb 23, 2022 at 1:08 PM Paolo Bonzini wrote:
>
> On 2/22/22 20:40, marcandre.lur...@redhat.com wrote:
> >
> > The .fa suffix was a temporary hack introduced in commit
> > 1f0a1d8a51 ("build-sys hack: link with whole .fa archives") when the
> > build system was mixed between meson & makefiles. It is no longer
> > needed.
>
> It is still needed to separate internal and system archives, otherwise
> the oss-fuzz build fails. Meson adds a --start-group/--end-group pair
Ah, but gitlab oss-fuzz build passed
https://gitlab.com/marcandre.lureau/qemu/-/pipelines/476763089
> around all libraries, and the fork-fuzz.ld linker script should be
> outside it. If the libraries are named .a, the --start-group is placed
> much earlier.
>
> This is of course a very ugly workaround; Meson should just use the
> objects instead of the archives when link_whole is used with an internal
> convenience archive.
Any meson github issue we can point to?
Re: [PATCH 4/8] meson: drop the .fa library suffix
On 2/22/22 20:40, marcandre.lur...@redhat.com wrote:
The .fa suffix was a temporary hack introduced in commit
1f0a1d8a51 ("build-sys hack: link with whole .fa archives") when the
build system was mixed between meson & makefiles. It is no longer
needed.
It is still needed to separate internal and system archives, otherwise
the oss-fuzz build fails. Meson adds a --start-group/--end-group pair
around all libraries, and the fork-fuzz.ld linker script should be
outside it. If the libraries are named .a, the --start-group is placed
much earlier.
This is of course a very ugly workaround; Meson should just use the
objects instead of the archives when link_whole is used with an internal
convenience archive.
Paolo
