Re: [PATCH for-9.1 17/19] target/i386: decode x87 instructions in a separate function

2024-04-11 Thread Richard Henderson 

On 4/9/24 09:43, Paolo Bonzini wrote:

These are unlikely to be converted to the table-based decoding
soon (perhaps there could be generic ESC decoding in decode-new.c.inc
for the Mod/RM byte, but not operand decoding), so keep them separate
from the remaining legacy-decoded instructions.

Signed-off-by: Paolo Bonzini
---
  target/i386/tcg/translate.c | 1120 ++-
  1 file changed, 566 insertions(+), 554 deletions(-)


Acked-by: Richard Henderson 

r~

Re: [PATCH for-9.1 17/19] target/i386: decode x87 instructions in a separate function

2024-04-09 Thread Philippe Mathieu-Daudé 

On 9/4/24 18:43, Paolo Bonzini wrote:

These are unlikely to be converted to the table-based decoding
soon (perhaps there could be generic ESC decoding in decode-new.c.inc
for the Mod/RM byte, but not operand decoding), so keep them separate
from the remaining legacy-decoded instructions.

Signed-off-by: Paolo Bonzini 
---
  target/i386/tcg/translate.c | 1120 ++-
  1 file changed, 566 insertions(+), 554 deletions(-)


Reviewed with 'git-diff --color-moved=dimmed-zebra
--color-moved-ws=allow-indentation-change'.

Reviewed-by: Philippe Mathieu-Daudé