Re: [PATCH for-9.1 18/19] target/i386: split legacy decoder into a separate function

2024-04-11 Thread Richard Henderson 

On 4/9/24 09:43, Paolo Bonzini wrote:

Split the bits that have some duplication with disas_insn_new, from
those that should be the main topic of the conversion.  This is the
first step towards removing duplicate decoding of prefixes between
disas_insn and disas_insn_new.

Signed-off-by: Paolo Bonzini
---
  target/i386/tcg/translate.c | 58 +++--
  1 file changed, 37 insertions(+), 21 deletions(-)


Reviewed-by: Richard Henderson 

r~

Re: [PATCH for-9.1 18/19] target/i386: split legacy decoder into a separate function

2024-04-09 Thread Philippe Mathieu-Daudé 

On 9/4/24 18:43, Paolo Bonzini wrote:

Split the bits that have some duplication with disas_insn_new, from
those that should be the main topic of the conversion.  This is the
first step towards removing duplicate decoding of prefixes between
disas_insn and disas_insn_new.

Signed-off-by: Paolo Bonzini 
---
  target/i386/tcg/translate.c | 58 +++--
  1 file changed, 37 insertions(+), 21 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé