Re: [PATCH v16 Kernel 2/7] vfio iommu: Remove atomicity of ref_count of pinned pages

2020-03-26 Thread Kirti Wankhede 




On 3/26/2020 4:19 PM, Cornelia Huck wrote:

On Wed, 25 Mar 2020 01:02:34 +0530
Kirti Wankhede  wrote:


vfio_pfn.ref_count is always updated by holding iommu->lock, using atomic


s/by/while/



Ok.


variable is overkill.

Signed-off-by: Kirti Wankhede 
Reviewed-by: Neo Jia 
Reviewed-by: Eric Auger 
---
  drivers/vfio/vfio_iommu_type1.c | 9 +
  1 file changed, 5 insertions(+), 4 deletions(-)



Reviewed-by: Cornelia Huck 



Thanks,
Kirti

Re: [PATCH v16 Kernel 2/7] vfio iommu: Remove atomicity of ref_count of pinned pages

2020-03-26 Thread Cornelia Huck 
On Wed, 25 Mar 2020 01:02:34 +0530
Kirti Wankhede  wrote:

> vfio_pfn.ref_count is always updated by holding iommu->lock, using atomic

s/by/while/

> variable is overkill.
> 
> Signed-off-by: Kirti Wankhede 
> Reviewed-by: Neo Jia 
> Reviewed-by: Eric Auger 
> ---
>  drivers/vfio/vfio_iommu_type1.c | 9 +
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 

Reviewed-by: Cornelia Huck