Re: [PATCH v2] i386: Deprecate the -no-hpet QEMU command line option

2022-12-30 Thread Philippe Mathieu-Daudé

On 29/12/22 12:49, Thomas Huth wrote:

The HPET setting has been turned into a machine property a while ago
already, so we should finally do the next step and deprecate the
legacy CLI option, too.

Signed-off-by: Thomas Huth 
---
  v2:
  - Rebased to current version from master branch / adjusted version info
  - Dropped the descrpition in hw/i386/pc.c (already done via another patch)

  Note: The "hpet" property should now show up in the output of the
  "query-command-line-options" QMP command since commit 2f129fc107b4a, so
  it should be feasible for libvirt now to properly probe for the property .

  docs/about/deprecated.rst | 6 ++
  softmmu/vl.c  | 1 +
  qemu-options.hx   | 2 +-
  3 files changed, 8 insertions(+), 1 deletion(-)


Reviewed-by: Philippe Mathieu-Daudé 




Re: [PATCH v2] i386: Deprecate the -no-hpet QEMU command line option

2023-01-03 Thread Peter Krempa
On Thu, Dec 29, 2022 at 12:49:13 +0100, Thomas Huth wrote:
> The HPET setting has been turned into a machine property a while ago
> already, so we should finally do the next step and deprecate the
> legacy CLI option, too.
> 
> Signed-off-by: Thomas Huth 
> ---
>  v2:
>  - Rebased to current version from master branch / adjusted version info
>  - Dropped the descrpition in hw/i386/pc.c (already done via another patch)
> 
>  Note: The "hpet" property should now show up in the output of the
>  "query-command-line-options" QMP command since commit 2f129fc107b4a, so
>  it should be feasible for libvirt now to properly probe for the property .
> 
>  docs/about/deprecated.rst | 6 ++
>  softmmu/vl.c  | 1 +
>  qemu-options.hx   | 2 +-
>  3 files changed, 8 insertions(+), 1 deletion(-)

Libvirt currently still uses '-no-hpet' but adapting to configure it via
machine should be straightforward. I'll post the patches soon hopefully.




Re: [PATCH v2] i386: Deprecate the -no-hpet QEMU command line option

2023-01-03 Thread Ján Tomko

On a Thursday in 2022, Thomas Huth wrote:

The HPET setting has been turned into a machine property a while ago
already, so we should finally do the next step and deprecate the
legacy CLI option, too.

Signed-off-by: Thomas Huth 
---
v2:
- Rebased to current version from master branch / adjusted version info
- Dropped the descrpition in hw/i386/pc.c (already done via another patch)

Note: The "hpet" property should now show up in the output of the
"query-command-line-options" QMP command since commit 2f129fc107b4a, so
it should be feasible for libvirt now to properly probe for the property .

docs/about/deprecated.rst | 6 ++
softmmu/vl.c  | 1 +
qemu-options.hx   | 2 +-
3 files changed, 8 insertions(+), 1 deletion(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature