Re: [PATCH v2 0/2] Fix MAP_SYNC support when host has older glibc version
On Sun, Mar 15, 2020 at 11:46:04AM -0400, Eduardo Habkost wrote: > On Sat, Mar 14, 2020 at 10:39:11AM +0100, Paolo Bonzini wrote: > > On 12/03/20 00:23, Eduardo Habkost wrote: > > > Changes v1 -> v2: > > > * Use -isystem for $PWD/linux-headers too > > > Reported-by: "Michael S. Tsirkin" > > > > > > This is an alternative to the patch submitted at: > > > > > > From: Jingqi Liu > > > Subject: [PATCH] util: fix to get configuration macros in > > > util/mmap-alloc.c > > > Date: Thu, 5 Mar 2020 23:41:42 +0800 > > > Message-Id: <20200305154142.63070-1-jingqi@intel.com> > > > > > > Before moving the osdep.h include to the top of the file, we had > > > to address warnings triggered when was included > > > after (done in patch 1/2). > > > > > > Eduardo Habkost (2): > > > Use -isystem for linux-headers dir > > > mmap-alloc: Include osdep.h before checking CONFIG_LINUX > > > > > > Makefile.target | 2 +- > > > configure | 2 +- > > > util/mmap-alloc.c | 7 +++ > > > 3 files changed, 5 insertions(+), 6 deletions(-) > > > > > > > Queued, thanks. > > Please don't queue patch 2/2. It breaks the build on mips. I don't argue that it doesn't, but MIPS pretends to support features such as MAP_SYNC when in fact it does nothing. > -- > Eduardo
Re: [PATCH v2 0/2] Fix MAP_SYNC support when host has older glibc version
On Sat, Mar 14, 2020 at 10:39:11AM +0100, Paolo Bonzini wrote: > On 12/03/20 00:23, Eduardo Habkost wrote: > > Changes v1 -> v2: > > * Use -isystem for $PWD/linux-headers too > > Reported-by: "Michael S. Tsirkin" > > > > This is an alternative to the patch submitted at: > > > > From: Jingqi Liu > > Subject: [PATCH] util: fix to get configuration macros in > > util/mmap-alloc.c > > Date: Thu, 5 Mar 2020 23:41:42 +0800 > > Message-Id: <20200305154142.63070-1-jingqi@intel.com> > > > > Before moving the osdep.h include to the top of the file, we had > > to address warnings triggered when was included > > after (done in patch 1/2). > > > > Eduardo Habkost (2): > > Use -isystem for linux-headers dir > > mmap-alloc: Include osdep.h before checking CONFIG_LINUX > > > > Makefile.target | 2 +- > > configure | 2 +- > > util/mmap-alloc.c | 7 +++ > > 3 files changed, 5 insertions(+), 6 deletions(-) > > > > Queued, thanks. Please don't queue patch 2/2. It breaks the build on mips. -- Eduardo
Re: [PATCH v2 0/2] Fix MAP_SYNC support when host has older glibc version
On 12/03/20 00:23, Eduardo Habkost wrote: > Changes v1 -> v2: > * Use -isystem for $PWD/linux-headers too > Reported-by: "Michael S. Tsirkin" > > This is an alternative to the patch submitted at: > > From: Jingqi Liu > Subject: [PATCH] util: fix to get configuration macros in util/mmap-alloc.c > Date: Thu, 5 Mar 2020 23:41:42 +0800 > Message-Id: <20200305154142.63070-1-jingqi@intel.com> > > Before moving the osdep.h include to the top of the file, we had > to address warnings triggered when was included > after (done in patch 1/2). > > Eduardo Habkost (2): > Use -isystem for linux-headers dir > mmap-alloc: Include osdep.h before checking CONFIG_LINUX > > Makefile.target | 2 +- > configure | 2 +- > util/mmap-alloc.c | 7 +++ > 3 files changed, 5 insertions(+), 6 deletions(-) > Queued, thanks. Paolo
Re: [PATCH v2 0/2] Fix MAP_SYNC support when host has older glibc version
Patchew URL:
https://patchew.org/QEMU/20200311232342.1614944-1-ehabk...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===
PASS 1 fdc-test /x86_64/fdc/cmos
PASS 2 fdc-test /x86_64/fdc/no_media_on_start
PASS 3 fdc-test /x86_64/fdc/read_without_media
==9775==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 fdc-test /x86_64/fdc/media_change
PASS 5 fdc-test /x86_64/fdc/sense_interrupt
PASS 6 fdc-test /x86_64/fdc/relative_seek
---
PASS 32 test-opts-visitor /visitor/opts/range/beyond
PASS 33 test-opts-visitor /visitor/opts/dict/unvisited
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-coroutine -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-coroutine"
==9823==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
==9823==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top:
0x7ffda46dc000; bottom 0x7feed101; size: 0x000ed36cc000 (63676661760)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 1 test-coroutine /basic/no-dangling-access
---
PASS 11 test-aio /aio/event/wait
PASS 12 test-aio /aio/event/flush
PASS 13 test-aio /aio/event/wait/no-flush-cb
==9838==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 14 test-aio /aio/timer/schedule
PASS 15 test-aio /aio/coroutine/queue-chaining
PASS 16 test-aio /aio-gsource/flush
---
PASS 12 fdc-test /x86_64/fdc/read_no_dma_19
PASS 13 fdc-test /x86_64/fdc/fuzz-registers
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img
tests/qtest/ide-test -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="ide-test"
==9846==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 ide-test /x86_64/ide/identify
PASS 28 test-aio /aio-gsource/timer/schedule
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-aio-multithread -m=quick -k --tap < /dev/null |
./scripts/tap-driver.pl --test-name="test-aio-multithread"
==9855==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-aio-multithread /aio/multi/lifecycle
==9852==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 2 ide-test /x86_64/ide/flush
PASS 2 test-aio-multithread /aio/multi/schedule
==9872==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 3 ide-test /x86_64/ide/bmdma/simple_rw
==9883==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 3 test-aio-multithread /aio/multi/mutex/contended
PASS 4 ide-test /x86_64/ide/bmdma/trim
==9894==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 test-aio-multithread /aio/multi/mutex/handoff
PASS 5 test-aio-multithread /aio/multi/mutex/mcs
PASS 6 test-aio-multithread /aio/multi/mutex/pthread
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-throttle -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-throttle"
==9911==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-throttle /throttle/leak_bucket
PASS 2 test-throttle /throttle/compute_wait
PASS 3 test-throttle /throttle/init
---
PASS 14 test-throttle /throttle/config/max
PASS 15 test-throttle /throttle/config/iops_size
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-thread-pool -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-thread-pool"
==9915==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-thread-pool /thread-pool/submit
PASS 2 test-thread-pool /thread-pool/submit-aio
PASS 3 test-thread-pool /thread-pool/submit-co
PASS 4 test-thread-pool /thread-pool/submit-many
==9917==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 5 test-thread-pool /thread-pool/cancel
PASS 6 test-thread-pool /thread-pool/cancel-async
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 +
