Re: [PATCH v2 0/3] Virtio dmabuf improvements
On Mon, 8 Jan 2024 at 10:49, Albert Esteve wrote: > On Mon, Dec 11, 2023 at 10:48 PM Stefan Hajnoczi wrote: >> >> On Thu, 7 Dec 2023 at 09:55, Albert Esteve wrote: >> > >> > v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg1005257.html >> > v1 -> v2: >> > - Solved an unitialized uuid value on vhost-user source >> > - Changed cleanup strategy, and traverse all objects in the >> > table to remove them instead. >> >> Please update the vhost-user specification >> (docs/interop/vhost-user.rst) so people implementing front-ends and >> back-ends are aware that only the back-end that added a shared >> resource can remove it. >> >> Acked-by: Stefan Hajnoczi >> > > Will do :) > > Should I add the `Acked-by` manually to the commits or does it get > automatically picked up later? Happy New Year! When a patch series is merged then the maintainer usually (automatically) picks up trailers from the latest revision on the mailing list. Trailers from earlier revisions may not be present. When you respin the patch series then you can add trailers manually with git rebase -i by adding "x git commit --no-edit --trailer='Acked-by: Stefan Hajnoczi '" lines in between each commit in the rebase list. Stefan
Re: [PATCH v2 0/3] Virtio dmabuf improvements
On Mon, Dec 11, 2023 at 10:48 PM Stefan Hajnoczi wrote: > On Thu, 7 Dec 2023 at 09:55, Albert Esteve wrote: > > > > v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg1005257.html > > v1 -> v2: > > - Solved an unitialized uuid value on vhost-user source > > - Changed cleanup strategy, and traverse all objects in the > > table to remove them instead. > > Please update the vhost-user specification > (docs/interop/vhost-user.rst) so people implementing front-ends and > back-ends are aware that only the back-end that added a shared > resource can remove it. > > Acked-by: Stefan Hajnoczi > > Will do :) Should I add the `Acked-by` manually to the commits or does it get automatically picked up later? BR, Albert PS: Happy New Year! > > > > Various improvements for the virtio-dmabuf module. > > This patch includes: > > > > - Check for ownership before allowing a vhost device > > to remove an object from the table. > > - Properly cleanup shared resources if a vhost device > > object gets cleaned up. > > - Rename virtio dmabuf functions to `virtio_dmabuf_*` > > > > Albert Esteve (3): > > hw/virtio: check owner for removing objects > > hw/virtio: cleanup shared resources > > hw/virtio: rename virtio dmabuf API > > > > hw/display/virtio-dmabuf.c| 36 --- > > hw/virtio/vhost-user.c| 31 ++--- > > hw/virtio/vhost.c | 3 ++ > > include/hw/virtio/virtio-dmabuf.h | 43 ++--- > > tests/unit/test-virtio-dmabuf.c | 77 ++- > > 5 files changed, 138 insertions(+), 52 deletions(-) > > > > -- > > 2.43.0 > > > >
Re: [PATCH v2 0/3] Virtio dmabuf improvements
On Thu, 7 Dec 2023 at 09:55, Albert Esteve wrote: > > v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg1005257.html > v1 -> v2: > - Solved an unitialized uuid value on vhost-user source > - Changed cleanup strategy, and traverse all objects in the > table to remove them instead. Please update the vhost-user specification (docs/interop/vhost-user.rst) so people implementing front-ends and back-ends are aware that only the back-end that added a shared resource can remove it. Acked-by: Stefan Hajnoczi > > Various improvements for the virtio-dmabuf module. > This patch includes: > > - Check for ownership before allowing a vhost device > to remove an object from the table. > - Properly cleanup shared resources if a vhost device > object gets cleaned up. > - Rename virtio dmabuf functions to `virtio_dmabuf_*` > > Albert Esteve (3): > hw/virtio: check owner for removing objects > hw/virtio: cleanup shared resources > hw/virtio: rename virtio dmabuf API > > hw/display/virtio-dmabuf.c| 36 --- > hw/virtio/vhost-user.c| 31 ++--- > hw/virtio/vhost.c | 3 ++ > include/hw/virtio/virtio-dmabuf.h | 43 ++--- > tests/unit/test-virtio-dmabuf.c | 77 ++- > 5 files changed, 138 insertions(+), 52 deletions(-) > > -- > 2.43.0 >
